Re: [PATCH 1/4] external-arm-toolchain: Remove glibc locale dependency

["Denys Dmytriyenko" <denis@denix.org>]

On Tue, Jun 02, 2020 at 04:34:51PM +0530, Sumit Garg wrote:
> External Arm tool-set

Why do you call it tool-set? It's definitely not critical, but toolchain is 
kind of a standard name for this:
https://en.wikipedia.org/wiki/Toolchain


> doesn't seem to provide packages corresponding to OE glibc locale recipe.

Actually, the toolchain itself does provide all the gconv libs, AFAICS, 
it's just they are not packaged by the recipe. When I hit it back in April, 
I just didn't have time and ended up with LIBC_DEPENDENCIES_remove hack as 
a temporary workaround, planning to enevtually go back and fix it properly:
http://arago-project.org/git/?p=meta-arago.git;a=blobdiff;f=meta-arago-distro/conf/distro/arago.conf;hb=84c30ee97056589ba0811428527f4adf8268c9b2;hpb=3a4ed9d1e8a118aefb2ef49ce450f74f14e239d0

So, re-using this LIBC_DEPENDENCIES_remove here in upstream meta-arm isn't 
correct...


> So explicitly remove corresponding libc dependencies.
> 
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> ---
>  meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> index 9171380..eee1a51 100644
> --- a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> +++ b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> @@ -58,6 +58,7 @@ DISTRO_FEATURES_LIBC = "ipv4 ipv6 libc-backtrace libc-big-macros libc-bsd libc-c
>  ENABLE_BINARY_LOCALE_GENERATION = "0"
>  GLIBC_INTERNAL_USE_BINARY_LOCALE = "precompiled"
>  LIBCOVERRIDE = ":libc-glibc"
> +LIBC_DEPENDENCIES_remove = "glibc-gconv-cp1252 glibc-gconv-ibm850 glibc-gconv-iso8859-1 glibc-gconv-iso8859-15 glibc-localedata-i18n"

You shouldn't be using _remove in meta-arm, as it's not the final layer and 
there won't be any way to override this in BSPs or Distros.


>  ERROR_QA[type] ?= "list"
>  python toolchain_metadata_setup () {
> -- 
> 2.7.4
>