From: Kevin Wolf <kwolf@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
Cleber Rosa <crosa@redhat.com>,
philmd@redhat.com, qemu-devel@nongnu.org,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH v3 0/3] python/machine.py: refactor shutdown
Date: Fri, 5 Jun 2020 11:34:53 +0200 [thread overview]
Message-ID: <20200605093453.GF5869@linux.fritz.box> (raw)
In-Reply-To: <20200604195252.20739-1-jsnow@redhat.com>
Am 04.06.2020 um 21:52 hat John Snow geschrieben:
> v3:
> - Split _post_shutdown refactor into own patch (now 1/3)
Feels much easier to read now!
> - Re-add sigkill warning squelch (now 3/3)
>
> NOTE: I re-added the squelch in its own patch for review purposes, but
> for the purposes of avoiding temporary breakage, a maintainer may wish
> to squash patches 2 and 3 if they are accepted.
As I found in the v2 review that we don't even have a single user of
hard=True, I don't think it matters. A separate patch makes things
easier to understand, so I would leave it as you have it in this series.
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2020-06-05 9:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 19:52 [PATCH v3 0/3] python/machine.py: refactor shutdown John Snow
2020-06-04 19:52 ` [PATCH v3 1/3] python/machine.py: consolidate _post_shutdown() John Snow
2020-06-04 19:52 ` [PATCH v3 2/3] python/machine.py: refactor shutdown John Snow
2020-06-04 19:52 ` [PATCH v3 3/3] python/machine.py: re-add sigkill warning suppression John Snow
2020-06-05 9:34 ` Kevin Wolf [this message]
2020-06-09 13:08 ` [PATCH v3 0/3] python/machine.py: refactor shutdown Philippe Mathieu-Daudé
2020-06-09 21:55 ` John Snow
2020-06-15 15:21 ` Philippe Mathieu-Daudé
2020-06-15 22:21 ` Eduardo Habkost
2020-06-16 15:06 ` John Snow
2020-06-16 15:36 ` Philippe Mathieu-Daudé
2020-06-16 21:49 ` Cleber Rosa
2020-06-17 17:13 ` Philippe Mathieu-Daudé
2020-06-20 10:14 ` Philippe Mathieu-Daudé
2020-06-22 17:51 ` John Snow
2020-06-22 17:55 ` Philippe Mathieu-Daudé
2020-06-22 18:08 ` John Snow
2020-06-22 18:28 ` Philippe Mathieu-Daudé
2020-06-26 17:28 ` John Snow
2020-06-17 17:15 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605093453.GF5869@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.