From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D62DC433DF for ; Fri, 5 Jun 2020 14:42:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16B49206DC for ; Fri, 5 Jun 2020 14:42:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16B49206DC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7DA036E91E; Fri, 5 Jun 2020 14:42:24 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id C64666E91E for ; Fri, 5 Jun 2020 14:42:22 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id B27F88050B; Fri, 5 Jun 2020 16:42:20 +0200 (CEST) Date: Fri, 5 Jun 2020 16:42:19 +0200 From: Sam Ravnborg To: Thomas Zimmermann Subject: Re: [PATCH 09/14] drm/mgag200: Prefix global names in mgag200_drv.c with mgag200_ Message-ID: <20200605144219.GC204352@ravnborg.org> References: <20200605135803.19811-1-tzimmermann@suse.de> <20200605135803.19811-10-tzimmermann@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200605135803.19811-10-tzimmermann@suse.de> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=G88y7es5 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=1kodD8jTeq0VAdw8cTYA:9 a=CjuIK1q_8ugA:10 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@redhat.com, dri-devel@lists.freedesktop.org, kraxel@redhat.com, emil.velikov@collabora.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jun 05, 2020 at 03:57:58PM +0200, Thomas Zimmermann wrote: > The naming of global symbols in mgag200_drv.c is inconsistent. Fix > that by prefixing all names with mgag200_. Hmm, static symbols are hardly global symbols. Patch is fine, but changelog seems a litte off. Sam > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/mgag200/mgag200_drv.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c > index 670e12d57dea8..ad74e02d8f251 100644 > --- a/drivers/gpu/drm/mgag200/mgag200_drv.c > +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c > @@ -27,7 +27,7 @@ module_param_named(modeset, mgag200_modeset, int, 0400); > > DEFINE_DRM_GEM_FOPS(mgag200_driver_fops); > > -static struct drm_driver driver = { > +static struct drm_driver mgag200_driver = { > .driver_features = DRIVER_ATOMIC | DRIVER_GEM | DRIVER_MODESET, > .fops = &mgag200_driver_fops, > .name = DRIVER_NAME, > @@ -43,7 +43,7 @@ static struct drm_driver driver = { > * PCI driver > */ > > -static const struct pci_device_id pciidlist[] = { > +static const struct pci_device_id mgag200_pciidlist[] = { > { PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0, > G200_SE_A | MGAG200_FLAG_HW_BUG_NO_STARTADD}, > { PCI_VENDOR_ID_MATROX, 0x524, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_B }, > @@ -56,10 +56,10 @@ static const struct pci_device_id pciidlist[] = { > {0,} > }; > > -MODULE_DEVICE_TABLE(pci, pciidlist); > +MODULE_DEVICE_TABLE(pci, mgag200_pciidlist); > > - > -static int mga_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > +static int > +mgag200_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > { > struct drm_device *dev; > int ret; > @@ -70,7 +70,7 @@ static int mga_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > if (ret) > return ret; > > - dev = drm_dev_alloc(&driver, &pdev->dev); > + dev = drm_dev_alloc(&mgag200_driver, &pdev->dev); > if (IS_ERR(dev)) > return PTR_ERR(dev); > > @@ -96,7 +96,7 @@ static int mga_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > return ret; > } > > -static void mga_pci_remove(struct pci_dev *pdev) > +static void mgag200_pci_remove(struct pci_dev *pdev) > { > struct drm_device *dev = pci_get_drvdata(pdev); > > @@ -107,9 +107,9 @@ static void mga_pci_remove(struct pci_dev *pdev) > > static struct pci_driver mgag200_pci_driver = { > .name = DRIVER_NAME, > - .id_table = pciidlist, > - .probe = mga_pci_probe, > - .remove = mga_pci_remove, > + .id_table = mgag200_pciidlist, > + .probe = mgag200_pci_probe, > + .remove = mgag200_pci_remove, > }; > > static int __init mgag200_init(void) > -- > 2.26.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel