All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: Tomasz Duszynski <tomasz.duszynski@octakon.com>,
	"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Matt Ranostay <mranostay@gmail.com>
Subject: Re: [PATCH] iio: improve IIO_CONCENTRATION channel type description
Date: Sat, 6 Jun 2020 15:46:03 +0100	[thread overview]
Message-ID: <20200606154603.0fd52019@archlinux> (raw)
In-Reply-To: <CAJCx=gkXrNV1pHHBYFcKUttkN=Vc9i_1fOh4stCG3f_GWVJfYA@mail.gmail.com>

On Mon, 1 Jun 2020 14:19:43 -0700
Matt Ranostay <matt.ranostay@konsulko.com> wrote:

> On Mon, Jun 1, 2020 at 9:18 AM Tomasz Duszynski
> <tomasz.duszynski@octakon.com> wrote:
> >
> > IIO_CONCENTRATION together with INFO_RAW specifier is used for reporting
> > raw concentrations of pollutants. Raw value should be meaningless
> > before being properly scaled. Because of that description shouldn't
> > mention raw value unit whatsoever.
> >
> > Fix this by rephrasing existing description so it follows conventions
> > used throughout IIO ABI docs.  
> 
> Acked-by: Matt Ranostay <matt.ranostay@konsulko.com>

Thanks for tidying that up.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to ignore.

Thanks,

Jonathan

> 
> >
> > Fixes: 8ff6b3bc94930 ("iio: chemical: Add IIO_CONCENTRATION channel type")
> > Signed-off-by: Tomasz Duszynski <tomasz.duszynski@octakon.com>
> > ---
> >  Documentation/ABI/testing/sysfs-bus-iio | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> > index d3e53a6d8331..5c62bfb0f3f5 100644
> > --- a/Documentation/ABI/testing/sysfs-bus-iio
> > +++ b/Documentation/ABI/testing/sysfs-bus-iio
> > @@ -1569,7 +1569,8 @@ What:             /sys/bus/iio/devices/iio:deviceX/in_concentrationX_voc_raw
> >  KernelVersion: 4.3
> >  Contact:       linux-iio@vger.kernel.org
> >  Description:
> > -               Raw (unscaled no offset etc.) percentage reading of a substance.
> > +               Raw (unscaled no offset etc.) reading of a substance. Units
> > +               after application of scale and offset are percents.
> >
> >  What:          /sys/bus/iio/devices/iio:deviceX/in_resistance_raw
> >  What:          /sys/bus/iio/devices/iio:deviceX/in_resistanceX_raw
> > --
> > 2.26.2
> >  


      reply	other threads:[~2020-06-06 14:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01 16:15 [PATCH] iio: improve IIO_CONCENTRATION channel type description Tomasz Duszynski
2020-06-01 21:19 ` Matt Ranostay
2020-06-06 14:46   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200606154603.0fd52019@archlinux \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.ranostay@konsulko.com \
    --cc=mranostay@gmail.com \
    --cc=tomasz.duszynski@octakon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.