All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Marek Vasut <marex@denx.de>,
	ML dri-devel <dri-devel@lists.freedesktop.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Robert Chiras <robert.chiras@nxp.com>,
	leonard.crestez@nxp.com
Subject: Re: [PATCH v2 20/22] drm: mxsfb: Merge mxsfb_set_pixel_fmt() and mxsfb_set_bus_fmt()
Date: Sun, 7 Jun 2020 02:01:59 +0300	[thread overview]
Message-ID: <20200606230159.GM7339@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CACvgo51QNp745AKkW6CqEUGQ=Jx9v4hqp3YguZpVmvZWwx9y2g@mail.gmail.com>

Hi Emil,

On Fri, Jun 05, 2020 at 03:58:53PM +0100, Emil Velikov wrote:
> Hi Laurent,
> 
> With the previous disclaimer in mind, the series is:
> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

Sorry, which disclaimer is that ?

> There's a small suggestion inline, for future work.
> 
> On Sat, 30 May 2020 at 04:11, Laurent Pinchart wrote:
> 
> >         switch (bus_format) {
> >         case MEDIA_BUS_FMT_RGB565_1X16:
> > -               reg |= CTRL_BUS_WIDTH_16;
> > +               ctrl |= CTRL_BUS_WIDTH_16;
> >                 break;
> >         case MEDIA_BUS_FMT_RGB666_1X18:
> > -               reg |= CTRL_BUS_WIDTH_18;
> > +               ctrl |= CTRL_BUS_WIDTH_18;
> >                 break;
> >         case MEDIA_BUS_FMT_RGB888_1X24:
> > -               reg |= CTRL_BUS_WIDTH_24;
> > +               ctrl |= CTRL_BUS_WIDTH_24;
> >                 break;
> >         default:
> >                 dev_err(drm->dev, "Unknown media bus format %d\n", bus_format);
> >                 break;
> 
> Off the top of my head, the default case should be handled in the
> atomic_check() hook.
> That is, unless I'm missing something and one can change the bus
> format in between atomic_check() and atomic_enable(). Which would
> sound like a very odd thing to do.

I agree, this should go to the atomic check. There are still quite a few
things to improve in this driver, one step at a time :-)

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-06-06 23:02 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-30  3:09 [PATCH v2 00/22] drm: mxsfb: Add i.MX7 support Laurent Pinchart
2020-05-30  3:09 ` [PATCH v2 01/22] drm: mxsfb: Remove fbdev leftovers Laurent Pinchart
2020-05-30  3:09 ` [PATCH v2 02/22] drm: mxsfb: Use drm_panel_bridge Laurent Pinchart
2020-06-17 15:25   ` Stefan Agner
2020-05-30  3:09 ` [PATCH v2 03/22] drm: mxsfb: Use BIT() macro to define register bitfields Laurent Pinchart
2020-05-30  3:09 ` [PATCH v2 04/22] drm: mxsfb: Remove unused macros from mxsfb_regs.h Laurent Pinchart
2020-05-30  3:09 ` [PATCH v2 05/22] drm: mxsfb: Clarify format and bus width configuration Laurent Pinchart
2020-05-30  3:09 ` [PATCH v2 06/22] drm: mxsfb: Pass mxsfb_drm_private pointer to mxsfb_reset_block() Laurent Pinchart
2020-05-30  3:10 ` [PATCH v2 07/22] drm: mxsfb: Use LCDC_CTRL register name explicitly Laurent Pinchart
2020-05-30  3:10 ` [PATCH v2 08/22] drm: mxsfb: Remove register definitions from mxsfb_crtc.c Laurent Pinchart
2020-05-30  3:10 ` [PATCH v2 09/22] drm: mxsfb: Remove unneeded includes Laurent Pinchart
2020-05-30  3:10 ` [PATCH v2 10/22] drm: mxsfb: Rename mxsfb_crtc.c to mxsfb_kms.c Laurent Pinchart
2020-05-30  3:10 ` [PATCH v2 11/22] drm: mxsfb: Stop using DRM simple display pipeline helper Laurent Pinchart
2020-06-11 19:33   ` Stefan Agner
2020-06-16  1:50     ` Laurent Pinchart
2020-07-09 10:25       ` Stefan Agner
2020-07-17  2:06         ` Laurent Pinchart
2020-07-26 18:28           ` Laurent Pinchart
2020-07-27  7:57             ` Stefan Agner
2020-05-30  3:10 ` [PATCH v2 12/22] drm: mxsfb: Move vblank event arm to CRTC .atomic_flush() Laurent Pinchart
2020-05-30  3:10 ` [PATCH v2 13/22] drm: mxsfb: Don't touch AXI clock in IRQ context Laurent Pinchart
2020-05-30  3:10 ` [PATCH v2 14/22] drm: mxsfb: Enable vblank handling Laurent Pinchart
2020-06-11 18:35   ` Stefan Agner
2020-05-30  3:10 ` [PATCH v2 15/22] drm: mxsfb: Remove mxsfb_devdata unused fields Laurent Pinchart
2020-05-30  3:10 ` [PATCH v2 16/22] drm: mxsfb: Add i.MX7 and i.MX8M to the list of supported SoCs in Kconfig Laurent Pinchart
2020-06-11 18:37   ` Stefan Agner
2020-05-30  3:10 ` [PATCH v2 17/22] drm: mxsfb: Update internal IP version number for i.MX6SX Laurent Pinchart
2020-05-30  3:10 ` [PATCH v2 18/22] drm: mxsfb: Drop non-OF support Laurent Pinchart
2020-05-30  3:10 ` [PATCH v2 19/22] drm: mxsfb: Turn mxsfb_set_pixel_fmt() into a void function Laurent Pinchart
2020-05-30  3:10 ` [PATCH v2 20/22] drm: mxsfb: Merge mxsfb_set_pixel_fmt() and mxsfb_set_bus_fmt() Laurent Pinchart
2020-06-05 14:58   ` Emil Velikov
2020-06-06 23:01     ` Laurent Pinchart [this message]
2020-06-15 19:31       ` Emil Velikov
2020-05-30  3:10 ` [PATCH v2 21/22] drm: mxsfb: Remove unnecessary spaces after tab Laurent Pinchart
2020-06-11 19:11   ` Stefan Agner
2020-05-30  3:10 ` [PATCH v2 22/22] drm: mxsfb: Support the alpha plane Laurent Pinchart
2020-05-31 16:54   ` Emil Velikov
2020-06-02 22:42     ` Laurent Pinchart
2020-06-05 14:07       ` Emil Velikov
2020-06-17 16:08   ` Stefan Agner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200606230159.GM7339@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-imx@nxp.com \
    --cc=marex@denx.de \
    --cc=robert.chiras@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.