diff for duplicates of <20200608072625.GV30374@kadam> diff --git a/a/1.txt b/N1/1.txt index 8c7f978..25d173e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -17,17 +17,17 @@ Same rules apply everywhere. I'm not going to comment on every line. > case RTSDUR_BA_F0: /* RTSDuration_ba_f0 */ > - uCTSTime = bb_get_frame_time(pDevice->byPreambleType, byPktType, 14, pDevice->byTopCCKBasicRate); -> - if ((byFBOption = AUTO_FB_0) && (wRate >= RATE_18M) && (wRate <= RATE_54M)) +> - if ((byFBOption == AUTO_FB_0) && (wRate >= RATE_18M) && (wRate <= RATE_54M)) > + uCTSTime = bb_get_frame_time(pDevice->byPreambleType, byPktType, > + 14, pDevice->byTopCCKBasicRate); -> + if ((byFBOption = AUTO_FB_0) && (wRate >= RATE_18M) && +> + if ((byFBOption == AUTO_FB_0) && (wRate >= RATE_18M) && > + (wRate <= RATE_54M)) Here it's awkward to break the two wRate conditions across multiple lines. It's better to write: - if ((byFBOption = AUTO_FB_0) && + if ((byFBOption == AUTO_FB_0) && (wRate >= RATE_18M) && (wRate <= RATE_54M)) regards, diff --git a/a/content_digest b/N1/content_digest index 8b4a7a1..712e662 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020200607224156.GA24090@ip-172-31-24-31.ec2.internal\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" - "Subject\0Re: Forest Bond <forest@alittletooquiet.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,devel@d\0" - "Date\0Mon, 08 Jun 2020 07:26:25 +0000\0" + "Subject\0Re: Forest Bond <forest@alittletooquiet.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,devel@driverdev.osuosl.org,linux-kernel@vger.kernel.org\0" + "Date\0Mon, 8 Jun 2020 10:26:25 +0300\0" "To\0Rodolfo C. Villordo <rodolfovillordo@gmail.com>\0" "Cc\0Forest Bond <forest@alittletooquiet.net>" Greg Kroah-Hartman <gregkh@linuxfoundation.org> @@ -28,20 +28,20 @@ "\n" "> \tcase RTSDUR_BA_F0: /* RTSDuration_ba_f0 */\n" "> -\t\tuCTSTime = bb_get_frame_time(pDevice->byPreambleType, byPktType, 14, pDevice->byTopCCKBasicRate);\n" - "> -\t\tif ((byFBOption = AUTO_FB_0) && (wRate >= RATE_18M) && (wRate <= RATE_54M))\n" + "> -\t\tif ((byFBOption == AUTO_FB_0) && (wRate >= RATE_18M) && (wRate <= RATE_54M))\n" "> +\t\tuCTSTime = bb_get_frame_time(pDevice->byPreambleType, byPktType,\n" "> +\t\t\t\t\t 14, pDevice->byTopCCKBasicRate);\n" - "> +\t\tif ((byFBOption = AUTO_FB_0) && (wRate >= RATE_18M) &&\n" + "> +\t\tif ((byFBOption == AUTO_FB_0) && (wRate >= RATE_18M) &&\n" "> +\t\t (wRate <= RATE_54M))\n" "\n" "\n" "Here it's awkward to break the two wRate conditions across multiple\n" "lines. It's better to write:\n" "\n" - "\t\tif ((byFBOption = AUTO_FB_0) &&\n" + "\t\tif ((byFBOption == AUTO_FB_0) &&\n" "\t (wRate >= RATE_18M) && (wRate <= RATE_54M))\n" "\n" "regards,\n" dan carpenter -b049c7c8e3edc9a0a673b273e93d934df251bf1bb9ca03c2d04e6251b34803c3 +f1c6b2e3695a312af641d2dd647799b86b3ab8b0ef92a184a010a78bebbbba91
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.