All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] LIB: Use INTERNAL_LIB for ltp lib
Date: Mon, 8 Jun 2020 12:10:32 +0200	[thread overview]
Message-ID: <20200608101032.GA9222@dell5510> (raw)
In-Reply-To: <1591083478-5342-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>

Hi Xu,

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Cyril concerned 3rd party use of lib/libltp.a, but nobody complained.
Given Jan acked v1, I'd be also for merge.

> Use INTERNAL_LIB for ltp lib because installing these ltp static
> library in any situation is meaningless.

> all static library as below:
> ./libs/libltpuinput/libltpuinput.a
> ./libs/libltpnewipc/libltpnewipc.a
> ./libs/libltpnuma/libltpnuma.a
> ./libs/libltpipc/libltpipc.a
> ./libs/libltpipc/libltpmsgctl.a
> ./utils/sctp/lib/libsctp.a
> ./utils/sctp/testlib/libsctputil.a
> ./lib/libltp.a
> ./testcases/network/rpc/basic_tests/rpc01/lib/librpc01.a
> ./testcases/network/rpc/rpc-tirpc/tests_pack/lib/librpc-tirpc.a
> ./testcases/kernel/containers/libclone/libclone.a
> ./testcases/kernel/mem/hugetlb/lib/libhugetlb.a
> ./testcases/kernel/mem/lib/libmem.a
> ./testcases/kernel/controllers/libcontrollers/libcontrollers.a
> ./testcases/kernel/controllers/cpuset/cpuset_lib/libcpu_set.a
> ./testcases/kernel/lib/libkerntest.a
nit: I'd remove './' from commit message.

Kind regards,
Petr

> Also include Android_libpthread and android_librt and remove useless
> libdir variable.

> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> ---
> v1->v2:
> 1.remove ./testcases/commands/nm/datafiles/lib.a from commit message
> 2.add two anroid Makefiles
> 3.remove useless libdir
FYI I'm still having in my mind trying dynamic library linking.
But if I ever do it I'll just re-add this variable.

Kind regards,
Petr

  reply	other threads:[~2020-06-08 10:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-02  7:37 [LTP] [PATCH v2] LIB: Use INTERNAL_LIB for ltp lib Yang Xu
2020-06-08 10:10 ` Petr Vorel [this message]
2020-06-08 11:01   ` Yang Xu
2020-06-08 11:41     ` Petr Vorel
     [not found] <57a1c19e-d8e5-4389-8565-20e49f144657@G08CNEXMBPEKD05.g08.fujitsu.local>
2020-06-10  1:28 ` Yang Xu
2020-06-10  8:05   ` Petr Vorel
2020-06-10  8:21     ` Yang Xu
2020-06-10  9:51       ` Petr Vorel
2020-06-10  8:47     ` Xiao Yang
2020-06-10 10:48       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200608101032.GA9222@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.