From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B90F9C433DF for ; Mon, 8 Jun 2020 14:51:56 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 2B4132076C for ; Mon, 8 Jun 2020 14:51:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="H0W6Kxn1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B4132076C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 729794B1BC; Mon, 8 Jun 2020 10:51:55 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b0xcMmwBBX5o; Mon, 8 Jun 2020 10:51:54 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4FAD74B1A9; Mon, 8 Jun 2020 10:51:54 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 12BAC4B1A9 for ; Mon, 8 Jun 2020 10:51:53 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VeJ6Zla1GHXH for ; Mon, 8 Jun 2020 10:51:52 -0400 (EDT) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 0552A4B151 for ; Mon, 8 Jun 2020 10:51:52 -0400 (EDT) Received: by mail-wr1-f67.google.com with SMTP id l11so17739730wru.0 for ; Mon, 08 Jun 2020 07:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=09t4vJAEJNOcAKbjc/XrD7rKiwG3r51o8wQyvTLcyH8=; b=H0W6Kxn1tWB0Gd5mhqe5+76N1JoRrfQBzuFyeHyKdKuKr3c0mxvi1yAFcfLLIJyh55 0k8dOPOj9CmK+GRAegeskyYIv+TKDj2iQeUXFmB0nzECSIxyFfzhVJWU9aWVBdTEchFP GlzcpS27DdL03xE79FQZzpNvHLcxsYPNwzcAPR76BqA9jTXdUk/YUdxlqW4FAdbBRwNf larkyRCJnjdssMA6KHO2gAUNviKrbJ7XhB3sWo/Wp1musUseGP2k62qvdmy2yuoLieci tP3J5viTXpUZQyvmoWug1BfYa6vn0NDeWQAQ07YD0Y4SXO0NCVrrvhcExX8dj7+yQfL9 PSSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=09t4vJAEJNOcAKbjc/XrD7rKiwG3r51o8wQyvTLcyH8=; b=ZYHxkZJO6XCIdo0/S8tVvwOq2295mahq5XELuztuGVxWfNwRKr4EBxCRfoSkIC2DeG wR8T9DCn221N0Zpgh1zU0e8Np0ve1e9/+NyZPf04PFEwL0pL6tenJ5yMDqljzKbQKWxQ cmTqzKLh81aHM94rgk4lCosdvOdMvrEFRW1hzvKLR5uiCPhY8RZuDzIrxBl9Ur2UnCjt 6KyaQ3tToaakgvKWBSUX+sg+RwY1OW737R3O7DI2Rr5JDb0viNpZ98hAf8JjjuK/+rni /zZxuOW1LWvlAJS/ExBBANhzPbKN6Z3Kbi9MiNW+XlBa8tO20xNbek/64gnHPstkZQZY vVKQ== X-Gm-Message-State: AOAM533qsLnE13sDHWvpY9ekgkXDT2K9rUN1AiaGye+qQeCSFaD5Giam 6uJlZftPAHbyn3iutox3cK25xQ== X-Google-Smtp-Source: ABdhPJw/eKBztQ3a9E6WKUS5WsHzaQqYg5KTtA62h7WxrR2Vb+QDhRKkaSCaXQP78CvwMVocDYT20A== X-Received: by 2002:a5d:558a:: with SMTP id i10mr25577401wrv.207.1591627910886; Mon, 08 Jun 2020 07:51:50 -0700 (PDT) Received: from google.com ([2a00:79e0:d:109:355c:447d:ad3d:ac5c]) by smtp.gmail.com with ESMTPSA id c5sm19131623wma.20.2020.06.08.07.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 07:51:50 -0700 (PDT) Date: Mon, 8 Jun 2020 15:51:45 +0100 From: Andrew Scull To: Marc Zyngier Subject: Re: [PATCH v2] KVM: arm64: Remove host_cpu_context member from vcpu structure Message-ID: <20200608145145.GA96714@google.com> References: <20200608085657.1405730-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200608085657.1405730-1-maz@kernel.org> Cc: kvm@vger.kernel.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, Jun 08, 2020 at 09:56:57AM +0100, Marc Zyngier wrote: > For very long, we have kept this pointer back to the per-cpu > host state, despite having working per-cpu accessors at EL2 > for some time now. > > Recent investigations have shown that this pointer is easy > to abuse in preemptible context, which is a sure sign that > it would better be gone. Not to mention that a per-cpu > pointer is faster to access at all times. Helps to make the references to `kvm_host_data` clearer with there now being just one way to get to it and shows that it is scoped to the current CPU. A good change IMO! _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 383EAC433E0 for ; Mon, 8 Jun 2020 14:52:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03BB620774 for ; Mon, 8 Jun 2020 14:52:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IeNPqB+j"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="H0W6Kxn1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03BB620774 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wYs63bODVXcjHDzeiFVgnC63yVoevK4ItgqCqAuD+Wg=; b=IeNPqB+jUrIQp3 B6JQf7KRBT05/IUhkjEBeV9DPuK71KwE+EAdpRc+apZTO3KUg8YSPr4glQLE8Ou1iTYui/RydN2VA hm0mmP01scfyU91VWvpn4rnTUQVsRd8ECAdGFiSCbI4HGpbUOjiPnBuzY03M0lnckrLBTzezIbjuc 1uaWosXf26ctigXlSILWkmEknxRsOZ2aGmHeoyVIeP34Ln7G3F0Za+MVQodBREZfqoZFhDicsibTG PB1+y6rvIYsdxY3/PkLV/D3PbfiKyIT4VMyFoH7tiqAg/SXz/rVA7lJeQUuSuw5ZFRaNEbq1OsY3H YD9MRQz64HUCrldcUhHw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiJ84-0007bM-5G; Mon, 08 Jun 2020 14:52:00 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiJ7y-0007Yt-NG for linux-arm-kernel@lists.infradead.org; Mon, 08 Jun 2020 14:51:58 +0000 Received: by mail-wr1-x444.google.com with SMTP id j10so17726380wrw.8 for ; Mon, 08 Jun 2020 07:51:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=09t4vJAEJNOcAKbjc/XrD7rKiwG3r51o8wQyvTLcyH8=; b=H0W6Kxn1tWB0Gd5mhqe5+76N1JoRrfQBzuFyeHyKdKuKr3c0mxvi1yAFcfLLIJyh55 0k8dOPOj9CmK+GRAegeskyYIv+TKDj2iQeUXFmB0nzECSIxyFfzhVJWU9aWVBdTEchFP GlzcpS27DdL03xE79FQZzpNvHLcxsYPNwzcAPR76BqA9jTXdUk/YUdxlqW4FAdbBRwNf larkyRCJnjdssMA6KHO2gAUNviKrbJ7XhB3sWo/Wp1musUseGP2k62qvdmy2yuoLieci tP3J5viTXpUZQyvmoWug1BfYa6vn0NDeWQAQ07YD0Y4SXO0NCVrrvhcExX8dj7+yQfL9 PSSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=09t4vJAEJNOcAKbjc/XrD7rKiwG3r51o8wQyvTLcyH8=; b=QMSjm4BNIKl4vzhgYJzGGbOd9PqMLqbtemVelf8Ln7fGGMXFxZ374VgOl8u/Us83G4 25LpvhFxbP6cDgE+z4prN+QszdCYcu4AT1zlfLez+B3yZgulBqLg8eINRWd2xErAHJ8M terh9oWGQfWRPZhXuCOaE6EO9wKHZpVyiRBUDsNaJzRuEzSJ5vlLPqLgdEQBqpZUQczu wajbqFsFboBKNMjk6GPF5hh4jTH8PL1CmKlly54DHnWs2zGz+H8qwJmCGsErOe5kySUB B7s6phl8tmQ3GW1i8O536jvCycpryVrnheslVhIx8mgAwrP8PyXXK59NAVEfIEzFrUt+ I5BQ== X-Gm-Message-State: AOAM530PeoKT179UI8JoOMKtEkzprkixCejrl+slOIUlI/a5EH02UFBY iMc0uFhw+ubJnPEfpHTWwzwapg== X-Google-Smtp-Source: ABdhPJw/eKBztQ3a9E6WKUS5WsHzaQqYg5KTtA62h7WxrR2Vb+QDhRKkaSCaXQP78CvwMVocDYT20A== X-Received: by 2002:a5d:558a:: with SMTP id i10mr25577401wrv.207.1591627910886; Mon, 08 Jun 2020 07:51:50 -0700 (PDT) Received: from google.com ([2a00:79e0:d:109:355c:447d:ad3d:ac5c]) by smtp.gmail.com with ESMTPSA id c5sm19131623wma.20.2020.06.08.07.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 07:51:50 -0700 (PDT) Date: Mon, 8 Jun 2020 15:51:45 +0100 From: Andrew Scull To: Marc Zyngier Subject: Re: [PATCH v2] KVM: arm64: Remove host_cpu_context member from vcpu structure Message-ID: <20200608145145.GA96714@google.com> References: <20200608085657.1405730-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200608085657.1405730-1-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200608_075154_785944_9D6AEA72 X-CRM114-Status: GOOD ( 12.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , kvm@vger.kernel.org, Suzuki K Poulose , James Morse , Julien Thierry , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 08, 2020 at 09:56:57AM +0100, Marc Zyngier wrote: > For very long, we have kept this pointer back to the per-cpu > host state, despite having working per-cpu accessors at EL2 > for some time now. > > Recent investigations have shown that this pointer is easy > to abuse in preemptible context, which is a sure sign that > it would better be gone. Not to mention that a per-cpu > pointer is faster to access at all times. Helps to make the references to `kvm_host_data` clearer with there now being just one way to get to it and shows that it is scoped to the current CPU. A good change IMO! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 015ECC433E0 for ; Mon, 8 Jun 2020 14:51:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C3383206C3 for ; Mon, 8 Jun 2020 14:51:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="H0W6Kxn1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730077AbgFHOvx (ORCPT ); Mon, 8 Jun 2020 10:51:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbgFHOvw (ORCPT ); Mon, 8 Jun 2020 10:51:52 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40099C08C5C2 for ; Mon, 8 Jun 2020 07:51:52 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id l10so17705867wrr.10 for ; Mon, 08 Jun 2020 07:51:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=09t4vJAEJNOcAKbjc/XrD7rKiwG3r51o8wQyvTLcyH8=; b=H0W6Kxn1tWB0Gd5mhqe5+76N1JoRrfQBzuFyeHyKdKuKr3c0mxvi1yAFcfLLIJyh55 0k8dOPOj9CmK+GRAegeskyYIv+TKDj2iQeUXFmB0nzECSIxyFfzhVJWU9aWVBdTEchFP GlzcpS27DdL03xE79FQZzpNvHLcxsYPNwzcAPR76BqA9jTXdUk/YUdxlqW4FAdbBRwNf larkyRCJnjdssMA6KHO2gAUNviKrbJ7XhB3sWo/Wp1musUseGP2k62qvdmy2yuoLieci tP3J5viTXpUZQyvmoWug1BfYa6vn0NDeWQAQ07YD0Y4SXO0NCVrrvhcExX8dj7+yQfL9 PSSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=09t4vJAEJNOcAKbjc/XrD7rKiwG3r51o8wQyvTLcyH8=; b=U1EQuXueewYuPlk83+kKtb49g4SBGtIdABChOd6MP/AQWkgqLBDcy4V/feZG8lZwPN NgWLDJLA/rGD9SCy5mKk1vZ78NWQNnBU9nbYpY+lkRGlIeSqmjJp0rAViCODD9TVN36p YDEmqziNDYcfUltaaO5YU+kA6b7Y9QbLB0CXUiUSh1HcIi4RcX6LdRF96fXIjIXAZLYm FaFkU76eTFMvRqOV1AzSTHQhXaFj8JsF8eyJWQGOQZqJvb9bGIxzD6XUjJFmC1pqbnVS Y3coTHx50A0ftluLOj4nga+edH1IFEgsDbBDRwPyse9p6HB/y3tsjC/6we2fz5gYvMmO 4w0g== X-Gm-Message-State: AOAM531+eqYSSu7xuLWI0aqm2xRS+tGa7h77FAyy+Ltg/9wCt2HDqXD1 f3pCxjkvVziskdLkp7H4yvCEpA== X-Google-Smtp-Source: ABdhPJw/eKBztQ3a9E6WKUS5WsHzaQqYg5KTtA62h7WxrR2Vb+QDhRKkaSCaXQP78CvwMVocDYT20A== X-Received: by 2002:a5d:558a:: with SMTP id i10mr25577401wrv.207.1591627910886; Mon, 08 Jun 2020 07:51:50 -0700 (PDT) Received: from google.com ([2a00:79e0:d:109:355c:447d:ad3d:ac5c]) by smtp.gmail.com with ESMTPSA id c5sm19131623wma.20.2020.06.08.07.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 07:51:50 -0700 (PDT) Date: Mon, 8 Jun 2020 15:51:45 +0100 From: Andrew Scull To: Marc Zyngier Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, James Morse , Julien Thierry , Suzuki K Poulose , Mark Rutland , kernel-team@android.com Subject: Re: [PATCH v2] KVM: arm64: Remove host_cpu_context member from vcpu structure Message-ID: <20200608145145.GA96714@google.com> References: <20200608085657.1405730-1-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200608085657.1405730-1-maz@kernel.org> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Jun 08, 2020 at 09:56:57AM +0100, Marc Zyngier wrote: > For very long, we have kept this pointer back to the per-cpu > host state, despite having working per-cpu accessors at EL2 > for some time now. > > Recent investigations have shown that this pointer is easy > to abuse in preemptible context, which is a sure sign that > it would better be gone. Not to mention that a per-cpu > pointer is faster to access at all times. Helps to make the references to `kvm_host_data` clearer with there now being just one way to get to it and shows that it is scoped to the current CPU. A good change IMO!