All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: nsoffer@redhat.com, vsementsov@virtuozzo.com,
	qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH v6 5/5] iotests: Add test 291 to for qemu-img bitmap coverage
Date: Mon, 8 Jun 2020 21:17:04 +0200	[thread overview]
Message-ID: <20200608191704.GJ6419@linux.fritz.box> (raw)
In-Reply-To: <20200521192137.1120211-6-eblake@redhat.com>

Am 21.05.2020 um 21:21 hat Eric Blake geschrieben:
> Add a new test covering the 'qemu-img bitmap' subcommand, as well as
> 'qemu-img convert --bitmaps', both added in recent patches.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

This one fails for me. We need to filter out "disk size" because it
depends on the filesystem.

Kevin

291      fail       [21:10:19] [21:10:21]                    output mismatch (see 291.out.bad)
--- /home/kwolf/source/qemu/tests/qemu-iotests/291.out  2020-06-08 21:04:38.967014949 +0200
+++ /home/kwolf/source/qemu/tests/qemu-iotests/291.out.bad      2020-06-08 21:10:21.043763527 +0200
@@ -24,7 +24,7 @@
 image: TEST_DIR/t.IMGFMT
 file format: IMGFMT
 virtual size: 10 MiB (10485760 bytes)
-disk size: 4.39 MiB
+disk size: 4.51 MiB
 Format specific information:
     compat: 1.1
     compression type: zlib
@@ -44,7 +44,7 @@
 image: TEST_DIR/t.IMGFMT
 file format: IMGFMT
 virtual size: 10 MiB (10485760 bytes)
-disk size: 4.48 MiB
+disk size: 5.08 MiB
 Format specific information:
     compat: 1.1
     compression type: zlib
Failures: 291
Failed 1 of 1 iotests



  reply	other threads:[~2020-06-08 19:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-21 19:21 [PATCH v6 0/5] qemu-img: Add convert --bitmaps Eric Blake
2020-05-21 19:21 ` [PATCH v6 1/5] iotests: Fix test 178 Eric Blake
2020-05-21 19:21 ` [PATCH v6 2/5] qcow2: Expose bitmaps' size during measure Eric Blake
2020-05-25  7:05   ` Vladimir Sementsov-Ogievskiy
2020-05-21 19:21 ` [PATCH v6 3/5] qemu-img: Factor out code for merging bitmaps Eric Blake
2020-05-25  7:12   ` Vladimir Sementsov-Ogievskiy
2020-05-21 19:21 ` [PATCH v6 4/5] qemu-img: Add convert --bitmaps option Eric Blake
2020-05-25  7:51   ` Vladimir Sementsov-Ogievskiy
2020-05-26 16:27     ` Eric Blake
2020-05-21 19:21 ` [PATCH v6 5/5] iotests: Add test 291 to for qemu-img bitmap coverage Eric Blake
2020-06-08 19:17   ` Kevin Wolf [this message]
2020-06-08 19:32     ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200608191704.GJ6419@linux.fritz.box \
    --to=kwolf@redhat.com \
    --cc=eblake@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=nsoffer@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.