From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17515C433DF for ; Mon, 8 Jun 2020 19:23:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D340B2063A for ; Mon, 8 Jun 2020 19:23:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WYbpuXsn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D340B2063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiNND-0006r5-66 for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 15:23:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiNMT-0006MM-R4 for qemu-devel@nongnu.org; Mon, 08 Jun 2020 15:23:09 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:57319 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiNMT-0000lP-23 for qemu-devel@nongnu.org; Mon, 08 Jun 2020 15:23:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591644187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0FPf6wk6hHv8kNQvGiedcFjWXx0e/vWq1EKp0fEg7Xw=; b=WYbpuXsnlljfHNOy0EpDnJQ5AK3vlSwRnGgXVzkaqB7Enn6T1D11OFobO1vqFpLZmzay0k Bn03HRrjD9sehMMBs6h+OH1hBGjYEsoPlBXVV4KK0TUwopDj5qN25ZUEKfl2Zad1kkarCy u3foiFDPSh5Y+xL20750yw7SvglUXQQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-478-GzQdWERDPpyICmmuShWhnQ-1; Mon, 08 Jun 2020 15:23:06 -0400 X-MC-Unique: GzQdWERDPpyICmmuShWhnQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 521358014D4; Mon, 8 Jun 2020 19:23:05 +0000 (UTC) Received: from linux.fritz.box (ovpn-113-244.ams2.redhat.com [10.36.113.244]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E3FBA19D7D; Mon, 8 Jun 2020 19:23:03 +0000 (UTC) Date: Mon, 8 Jun 2020 21:23:02 +0200 From: Kevin Wolf To: Eric Blake Subject: Re: [PATCH] qcow2: Tweak comments on qcow2_get_persistent_dirty_bitmap_size Message-ID: <20200608192302.GL6419@linux.fritz.box> References: <20200608190821.3293867-1-eblake@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200608190821.3293867-1-eblake@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.120; envelope-from=kwolf@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 01:05:50 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Sementsov-Ogievskiy , John Snow , qemu-devel@nongnu.org, "open list:qcow2" , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 08.06.2020 um 21:08 hat Eric Blake geschrieben: > For now, we don't have persistent bitmaps in any other formats, but > that might not be true in the future. Make it obvious that our > incoming parameter is not necessarily a qcow2 image, and therefore is > limited to just the bdrv_dirty_bitmap_* API calls (rather than probing > into qcow2 internals). > > Suggested-by: Kevin Wolf > Signed-off-by: Eric Blake Thanks, applied to the block branch. Kevin