From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, paulb@mellanox.com, ozsh@mellanox.com,
vladbu@mellanox.com, jiri@resnulli.us, kuba@kernel.org,
saeedm@mellanox.com, michael.chan@broadcom.com
Subject: Re: [PATCH 8/8 net] net: remove indirect block netdev event registration
Date: Mon, 8 Jun 2020 23:47:39 +0200 [thread overview]
Message-ID: <20200608214739.GA12131@salvia> (raw)
In-Reply-To: <59884f4f-df03-98ac-0524-3e58c904f201@intel.com>
[-- Attachment #1: Type: text/plain, Size: 610 bytes --]
On Mon, Jun 08, 2020 at 02:07:57PM -0700, Jacob Keller wrote:
>
>
> On 5/13/2020 9:41 AM, Pablo Neira Ayuso wrote:
> > Drivers do not register to netdev events to set up indirect blocks
> > anymore. Remove __flow_indr_block_cb_register() and
> > __flow_indr_block_cb_unregister().
> >
> > The frontends set up the callbacks through flow_indr_dev_setup_block()
> >
> > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
>
> This commit failed to remove the prototypes from the header file:
> include/net/flow_offload.h
Thanks for reporting.
I'm attaching a sketch, I will submit this formally later.
[-- Attachment #2: x.patch --]
[-- Type: text/x-diff, Size: 1221 bytes --]
diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
index 69e13c8b6b3a..f2c8311a0433 100644
--- a/include/net/flow_offload.h
+++ b/include/net/flow_offload.h
@@ -542,28 +542,4 @@ int flow_indr_dev_setup_offload(struct net_device *dev,
struct flow_block_offload *bo,
void (*cleanup)(struct flow_block_cb *block_cb));
-typedef void flow_indr_block_cmd_t(struct net_device *dev,
- flow_indr_block_bind_cb_t *cb, void *cb_priv,
- enum flow_block_command command);
-
-int __flow_indr_block_cb_register(struct net_device *dev, void *cb_priv,
- flow_indr_block_bind_cb_t *cb,
- void *cb_ident);
-
-void __flow_indr_block_cb_unregister(struct net_device *dev,
- flow_indr_block_bind_cb_t *cb,
- void *cb_ident);
-
-int flow_indr_block_cb_register(struct net_device *dev, void *cb_priv,
- flow_indr_block_bind_cb_t *cb, void *cb_ident);
-
-void flow_indr_block_cb_unregister(struct net_device *dev,
- flow_indr_block_bind_cb_t *cb,
- void *cb_ident);
-
-void flow_indr_block_call(struct net_device *dev,
- struct flow_block_offload *bo,
- enum flow_block_command command,
- enum tc_setup_type type);
-
#endif /* _NET_FLOW_OFFLOAD_H */
next prev parent reply other threads:[~2020-06-08 21:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 16:41 [PATCH 0/8 net] the indirect flow_block offload, revisited Pablo Neira Ayuso
2020-05-13 16:41 ` [PATCH 1/8 net] netfilter: nf_flowtable: expose nf_flow_table_gc_cleanup() Pablo Neira Ayuso
2020-05-13 16:41 ` [PATCH 2/8 net] net: flow_offload: consolidate indirect flow_block infrastructure Pablo Neira Ayuso
2020-05-13 16:41 ` [PATCH 3/8 net] net: cls_api: add tcf_block_offload_init() Pablo Neira Ayuso
2020-05-13 16:41 ` [PATCH 4/8 net] net: use flow_indr_dev_setup_offload() Pablo Neira Ayuso
2020-05-13 16:41 ` [PATCH 5/8 net] mlx5: update indirect block support Pablo Neira Ayuso
2020-05-13 16:41 ` [PATCH 6/8 net] nfp: " Pablo Neira Ayuso
2020-05-13 16:41 ` [PATCH 7/8 net] bnxt_tc: " Pablo Neira Ayuso
2020-05-19 8:53 ` Sriharsha Basavapatna
2020-05-26 21:59 ` Pablo Neira Ayuso
2020-05-13 16:41 ` [PATCH 8/8 net] net: remove indirect block netdev event registration Pablo Neira Ayuso
2020-06-08 21:07 ` Jacob Keller
2020-06-08 21:47 ` Pablo Neira Ayuso [this message]
2020-06-08 22:37 ` Jacob Keller
2020-05-14 11:44 ` [PATCH 0/8 net] the indirect flow_block offload, revisited Edward Cree
2020-05-14 22:36 ` Pablo Neira Ayuso
2020-05-15 0:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608214739.GA12131@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=ozsh@mellanox.com \
--cc=paulb@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=vladbu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.