From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E7CC433E0 for ; Tue, 9 Jun 2020 12:53:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5F9020825 for ; Tue, 9 Jun 2020 12:53:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UHrGL1ya"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sRudMVlH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5F9020825 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O+mkvxbd8uVXZhnkSRifqlseNRcllYE66eRfpJANFC8=; b=UHrGL1yaOs9+la GiIq0c0smH6CmdOL3xcmvOQhd713oqfEK5ia4uny29sb8dZv3nRK3lk1UdcQ5ox+oLQhJKJ6Cz1rV Z4CCs89Ee/TgCMkMBDQ6NOx7T+Zz3nuFQm+1gU1HlYZ0F9S6eKWHie8qVACintsr6BPXT/Ae2nuqj ukRcJQQUyTYC32YneTXLe6kMb4ca/kwNXbPr0oPCwOLTCWIIz47+mAQJ7p76Ovq4x96kKRS2b4VKP EBOo0m3oaGAHq37PG8IsGkmOhRt1hNOil3jFAQQBmm3Y8Qa3jqhBSAJndV+dqqeA9P1xp8vZvSRp7 w68w6wF6Wzh+4+fTnREg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jidkn-0005JR-K2; Tue, 09 Jun 2020 12:53:21 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jidke-0005Aa-Ft for linux-mediatek@lists.infradead.org; Tue, 09 Jun 2020 12:53:14 +0000 Received: by mail-wr1-x442.google.com with SMTP id l10so21158997wrr.10 for ; Tue, 09 Jun 2020 05:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=vrPhBQinJOm2GiOyvxlhSLQ8G2hbgcP888EbPjYnpWE=; b=sRudMVlHtnJjHmIBx59yGnZa7TgnSFmEgOv0HeaNM3Yw6g193AyJONzpDj2K1k4nbZ 3xTl+eARUVcQU6Tt4E8p8c0kSvnhRU6CK94wKp+O1zKCK+BeFLfrkSnDGF3JEPThV4Kd sc07ajaQZQWU4bdYabuqev/2HW/xax9AGAylbGoOfdNWNMt9JNAxjWGIYUtRdbqIhMip Gds5DE0qh1mqcJn4jEGBTyTRPUXERdeb5nY1+Ia72Gg4h/xKlmGIbxdvsgvQNiE0lLDm 86jNWlJqpc7q8mwufN9tb6/TTTnBM3wyRs/wn4wAaI7ZPy32ylNLyC2fvzh8u254T5eN IetQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=vrPhBQinJOm2GiOyvxlhSLQ8G2hbgcP888EbPjYnpWE=; b=ne6qLZEOPyyl9h/m6qfPfkM9jGDRwvJLoQuVKCZz/p0cDT1/55Q7/nreQx2y1yDWGl smBPUWAzI3mZ4sje0DJivv/DojF6sTJ1LuJ8B/48UKxfyvjogMntMewDg153pUxXWeRT jfEqOZeUc65XvZ3Typ+aq10+PyhrwaOQjfwNaYwwSyFZV5jzxrWVX9QRsMH3ZkW+tv7+ fVk4+nCvNORh+RXEteMs178qbQDhDVn52iAfFvlXNSxTxGjLmwdITP5LxwTm3mU5IoEV Rr8Q74iwVPUq+FESh2Xgn6rxOaJOMCu3QQxBICE2UuVXQG7icgIj97ARXHAi+9bTPb+m 3C/A== X-Gm-Message-State: AOAM532C2fAgEEB9Dpcx3fRygV1OfFbOGvxaWP6hnunYdosjmic1yQ35 NPIevJA3HS4slOssoQZnhDgnUg== X-Google-Smtp-Source: ABdhPJyUpfpT9l7B1MvSK8xJp6dacca2BXQKTrAQ4Wc72VOm5cQExzdGg3Ltp/re4zTYpjuCHoMJaA== X-Received: by 2002:adf:feca:: with SMTP id q10mr3990520wrs.380.1591707191199; Tue, 09 Jun 2020 05:53:11 -0700 (PDT) Received: from dell ([2.27.167.101]) by smtp.gmail.com with ESMTPSA id x205sm2925431wmx.21.2020.06.09.05.53.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 05:53:10 -0700 (PDT) Date: Tue, 9 Jun 2020 13:53:05 +0100 From: Lee Jones To: Gene Chen Subject: Re: [PATCH] mfd: mt6360: Fix register driver NULL pointer by add driver name Message-ID: <20200609125305.GL4106@dell> References: <1591609125-3761-1-git-send-email-gene.chen.richtek@gmail.com> <20200608192829.GG4106@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200609_055312_597794_1BBBA599 X-CRM114-Status: GOOD ( 14.76 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gene Chen , linux-kernel@vger.kernel.org, cy_huang@richtek.com, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, Wilma.Wu@mediatek.com, linux-arm-kernel@lists.infradead.org, shufan_lee@richtek.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gVHVlLCAwOSBKdW4gMjAyMCwgR2VuZSBDaGVuIHdyb3RlOgoKPiBMZWUgSm9uZXMgPGxlZS5q b25lc0BsaW5hcm8ub3JnPiDmlrwgMjAyMOW5tDbmnIg55pelIOmAseS6jCDkuIrljYgzOjI45a+r 6YGT77yaCj4gPgo+ID4gT24gTW9uLCAwOCBKdW4gMjAyMCwgR2VuZSBDaGVuIHdyb3RlOgo+ID4K PiA+ID4gRnJvbTogR2VuZSBDaGVuIDxnZW5lX2NoZW5AcmljaHRlay5jb20+Cj4gPiA+Cj4gPiA+ IGFjY2lkZW50YWxseSByZW1vdmUgZHJpdmVyIG5hbWUgd2hlbgo+ID4gPiByZXBsYWNlIHByb2Jl IGJ5IHByb2JlX25ldyBpbiBhZGQgbXQ2MzYwIG1mZCBkcml2ZXIgcGF0Y2ggdjQKPiA+ID4KPiA+ ID4gWyAgMTIxLjI0MzAxMl0gRUFYOiBjMmE4YmM2NCBFQlg6IDAwMDAwMDAwIEVDWDogMDAwMDAw MDAgRURYOiAwMDAwMDAwMAo+ID4gPiBbICAxMjEuMjQzMDEyXSBFU0k6IGMyYThiYzc5IEVESTog MDAwMDAwMDAgRUJQOiBlNTRiZGVhOCBFU1A6IGU1NGJkZWEwCj4gPiA+IFsgIDEyMS4yNDMwMTJd IERTOiAwMDdiIEVTOiAwMDdiIEZTOiAwMDAwIEdTOiAwMDAwIFNTOiAwMDY4IEVGTEFHUzogMDAw MTAyODYKPiA+ID4gWyAgMTIxLjI0MzAxMl0gQ1IwOiA4MDA1MDAzMyBDUjI6IDAwMDAwMDAwIENS MzogMDJlYzMwMDAgQ1I0OiAwMDAwMDZiMAo+ID4gPiBbICAxMjEuMjQzMDEyXSBDYWxsIFRyYWNl Ogo+ID4gPiBbICAxMjEuMjQzMDEyXSAga3NldF9maW5kX29iaisweDNkLzB4YzAKPiA+ID4gWyAg MTIxLjI0MzAxMl0gIGRyaXZlcl9maW5kKzB4MTYvMHg0MAo+ID4gPiBbICAxMjEuMjQzMDEyXSAg ZHJpdmVyX3JlZ2lzdGVyKzB4NDkvMHgxMDAKPiA+ID4gWyAgMTIxLjI0MzAxMl0gID8gaTJjX2Zv cl9lYWNoX2RldisweDM5LzB4NTAKPiA+ID4gWyAgMTIxLjI0MzAxMl0gID8gX19wcm9jZXNzX25l d19hZGFwdGVyKzB4MjAvMHgyMAo+ID4gPiBbICAxMjEuMjQzMDEyXSAgPyBjaHRfd2NfZHJpdmVy X2luaXQrMHgxMS8weDExCj4gPiA+IFsgIDEyMS4yNDMwMTJdICBpMmNfcmVnaXN0ZXJfZHJpdmVy KzB4MzAvMHg4MAo+ID4gPiBbICAxMjEuMjQzMDEyXSAgPyBpbnRlbF9scHNzX3BjaV9kcml2ZXJf aW5pdCsweDE2LzB4MTYKPiA+ID4gWyAgMTIxLjI0MzAxMl0gIG10NjM2MF9wbXVfZHJpdmVyX2lu aXQrMHhmLzB4MTEKPiA+ID4gWyAgMTIxLjI0MzAxMl0gIGRvX29uZV9pbml0Y2FsbCsweDMzLzB4 MWEwCj4gPiA+IFsgIDEyMS4yNDMwMTJdICA/IHBhcnNlX2FyZ3MrMHgxZWIvMHgzZDAKPiA+ID4g WyAgMTIxLjI0MzAxMl0gID8gX19taWdodF9zbGVlcCsweDMxLzB4OTAKPiA+ID4gWyAgMTIxLjI0 MzAxMl0gID8ga2VybmVsX2luaXRfZnJlZWFibGUrMHgxMGEvMHgxN2YKPiA+ID4gWyAgMTIxLjI0 MzAxMl0gIGtlcm5lbF9pbml0X2ZyZWVhYmxlKzB4MTJjLzB4MTdmCj4gPiA+IFsgIDEyMS4yNDMw MTJdICA/IHJlc3RfaW5pdCsweDExMC8weDExMAo+ID4gPiBbICAxMjEuMjQzMDEyXSAga2VybmVs X2luaXQrMHhiLzB4MTAwCj4gPiA+IFsgIDEyMS4yNDMwMTJdICA/IHNjaGVkdWxlX3RhaWxfd3Jh cHBlcisweDkvMHhjCj4gPiA+IFsgIDEyMS4yNDMwMTJdICByZXRfZnJvbV9mb3JrKzB4MTkvMHgy NAo+ID4gPiBbICAxMjEuMjQzMDEyXSBNb2R1bGVzIGxpbmtlZCBpbjoKPiA+ID4gWyAgMTIxLjI0 MzAxMl0gQ1IyOiAwMDAwMDAwMDAwMDAwMDAwCj4gPiA+IFsgIDEyMS4yNDMwMTJdIHJhbmRvbTog Z2V0X3JhbmRvbV9ieXRlcyBjYWxsZWQgZnJvbSBpbml0X29vcHNfaWQrMHgzYS8weDQwIHdpdGgg Y3JuZ19pbml0PTAKPiA+ID4gWyAgMTIxLjI0MzAxMl0gLS0tWyBlbmQgdHJhY2UgMzhhODAzNDAw ZjFhMmJlZSBdLS0tCj4gPiA+IFsgIDEyMS4yNDMwMTJdIEVJUDogc3RyY21wKzB4MTEvMHgzMAo+ ID4KPiA+IEhvdyBkaWQgdGhpcyBkcml2ZXIgZXZlciB3b3JrIGZvciB5b3U/Cj4gCj4gaSBhc2sg bXkgY293b3JrZXIgaGVscCBtZSB2ZXJpZnkuCj4gaSB3aWxsIGNoZWNrIHRoZSBwYXRjaCBteXNl bGYsIHNpbmNlcmVseSBhcG9sb2dpZXMgZm9yIHRoaXMuCgpXaGF0IGRvZXMgdGhpcyBtZWFuPwoK QXJlIHlvdSBzYXlpbmcgdGhhdCBmb3IgYWxsIDEwIHZlcnNpb25zIG9mIHRoaXMgcGF0Y2ggc3Vi bWlzc2lvbiwgaXQKaGFzIG5ldmVyIGJlZW4gdGVzdGVkPyAgQW5kIGRlc3BpdGUgYmVpbmcgYXV0 aG9yZWQgYnkgeW91IGFuZApzdWJtaXR0ZWQgYnkgeW91LCB5b3UgaGF2ZSBuZXZlciBhY3R1YWxs eSBib290IHRlc3RlZCB0aGUgZHJpdmVyCnlvdXJzZWxmPyAgUmVseWluZyBpbnN0ZWFkIG9uIHlv dXIgY28td29ya2VyIHRvIGNvbmR1Y3QgdGhlIHRlc3RpbmcsCndobyBmYWlsZWQgdG8gZG8gc28u ICBJcyB0aGF0IHJlYWxseSBjb3JyZWN0PwoKPiA+ID4gU2lnbmVkLW9mZi1ieTogR2VuZSBDaGVu IDxnZW5lX2NoZW5AcmljaHRlay5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9tZmQvbXQ2 MzYwLWNvcmUuYyB8IDEgKwo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCj4g PiA+Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9tdDYzNjAtY29yZS5jIGIvZHJpdmVy cy9tZmQvbXQ2MzYwLWNvcmUuYwo+ID4gPiBpbmRleCBkYjhjZGY1Li5lOWNhY2MyIDEwMDY0NAo+ ID4gPiAtLS0gYS9kcml2ZXJzL21mZC9tdDYzNjAtY29yZS5jCj4gPiA+ICsrKyBiL2RyaXZlcnMv bWZkL210NjM2MC1jb3JlLmMKPiA+ID4gQEAgLTQxMiw2ICs0MTIsNyBAQCBNT0RVTEVfREVWSUNF X1RBQkxFKG9mLCBtdDYzNjBfcG11X29mX2lkKTsKPiA+ID4KPiA+ID4gIHN0YXRpYyBzdHJ1Y3Qg aTJjX2RyaXZlciBtdDYzNjBfcG11X2RyaXZlciA9IHsKPiA+ID4gICAgICAgLmRyaXZlciA9IHsK PiA+ID4gKyAgICAgICAgICAgICAubmFtZSA9ICJtdDYzNjBfcG11IiwKPiA+ID4gICAgICAgICAg ICAgICAucG0gPSAmbXQ2MzYwX3BtdV9wbV9vcHMsCj4gPiA+ICAgICAgICAgICAgICAgLm9mX21h dGNoX3RhYmxlID0gb2ZfbWF0Y2hfcHRyKG10NjM2MF9wbXVfb2ZfaWQpLAo+ID4gPiAgICAgICB9 LAo+ID4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KU2VuaW9yIFRlY2huaWNhbCBMZWFkIC0g RGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZv ciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1tZWRpYXRl ayBtYWlsaW5nIGxpc3QKTGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW1lZGlhdGVrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8BA3C433E0 for ; Tue, 9 Jun 2020 12:53:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7ACA6206A4 for ; Tue, 9 Jun 2020 12:53:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Jo8ivM2J"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sRudMVlH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7ACA6206A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Zw64Ua2Y1krL8aXJnELdVocu5eWPWLQyF6bma20MMnk=; b=Jo8ivM2JOugwuP XMV+0o7+xH5naoLmMIouVFTx53g3X9l0bJO94LzNHjDqGrCxEluxC2MFm45hv3NJX+fS4i/Djctja p5eRB6oWIlIV5bpRA/OG+KmtuTpvCL6ShxfIHyHtwnvOqvx8Dvnuql3GnDcu1E8DSbIokUOsqranH NdQKnjsfII1ytbmdMOmCZ8YCg38t6wG2jkrQB65MFDrka6SzcEu+8SpqXAbK+3aqkmfpO7Ml7WFmr L5snYYVCXo85cyBvLQIWZ/xOVvtB/dP6SRCMysJAk6uMiKoOAMhdRmzERRlHKbBhNGSfC7qyU2EMf XbTI+d5iq67H1YiW4F4A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jidkh-0005BH-Jd; Tue, 09 Jun 2020 12:53:15 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jidke-0005Ab-Fp for linux-arm-kernel@lists.infradead.org; Tue, 09 Jun 2020 12:53:14 +0000 Received: by mail-wr1-x442.google.com with SMTP id l11so21188215wru.0 for ; Tue, 09 Jun 2020 05:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=vrPhBQinJOm2GiOyvxlhSLQ8G2hbgcP888EbPjYnpWE=; b=sRudMVlHtnJjHmIBx59yGnZa7TgnSFmEgOv0HeaNM3Yw6g193AyJONzpDj2K1k4nbZ 3xTl+eARUVcQU6Tt4E8p8c0kSvnhRU6CK94wKp+O1zKCK+BeFLfrkSnDGF3JEPThV4Kd sc07ajaQZQWU4bdYabuqev/2HW/xax9AGAylbGoOfdNWNMt9JNAxjWGIYUtRdbqIhMip Gds5DE0qh1mqcJn4jEGBTyTRPUXERdeb5nY1+Ia72Gg4h/xKlmGIbxdvsgvQNiE0lLDm 86jNWlJqpc7q8mwufN9tb6/TTTnBM3wyRs/wn4wAaI7ZPy32ylNLyC2fvzh8u254T5eN IetQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=vrPhBQinJOm2GiOyvxlhSLQ8G2hbgcP888EbPjYnpWE=; b=QMC52FS3CRYhlczq6VhxBtu3qEUDObriJ0jwK7l2HjMEaPDeubINYQLaG4J/XlRfqn Tp+Ljds3gCfJChRjgwM4tfm3gUK0IYTt1+p94UQMvdLs+MExNGPSwsEGRdfCJ+wXWoup Ey2Ge3cxD543letYrph4m8tJctANPr+ETBqNoYsVk5Cqg7iwTPsk6Re4slPvTzsgcg1q e7rEG3Ip3U0FtvFzSaKlhtpalWvh76ErzzBoCwMkPbFguTwk/5qLofZksRstWdCAybsa qRnvYAjIG14wQ6hlm+htdMZC3erDWXg3GGLdX7Q2nmbklVNNk4K84rq24fpB+QJr+zye tA8Q== X-Gm-Message-State: AOAM533EqgqstvDUL575sFy3jflLyYkbq0lqnUk9rqdDF70fZLOo5/0l w7QTOC1/PJuWIj103ao+nkIKRKPaDls= X-Google-Smtp-Source: ABdhPJyUpfpT9l7B1MvSK8xJp6dacca2BXQKTrAQ4Wc72VOm5cQExzdGg3Ltp/re4zTYpjuCHoMJaA== X-Received: by 2002:adf:feca:: with SMTP id q10mr3990520wrs.380.1591707191199; Tue, 09 Jun 2020 05:53:11 -0700 (PDT) Received: from dell ([2.27.167.101]) by smtp.gmail.com with ESMTPSA id x205sm2925431wmx.21.2020.06.09.05.53.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 05:53:10 -0700 (PDT) Date: Tue, 9 Jun 2020 13:53:05 +0100 From: Lee Jones To: Gene Chen Subject: Re: [PATCH] mfd: mt6360: Fix register driver NULL pointer by add driver name Message-ID: <20200609125305.GL4106@dell> References: <1591609125-3761-1-git-send-email-gene.chen.richtek@gmail.com> <20200608192829.GG4106@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200609_055312_597519_F1F6F343 X-CRM114-Status: GOOD ( 16.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gene Chen , linux-kernel@vger.kernel.org, cy_huang@richtek.com, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, Wilma.Wu@mediatek.com, linux-arm-kernel@lists.infradead.org, shufan_lee@richtek.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAwOSBKdW4gMjAyMCwgR2VuZSBDaGVuIHdyb3RlOgoKPiBMZWUgSm9uZXMgPGxlZS5q b25lc0BsaW5hcm8ub3JnPiDmlrwgMjAyMOW5tDbmnIg55pelIOmAseS6jCDkuIrljYgzOjI45a+r 6YGT77yaCj4gPgo+ID4gT24gTW9uLCAwOCBKdW4gMjAyMCwgR2VuZSBDaGVuIHdyb3RlOgo+ID4K PiA+ID4gRnJvbTogR2VuZSBDaGVuIDxnZW5lX2NoZW5AcmljaHRlay5jb20+Cj4gPiA+Cj4gPiA+ IGFjY2lkZW50YWxseSByZW1vdmUgZHJpdmVyIG5hbWUgd2hlbgo+ID4gPiByZXBsYWNlIHByb2Jl IGJ5IHByb2JlX25ldyBpbiBhZGQgbXQ2MzYwIG1mZCBkcml2ZXIgcGF0Y2ggdjQKPiA+ID4KPiA+ ID4gWyAgMTIxLjI0MzAxMl0gRUFYOiBjMmE4YmM2NCBFQlg6IDAwMDAwMDAwIEVDWDogMDAwMDAw MDAgRURYOiAwMDAwMDAwMAo+ID4gPiBbICAxMjEuMjQzMDEyXSBFU0k6IGMyYThiYzc5IEVESTog MDAwMDAwMDAgRUJQOiBlNTRiZGVhOCBFU1A6IGU1NGJkZWEwCj4gPiA+IFsgIDEyMS4yNDMwMTJd IERTOiAwMDdiIEVTOiAwMDdiIEZTOiAwMDAwIEdTOiAwMDAwIFNTOiAwMDY4IEVGTEFHUzogMDAw MTAyODYKPiA+ID4gWyAgMTIxLjI0MzAxMl0gQ1IwOiA4MDA1MDAzMyBDUjI6IDAwMDAwMDAwIENS MzogMDJlYzMwMDAgQ1I0OiAwMDAwMDZiMAo+ID4gPiBbICAxMjEuMjQzMDEyXSBDYWxsIFRyYWNl Ogo+ID4gPiBbICAxMjEuMjQzMDEyXSAga3NldF9maW5kX29iaisweDNkLzB4YzAKPiA+ID4gWyAg MTIxLjI0MzAxMl0gIGRyaXZlcl9maW5kKzB4MTYvMHg0MAo+ID4gPiBbICAxMjEuMjQzMDEyXSAg ZHJpdmVyX3JlZ2lzdGVyKzB4NDkvMHgxMDAKPiA+ID4gWyAgMTIxLjI0MzAxMl0gID8gaTJjX2Zv cl9lYWNoX2RldisweDM5LzB4NTAKPiA+ID4gWyAgMTIxLjI0MzAxMl0gID8gX19wcm9jZXNzX25l d19hZGFwdGVyKzB4MjAvMHgyMAo+ID4gPiBbICAxMjEuMjQzMDEyXSAgPyBjaHRfd2NfZHJpdmVy X2luaXQrMHgxMS8weDExCj4gPiA+IFsgIDEyMS4yNDMwMTJdICBpMmNfcmVnaXN0ZXJfZHJpdmVy KzB4MzAvMHg4MAo+ID4gPiBbICAxMjEuMjQzMDEyXSAgPyBpbnRlbF9scHNzX3BjaV9kcml2ZXJf aW5pdCsweDE2LzB4MTYKPiA+ID4gWyAgMTIxLjI0MzAxMl0gIG10NjM2MF9wbXVfZHJpdmVyX2lu aXQrMHhmLzB4MTEKPiA+ID4gWyAgMTIxLjI0MzAxMl0gIGRvX29uZV9pbml0Y2FsbCsweDMzLzB4 MWEwCj4gPiA+IFsgIDEyMS4yNDMwMTJdICA/IHBhcnNlX2FyZ3MrMHgxZWIvMHgzZDAKPiA+ID4g WyAgMTIxLjI0MzAxMl0gID8gX19taWdodF9zbGVlcCsweDMxLzB4OTAKPiA+ID4gWyAgMTIxLjI0 MzAxMl0gID8ga2VybmVsX2luaXRfZnJlZWFibGUrMHgxMGEvMHgxN2YKPiA+ID4gWyAgMTIxLjI0 MzAxMl0gIGtlcm5lbF9pbml0X2ZyZWVhYmxlKzB4MTJjLzB4MTdmCj4gPiA+IFsgIDEyMS4yNDMw MTJdICA/IHJlc3RfaW5pdCsweDExMC8weDExMAo+ID4gPiBbICAxMjEuMjQzMDEyXSAga2VybmVs X2luaXQrMHhiLzB4MTAwCj4gPiA+IFsgIDEyMS4yNDMwMTJdICA/IHNjaGVkdWxlX3RhaWxfd3Jh cHBlcisweDkvMHhjCj4gPiA+IFsgIDEyMS4yNDMwMTJdICByZXRfZnJvbV9mb3JrKzB4MTkvMHgy NAo+ID4gPiBbICAxMjEuMjQzMDEyXSBNb2R1bGVzIGxpbmtlZCBpbjoKPiA+ID4gWyAgMTIxLjI0 MzAxMl0gQ1IyOiAwMDAwMDAwMDAwMDAwMDAwCj4gPiA+IFsgIDEyMS4yNDMwMTJdIHJhbmRvbTog Z2V0X3JhbmRvbV9ieXRlcyBjYWxsZWQgZnJvbSBpbml0X29vcHNfaWQrMHgzYS8weDQwIHdpdGgg Y3JuZ19pbml0PTAKPiA+ID4gWyAgMTIxLjI0MzAxMl0gLS0tWyBlbmQgdHJhY2UgMzhhODAzNDAw ZjFhMmJlZSBdLS0tCj4gPiA+IFsgIDEyMS4yNDMwMTJdIEVJUDogc3RyY21wKzB4MTEvMHgzMAo+ ID4KPiA+IEhvdyBkaWQgdGhpcyBkcml2ZXIgZXZlciB3b3JrIGZvciB5b3U/Cj4gCj4gaSBhc2sg bXkgY293b3JrZXIgaGVscCBtZSB2ZXJpZnkuCj4gaSB3aWxsIGNoZWNrIHRoZSBwYXRjaCBteXNl bGYsIHNpbmNlcmVseSBhcG9sb2dpZXMgZm9yIHRoaXMuCgpXaGF0IGRvZXMgdGhpcyBtZWFuPwoK QXJlIHlvdSBzYXlpbmcgdGhhdCBmb3IgYWxsIDEwIHZlcnNpb25zIG9mIHRoaXMgcGF0Y2ggc3Vi bWlzc2lvbiwgaXQKaGFzIG5ldmVyIGJlZW4gdGVzdGVkPyAgQW5kIGRlc3BpdGUgYmVpbmcgYXV0 aG9yZWQgYnkgeW91IGFuZApzdWJtaXR0ZWQgYnkgeW91LCB5b3UgaGF2ZSBuZXZlciBhY3R1YWxs eSBib290IHRlc3RlZCB0aGUgZHJpdmVyCnlvdXJzZWxmPyAgUmVseWluZyBpbnN0ZWFkIG9uIHlv dXIgY28td29ya2VyIHRvIGNvbmR1Y3QgdGhlIHRlc3RpbmcsCndobyBmYWlsZWQgdG8gZG8gc28u ICBJcyB0aGF0IHJlYWxseSBjb3JyZWN0PwoKPiA+ID4gU2lnbmVkLW9mZi1ieTogR2VuZSBDaGVu IDxnZW5lX2NoZW5AcmljaHRlay5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9tZmQvbXQ2 MzYwLWNvcmUuYyB8IDEgKwo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCj4g PiA+Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9tdDYzNjAtY29yZS5jIGIvZHJpdmVy cy9tZmQvbXQ2MzYwLWNvcmUuYwo+ID4gPiBpbmRleCBkYjhjZGY1Li5lOWNhY2MyIDEwMDY0NAo+ ID4gPiAtLS0gYS9kcml2ZXJzL21mZC9tdDYzNjAtY29yZS5jCj4gPiA+ICsrKyBiL2RyaXZlcnMv bWZkL210NjM2MC1jb3JlLmMKPiA+ID4gQEAgLTQxMiw2ICs0MTIsNyBAQCBNT0RVTEVfREVWSUNF X1RBQkxFKG9mLCBtdDYzNjBfcG11X29mX2lkKTsKPiA+ID4KPiA+ID4gIHN0YXRpYyBzdHJ1Y3Qg aTJjX2RyaXZlciBtdDYzNjBfcG11X2RyaXZlciA9IHsKPiA+ID4gICAgICAgLmRyaXZlciA9IHsK PiA+ID4gKyAgICAgICAgICAgICAubmFtZSA9ICJtdDYzNjBfcG11IiwKPiA+ID4gICAgICAgICAg ICAgICAucG0gPSAmbXQ2MzYwX3BtdV9wbV9vcHMsCj4gPiA+ICAgICAgICAgICAgICAgLm9mX21h dGNoX3RhYmxlID0gb2ZfbWF0Y2hfcHRyKG10NjM2MF9wbXVfb2ZfaWQpLAo+ID4gPiAgICAgICB9 LAo+ID4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KU2VuaW9yIFRlY2huaWNhbCBMZWFkIC0g RGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZv ciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA8EEC433E0 for ; Tue, 9 Jun 2020 12:53:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86F3F206A4 for ; Tue, 9 Jun 2020 12:53:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sRudMVlH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728055AbgFIMxQ (ORCPT ); Tue, 9 Jun 2020 08:53:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726083AbgFIMxO (ORCPT ); Tue, 9 Jun 2020 08:53:14 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F5F7C05BD1E for ; Tue, 9 Jun 2020 05:53:12 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id p5so21154686wrw.9 for ; Tue, 09 Jun 2020 05:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=vrPhBQinJOm2GiOyvxlhSLQ8G2hbgcP888EbPjYnpWE=; b=sRudMVlHtnJjHmIBx59yGnZa7TgnSFmEgOv0HeaNM3Yw6g193AyJONzpDj2K1k4nbZ 3xTl+eARUVcQU6Tt4E8p8c0kSvnhRU6CK94wKp+O1zKCK+BeFLfrkSnDGF3JEPThV4Kd sc07ajaQZQWU4bdYabuqev/2HW/xax9AGAylbGoOfdNWNMt9JNAxjWGIYUtRdbqIhMip Gds5DE0qh1mqcJn4jEGBTyTRPUXERdeb5nY1+Ia72Gg4h/xKlmGIbxdvsgvQNiE0lLDm 86jNWlJqpc7q8mwufN9tb6/TTTnBM3wyRs/wn4wAaI7ZPy32ylNLyC2fvzh8u254T5eN IetQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=vrPhBQinJOm2GiOyvxlhSLQ8G2hbgcP888EbPjYnpWE=; b=sxBi9lE9npydDVVMjsb7gvcajh15M095iSNk2IK4fvLhfiX1CpL+zUuDLg2Xnz426U O0BzB1pGZqHq+b7L7WryXLnCAvzqoxZGDN1TcDANwBSoEVXCgjaYSZ9u+5uUqQ0XU3lM EsrbbLwe9oouJDHELe2n7NnIy+rsdS86kBeQGN2hUUqg1zVxwkLph0ijn59KBV5kRPtU tHCUQ3N2nvmAe6A5uqJxdzVNbgMAJyc7jR3iAW47XxlI9JWhInNmJ8NJ6OkLvJWAYWX8 lfA8REQlI/y9iE2TVXaUUxWuXKGYCYVw+r+BwTY8rGyttDS58OPUxnLGRxA0rAUZ/oso yVDQ== X-Gm-Message-State: AOAM532G2J5asiYZDfssxyrm+vueDBlAQPG/ss9bxcyHxUo+SH3JldoW KELMG5wgzSucArMjJRPvEA57tw== X-Google-Smtp-Source: ABdhPJyUpfpT9l7B1MvSK8xJp6dacca2BXQKTrAQ4Wc72VOm5cQExzdGg3Ltp/re4zTYpjuCHoMJaA== X-Received: by 2002:adf:feca:: with SMTP id q10mr3990520wrs.380.1591707191199; Tue, 09 Jun 2020 05:53:11 -0700 (PDT) Received: from dell ([2.27.167.101]) by smtp.gmail.com with ESMTPSA id x205sm2925431wmx.21.2020.06.09.05.53.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 05:53:10 -0700 (PDT) Date: Tue, 9 Jun 2020 13:53:05 +0100 From: Lee Jones To: Gene Chen Cc: matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Gene Chen , Wilma.Wu@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com Subject: Re: [PATCH] mfd: mt6360: Fix register driver NULL pointer by add driver name Message-ID: <20200609125305.GL4106@dell> References: <1591609125-3761-1-git-send-email-gene.chen.richtek@gmail.com> <20200608192829.GG4106@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 09 Jun 2020, Gene Chen wrote: > Lee Jones 於 2020年6月9日 週二 上午3:28寫道： > > > > On Mon, 08 Jun 2020, Gene Chen wrote: > > > > > From: Gene Chen > > > > > > accidentally remove driver name when > > > replace probe by probe_new in add mt6360 mfd driver patch v4 > > > > > > [ 121.243012] EAX: c2a8bc64 EBX: 00000000 ECX: 00000000 EDX: 00000000 > > > [ 121.243012] ESI: c2a8bc79 EDI: 00000000 EBP: e54bdea8 ESP: e54bdea0 > > > [ 121.243012] DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068 EFLAGS: 00010286 > > > [ 121.243012] CR0: 80050033 CR2: 00000000 CR3: 02ec3000 CR4: 000006b0 > > > [ 121.243012] Call Trace: > > > [ 121.243012] kset_find_obj+0x3d/0xc0 > > > [ 121.243012] driver_find+0x16/0x40 > > > [ 121.243012] driver_register+0x49/0x100 > > > [ 121.243012] ? i2c_for_each_dev+0x39/0x50 > > > [ 121.243012] ? __process_new_adapter+0x20/0x20 > > > [ 121.243012] ? cht_wc_driver_init+0x11/0x11 > > > [ 121.243012] i2c_register_driver+0x30/0x80 > > > [ 121.243012] ? intel_lpss_pci_driver_init+0x16/0x16 > > > [ 121.243012] mt6360_pmu_driver_init+0xf/0x11 > > > [ 121.243012] do_one_initcall+0x33/0x1a0 > > > [ 121.243012] ? parse_args+0x1eb/0x3d0 > > > [ 121.243012] ? __might_sleep+0x31/0x90 > > > [ 121.243012] ? kernel_init_freeable+0x10a/0x17f > > > [ 121.243012] kernel_init_freeable+0x12c/0x17f > > > [ 121.243012] ? rest_init+0x110/0x110 > > > [ 121.243012] kernel_init+0xb/0x100 > > > [ 121.243012] ? schedule_tail_wrapper+0x9/0xc > > > [ 121.243012] ret_from_fork+0x19/0x24 > > > [ 121.243012] Modules linked in: > > > [ 121.243012] CR2: 0000000000000000 > > > [ 121.243012] random: get_random_bytes called from init_oops_id+0x3a/0x40 with crng_init=0 > > > [ 121.243012] ---[ end trace 38a803400f1a2bee ]--- > > > [ 121.243012] EIP: strcmp+0x11/0x30 > > > > How did this driver ever work for you? > > i ask my coworker help me verify. > i will check the patch myself, sincerely apologies for this. What does this mean? Are you saying that for all 10 versions of this patch submission, it has never been tested? And despite being authored by you and submitted by you, you have never actually boot tested the driver yourself? Relying instead on your co-worker to conduct the testing, who failed to do so. Is that really correct? > > > Signed-off-by: Gene Chen > > > --- > > > drivers/mfd/mt6360-core.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c > > > index db8cdf5..e9cacc2 100644 > > > --- a/drivers/mfd/mt6360-core.c > > > +++ b/drivers/mfd/mt6360-core.c > > > @@ -412,6 +412,7 @@ MODULE_DEVICE_TABLE(of, mt6360_pmu_of_id); > > > > > > static struct i2c_driver mt6360_pmu_driver = { > > > .driver = { > > > + .name = "mt6360_pmu", > > > .pm = &mt6360_pmu_pm_ops, > > > .of_match_table = of_match_ptr(mt6360_pmu_of_id), > > > }, > > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog