From: Christoph Hellwig <hch@lst.de>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: sagi@grimberg.me, chaitanya.kulkarni@wdc.com,
israelr@mellanox.com, james.smart@broadcom.com,
linux-nvme@lists.infradead.org, oren@mellanox.com,
kbusch@kernel.org, nitzanc@mellanox.com, hch@lst.de
Subject: Re: [PATCH 1/5] nvme: introduce nvme-types header file
Date: Tue, 9 Jun 2020 15:57:24 +0200 [thread overview]
Message-ID: <20200609135724.GC10669@lst.de> (raw)
In-Reply-To: <20200602131546.51903-2-maxg@mellanox.com>
On Tue, Jun 02, 2020 at 04:15:42PM +0300, Max Gurtovoy wrote:
> Centralize the mapping between name and type to a common header file
> instead of duplicating logic in both NVMe host and target drivers.
The idea looks ok to me, but nvme_types suggested a header ala
<sys/types.h> or <linux/types.h> to me. Not sure what a good name
would be, though. I also suspect that keeping it under drivers/nvme/
in some fork might make more sense.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-06-09 13:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 13:15 [PATCH 0/5] NVMe cleanups for 5.8 Max Gurtovoy
2020-06-02 13:15 ` [PATCH 1/5] nvme: introduce nvme-types header file Max Gurtovoy
2020-06-02 14:40 ` Himanshu Madhani
2020-06-03 21:18 ` Sagi Grimberg
2020-06-04 9:39 ` Max Gurtovoy
2020-06-05 8:00 ` Sagi Grimberg
2020-06-05 23:00 ` Max Gurtovoy
2020-06-09 13:57 ` Christoph Hellwig [this message]
2020-06-10 0:07 ` Max Gurtovoy
2020-06-02 13:15 ` [PATCH 2/5] nvme: use nvme_ana_type_to_name to get state string Max Gurtovoy
2020-06-02 14:44 ` Himanshu Madhani
2020-06-02 13:15 ` [PATCH 3/5] nvme: replace transport name with trtype enum for ops Max Gurtovoy
2020-06-02 14:46 ` Himanshu Madhani
2020-06-05 16:49 ` Sagi Grimberg
2020-06-07 8:36 ` Max Gurtovoy
2020-06-08 4:40 ` Sagi Grimberg
2020-06-02 13:15 ` [PATCH 4/5] nvmet-tcp: remove has_keyed_sgls initialization Max Gurtovoy
2020-06-02 15:03 ` Himanshu Madhani
2020-06-02 13:15 ` [PATCH 5/5] nvmet: introduce flags member in nvmet_fabrics_ops Max Gurtovoy
2020-06-02 15:03 ` Himanshu Madhani
2020-06-03 13:08 ` [PATCH 0/5] NVMe cleanups for 5.8 Christoph Hellwig
2020-06-03 13:32 ` Max Gurtovoy
2020-06-09 13:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609135724.GC10669@lst.de \
--to=hch@lst.de \
--cc=chaitanya.kulkarni@wdc.com \
--cc=israelr@mellanox.com \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=nitzanc@mellanox.com \
--cc=oren@mellanox.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.