Re: [PATCH 1/1] selftests: fpga: dfl: A test for afu interrupt support

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Jun 09, 2020 at 06:02:08AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Check that the ioctl DFL_FPGA_PORT_ERR_GET_IRQ_NUM returns
> an expected result.
> 
> Tested on vf device 0xbcc1
> 
> Sample run with
> $ sudo make -C tools/testing/selftests TARGETS=drivers/fpga run_tests
> ...
> ok 1 selftests: drivers/fpga: afu_intr
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  tools/testing/selftests/Makefile              |  1 +
>  tools/testing/selftests/drivers/fpga/Makefile |  9 +++++
>  .../testing/selftests/drivers/fpga/afu_intr.c | 38 +++++++++++++++++++
>  tools/testing/selftests/drivers/fpga/config   |  1 +
>  4 files changed, 49 insertions(+)
>  create mode 100644 tools/testing/selftests/drivers/fpga/Makefile
>  create mode 100644 tools/testing/selftests/drivers/fpga/afu_intr.c
>  create mode 100644 tools/testing/selftests/drivers/fpga/config
> 
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 1195bd85af38..4c6eda659125 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -9,6 +9,7 @@ TARGETS += clone3
>  TARGETS += cpufreq
>  TARGETS += cpu-hotplug
>  TARGETS += drivers/dma-buf
> +TARGETS += drivers/fpga
>  TARGETS += efivarfs
>  TARGETS += exec
>  TARGETS += filesystems
> diff --git a/tools/testing/selftests/drivers/fpga/Makefile b/tools/testing/selftests/drivers/fpga/Makefile
> new file mode 100644
> index 000000000000..0a472e8c67c5
> --- /dev/null
> +++ b/tools/testing/selftests/drivers/fpga/Makefile
> @@ -0,0 +1,9 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +CFLAGS += -I../../../../../usr/include/
> +CFLAGS += -I../../../../../include/uapi/
> +
> +TEST_GEN_PROGS := afu_intr
> +
> +top_srcdir ?=../../../../..
> +
> +include ../../lib.mk
> diff --git a/tools/testing/selftests/drivers/fpga/afu_intr.c b/tools/testing/selftests/drivers/fpga/afu_intr.c
> new file mode 100644
> index 000000000000..aa1efba94605
> --- /dev/null
> +++ b/tools/testing/selftests/drivers/fpga/afu_intr.c
> @@ -0,0 +1,38 @@
> +// SPDX-License-Identifier: GPL-2.0
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <stdint.h>
> +#include <string.h>
> +#include <linux/fcntl.h>
> +#include <linux/fpga-dfl.h>
> +
> +#define TEST_PREFIX	"drivers/fpga/afu_intr"
> +
> +int main(int argc, char *argv[])
> +{
> +	int devfd, status;
> +	struct dfl_fpga_port_info port_info;
> +	uint32_t irq_num;
> +
> +	devfd = open("/dev/dfl-port.0", O_RDONLY);
> +	if (devfd < 0) {
> +		printf("%s: [skip,no-ufpgaintr]\n", TEST_PREFIX);
> +		exit(77);
> +	}
> +
> +	/*
> +	 * From fpga-dl.h :
> +	 * Currently hardware supports up to 1 irq.
> +	 * Return: 0 on success, -errno on failure.
> +	 */
> +	irq_num = -1;
> +	status = ioctl(devfd, DFL_FPGA_PORT_ERR_GET_IRQ_NUM, &irq_num);
> +	if (status != 0 || irq_num > 255) {
> +		printf("%s: [FAIL,err-get-irq-num]\n", TEST_PREFIX);
> +		close(devfd);
> +		exit(1);
> +	}
> +
> +	close(devfd);
> +	return 0;
> +}

Why not use the ksft_* functions and frameworks to properly print out
the test status and results so that tools can correctly parse it?

It's generally bad-form to make up your own format.

thanks,

gre gk-h