From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
paul@xen.org
Subject: [PATCH for-4.14 2/2] tools: fix setting of errno in xenhypfs_read_raw()
Date: Tue, 9 Jun 2020 16:48:50 +0200 [thread overview]
Message-ID: <20200609144850.28619-3-jgross@suse.com> (raw)
In-Reply-To: <20200609144850.28619-1-jgross@suse.com>
Setting of errno is wrong in xenhypfs_read_raw(), fix it.
Reported-by: George Dunlap <george.dunlap@citrix.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
tools/libs/hypfs/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/libs/hypfs/core.c b/tools/libs/hypfs/core.c
index fc23b02586..f94c5ea1e2 100644
--- a/tools/libs/hypfs/core.c
+++ b/tools/libs/hypfs/core.c
@@ -241,10 +241,8 @@ void *xenhypfs_read_raw(xenhypfs_handle *fshdl, const char *path,
if (!ret)
break;
- if (ret != ENOBUFS) {
- errno = -ret;
+ if (errno != ENOBUFS)
goto out;
- }
}
content = malloc(entry->content_len);
--
2.26.2
next prev parent reply other threads:[~2020-06-09 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 14:48 [PATCH for-4.14 0/2] tools: two minor fixes for libxenhypfs Juergen Gross
2020-06-09 14:48 ` [PATCH for-4.14 1/2] tools: fix error path of xenhypfs_open() Juergen Gross
2020-06-09 14:56 ` Paul Durrant
2020-06-09 14:48 ` Juergen Gross [this message]
2020-06-09 15:02 ` [PATCH for-4.14 2/2] tools: fix setting of errno in xenhypfs_read_raw() Paul Durrant
2020-06-09 15:38 ` [PATCH for-4.14 0/2] tools: two minor fixes for libxenhypfs Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609144850.28619-3-jgross@suse.com \
--to=jgross@suse.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=paul@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.