From: refactormyself@gmail.com
To: helgaas@kernel.org
Cc: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>,
bjorn@helgaas.com, linux-pci@vger.kernel.org,
skhan@linuxfoundation.org
Subject: [PATCH 6/8] PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes
Date: Tue, 9 Jun 2020 17:39:48 +0200 [thread overview]
Message-ID: <20200609153950.8346-7-refactormyself@gmail.com> (raw)
In-Reply-To: <20200609153950.8346-1-refactormyself@gmail.com>
From: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
pci_enable_pcie_error_reporting() return PCIBIOS_ error codes which were
passed on down the call heirarchy pcie capability accessors.
PCIBIOS_ error codes have positive values. Passing on these values is
inconsistent with functions which return only a negative value on failure.
Before passing on return value of pcie capability accessors, call
pcibios_err_to_errno() to convert any positive PCIBIOS_ error codes to
negative non-PCI generic error values.
Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
Suggested-by: Bjorn Helgaas <bjorn@helgaas.com>
---
drivers/pci/pcie/aer.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index f4274d301235..95d480a52078 100644
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -349,13 +349,17 @@ bool aer_acpi_firmware_first(void)
int pci_enable_pcie_error_reporting(struct pci_dev *dev)
{
+ int rc;
+
if (pcie_aer_get_firmware_first(dev))
return -EIO;
if (!dev->aer_cap)
return -EIO;
- return pcie_capability_set_word(dev, PCI_EXP_DEVCTL, PCI_EXP_AER_FLAGS);
+ rc = pcie_capability_set_word(dev, PCI_EXP_DEVCTL, PCI_EXP_AER_FLAGS);
+
+ return rc;
}
EXPORT_SYMBOL_GPL(pci_enable_pcie_error_reporting);
--
2.18.2
next prev parent reply other threads:[~2020-06-09 16:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 15:39 [PATCH 0/8] PCI: Align return value of pcie capability accessors with other accessors refactormyself
2020-06-09 15:39 ` [PATCH 1/8] PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes refactormyself
2020-06-09 15:39 ` [PATCH 2/8] " refactormyself
2020-06-09 15:39 ` [PATCH 3/8] " refactormyself
2020-06-11 22:24 ` Bjorn Helgaas
2020-06-09 15:39 ` [PATCH 4/8] " refactormyself
2020-06-09 15:39 ` [PATCH 5/8] " refactormyself
2020-06-09 15:39 ` refactormyself [this message]
2020-06-11 22:26 ` [PATCH 6/8] " Bjorn Helgaas
2020-06-09 15:39 ` [PATCH 7/8] " refactormyself
2020-06-11 22:27 ` Bjorn Helgaas
2020-06-09 15:39 ` [PATCH 8/8] PCI: Align return value of pcie capability accessors with other accessors refactormyself
2020-06-11 22:28 ` Bjorn Helgaas
2020-06-11 22:16 ` [PATCH 0/8] " Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609153950.8346-7-refactormyself@gmail.com \
--to=refactormyself@gmail.com \
--cc=bjorn@helgaas.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.