From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76949C433DF for ; Tue, 9 Jun 2020 14:02:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4756E20737 for ; Tue, 9 Jun 2020 14:02:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZVXn+un5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4756E20737 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QwiMr+cAE6xZa6NzpePzShEcSfQpXLCWCqtsv33HSvw=; b=ZVXn+un5FU2zJa q26nZAkpBgD9OtbgfUtkiMKfvCqWaN1yrV4eVVpUW2dHMsQtegpOXhksY+uzaoi4HCfKuRPmOre+7 IsxwEVad32CVrSX0l6rYv7HDixstpYfJ5JVvKkQF8KWyWDNa1jgsjVrtuP769wBElNQOYQ6j1Q/N2 BEsmaXHCmxjPmqatV2KmalMLUTQpFCfFEiNj7uqfOgS2xy9Vy1ngWhMYz0LthP4jplDBwbR6wegC0 C8nwbsn/PETiI0MEIw4sMsH+p4newYnE9fMhS/ZDFgkKHggdbjhDXxFXyEBDrX/RLe61um3U9nR+Q gkLF94rVNvtLak3EJYtw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiepj-0006Ag-AY; Tue, 09 Jun 2020 14:02:31 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiepg-00069m-5a for linux-mtd@lists.infradead.org; Tue, 09 Jun 2020 14:02:30 +0000 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id E1290240020; Tue, 9 Jun 2020 14:02:18 +0000 (UTC) Date: Tue, 9 Jun 2020 16:02:17 +0200 From: Miquel Raynal To: Sivaprakash Murugesan Subject: Re: [PATCH V2 1/2] mtd: rawnand: qcom: remove write to unavailable register Message-ID: <20200609160217.0b111883@xps13> In-Reply-To: <1591701056-3944-2-git-send-email-sivaprak@codeaurora.org> References: <1591701056-3944-1-git-send-email-sivaprak@codeaurora.org> <1591701056-3944-2-git-send-email-sivaprak@codeaurora.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200609_070228_349551_33FAB407 X-CRM114-Status: GOOD ( 13.60 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.ujfalusi@ti.com, richard@nod.at, linux-mtd@lists.infradead.org, vigneshr@ti.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgU2l2YXByYWthc2gsCgpTaXZhcHJha2FzaCBNdXJ1Z2VzYW4gPHNpdmFwcmFrQGNvZGVhdXJv cmEub3JnPiB3cm90ZSBvbiBUdWUsICA5IEp1bgoyMDIwIDE2OjQwOjU1ICswNTMwOgoKPiBTRkxB U0hDX0JVUlNUX0NGRyByZWdpc3RlciBpcyBub3QgYXZhaWxhYmxlIG9uIGFsbCBpcHEgbmFuZCBw bGF0Zm9ybXMsCj4gaXQgaXMgYXZhaWxhYmxlIG9ubHkgb24gaXBxODA2NCBkZXZpY2VzIGFuZCB0 aGUgbmFuZCBjb250cm9sbGVyIHdvcmtzCj4gd2l0aG91dCBjb25maWd1cmluZyB0aGVzZSByZWdp c3RlcnMgaW4gdGhpcyBwbGF0Zm9ybSwgc28gcmVnaXN0ZXIgd3JpdGUKPiB0byB0aGlzIGNhbiBi ZSByZW1vdmVkLgoKTWF5YmUgaXQgd29ya3MgYmVjYXVzZSB0aGUgYm9vdGxvYWRlciBpcyBzZXR0 aW5nIHRoZSByZWdpc3RlciBpdHNlbGYuCldoYXQgaWYgeW91IHVzZSBhIGRpZmZlcmVudCBib290 bG9hZGVyLCBvciB0aGUgc2FtZSBib290bG9hZGVyIHdpdGhvdXQKTkFORCBzdXBwb3J0PwoKSSBk b24ndCB0aGluayB0aGlzIGlzIGEgcHJvcGVyIGZpeCwgeW91IHNob3VsZCBpbnN0ZWFkIGhhdmUg YSBkaWZmZXJlbnQKY29tcGF0aWJsZSBpZiB0aGUgSVAgaXMgbm90IHRoZSBzYW1lIGFuZCBkZXBl bmRpbmcgb24gdGhpcyBjb21wYXRpYmxlCmRvIHRoZSB3cml0ZSwgb3Igbm90LgoKPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBTaXZhcHJha2FzaCBNdXJ1Z2VzYW4gPHNpdmFwcmFrQGNvZGVhdXJvcmEub3Jn Pgo+IC0tLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9xY29tX25hbmRjLmMgfCAyIC0tCj4gIDEg ZmlsZSBjaGFuZ2VkLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210 ZC9uYW5kL3Jhdy9xY29tX25hbmRjLmMgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9xY29tX25hbmRj LmMKPiBpbmRleCA1YjExYzcwLi5lMGFmYTJjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRkL25h bmQvcmF3L3Fjb21fbmFuZGMuYwo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L3Fjb21fbmFu ZGMuYwo+IEBAIC0zNiw3ICszNiw2IEBACj4gICNkZWZpbmUJTkFORF9ERVZfQ01EMQkJCTB4YTQK PiAgI2RlZmluZQlOQU5EX0RFVl9DTUQyCQkJMHhhOAo+ICAjZGVmaW5lCU5BTkRfREVWX0NNRF9W TEQJCTB4YWMKPiAtI2RlZmluZQlTRkxBU0hDX0JVUlNUX0NGRwkJMHhlMAo+ICAjZGVmaW5lCU5B TkRfRVJBU0VEX0NXX0RFVEVDVF9DRkcJMHhlOAo+ICAjZGVmaW5lCU5BTkRfRVJBU0VEX0NXX0RF VEVDVF9TVEFUVVMJMHhlYwo+ICAjZGVmaW5lCU5BTkRfRUJJMl9FQ0NfQlVGX0NGRwkJMHhmMAo+ IEBAIC0yNzc0LDcgKzI3NzMsNiBAQCBzdGF0aWMgaW50IHFjb21fbmFuZGNfc2V0dXAoc3RydWN0 IHFjb21fbmFuZF9jb250cm9sbGVyICpuYW5kYykKPiAgCXUzMiBuYW5kX2N0cmw7Cj4gIAo+ICAJ Lyoga2lsbCBvbmVuYW5kICovCj4gLQluYW5kY193cml0ZShuYW5kYywgU0ZMQVNIQ19CVVJTVF9D RkcsIDApOwo+ICAJbmFuZGNfd3JpdGUobmFuZGMsIGRldl9jbWRfcmVnX2FkZHIobmFuZGMsIE5B TkRfREVWX0NNRF9WTEQpLAo+ICAJCSAgICBOQU5EX0RFVl9DTURfVkxEX1ZBTCk7Cj4gIAoKVGhh bmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD894C433E0 for ; Tue, 9 Jun 2020 14:02:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B089920737 for ; Tue, 9 Jun 2020 14:02:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729560AbgFIOCX convert rfc822-to-8bit (ORCPT ); Tue, 9 Jun 2020 10:02:23 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:32987 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726967AbgFIOCW (ORCPT ); Tue, 9 Jun 2020 10:02:22 -0400 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id E1290240020; Tue, 9 Jun 2020 14:02:18 +0000 (UTC) Date: Tue, 9 Jun 2020 16:02:17 +0200 From: Miquel Raynal To: Sivaprakash Murugesan Cc: richard@nod.at, vigneshr@ti.com, peter.ujfalusi@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 1/2] mtd: rawnand: qcom: remove write to unavailable register Message-ID: <20200609160217.0b111883@xps13> In-Reply-To: <1591701056-3944-2-git-send-email-sivaprak@codeaurora.org> References: <1591701056-3944-1-git-send-email-sivaprak@codeaurora.org> <1591701056-3944-2-git-send-email-sivaprak@codeaurora.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sivaprakash, Sivaprakash Murugesan wrote on Tue, 9 Jun 2020 16:40:55 +0530: > SFLASHC_BURST_CFG register is not available on all ipq nand platforms, > it is available only on ipq8064 devices and the nand controller works > without configuring these registers in this platform, so register write > to this can be removed. Maybe it works because the bootloader is setting the register itself. What if you use a different bootloader, or the same bootloader without NAND support? I don't think this is a proper fix, you should instead have a different compatible if the IP is not the same and depending on this compatible do the write, or not. > > Signed-off-by: Sivaprakash Murugesan > --- > drivers/mtd/nand/raw/qcom_nandc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c > index 5b11c70..e0afa2c 100644 > --- a/drivers/mtd/nand/raw/qcom_nandc.c > +++ b/drivers/mtd/nand/raw/qcom_nandc.c > @@ -36,7 +36,6 @@ > #define NAND_DEV_CMD1 0xa4 > #define NAND_DEV_CMD2 0xa8 > #define NAND_DEV_CMD_VLD 0xac > -#define SFLASHC_BURST_CFG 0xe0 > #define NAND_ERASED_CW_DETECT_CFG 0xe8 > #define NAND_ERASED_CW_DETECT_STATUS 0xec > #define NAND_EBI2_ECC_BUF_CFG 0xf0 > @@ -2774,7 +2773,6 @@ static int qcom_nandc_setup(struct qcom_nand_controller *nandc) > u32 nand_ctrl; > > /* kill onenand */ > - nandc_write(nandc, SFLASHC_BURST_CFG, 0); > nandc_write(nandc, dev_cmd_reg_addr(nandc, NAND_DEV_CMD_VLD), > NAND_DEV_CMD_VLD_VAL); > Thanks, Miquèl