From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24B11C433E0 for ; Wed, 10 Jun 2020 07:37:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05093207ED for ; Wed, 10 Jun 2020 07:37:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05093207ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 49A5B6E4AE; Wed, 10 Jun 2020 07:36:10 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id 52EB86E079 for ; Tue, 9 Jun 2020 16:10:47 +0000 (UTC) Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D19058088; Tue, 9 Jun 2020 16:11:38 +0000 (UTC) Date: Tue, 9 Jun 2020 09:10:44 -0700 From: Tony Lindgren To: Tomi Valkeinen Subject: Re: [PATCH] drm/omap: force runtime PM suspend on system suspend Message-ID: <20200609161044.GS43721@atomide.com> References: <20200609103220.753969-1-tomi.valkeinen@ti.com> <20200609151232.GR43721@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Wed, 10 Jun 2020 07:35:32 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" * Tomi Valkeinen [200609 15:38]: > On 09/06/2020 18:12, Tony Lindgren wrote: > > * Tomi Valkeinen [200609 10:33]: > > > Use suspend_late and resume_early callbacks in DSS submodules to force > > > runtime PM suspend and resume. > > > > > > We use suspend_late callback so that omapdrm's system suspend callback > > > is called first, as that will disable all the display outputs after > > > which it's safe to force DSS into suspend. > > > > I think we can avoid the pm_runtime_force use if we have omapdrm > > implement both .suspend and .suspend_late. In that case suspend would > > only disable the display outputs, then suspend_late would take care > > of switching off the lights and release the last PM runtime count > > after the children are done suspending. > > I'm not sure how that can be done cleanly. omapdrm doesn't really see the > DSS submodules. And even if it does, how can it "release the last PM runtime > count"? With pm_runtime_force_suspend for each? That would be almost the > same as this patch. Well there should not be anything special needed for the children, it should all happen automatically for us. I'm just wondering if this can be all done without the need for all the boilerplate code and adding suspend_late :) > Also, if omapdrm can do the above, it could do it in the .suspend, after > disabling the display outputs. I don't think there's need for suspend_late > then. Yeah so it seems. Can we just diconnect the display outputs in .prepare somewhere? Or is that the wrong place to do it? Regards, Tony _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel