From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D999C433E0 for ; Wed, 10 Jun 2020 07:37:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E50F207ED for ; Wed, 10 Jun 2020 07:37:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E50F207ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B0D0E6E428; Wed, 10 Jun 2020 07:36:08 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id 2428189C99 for ; Tue, 9 Jun 2020 16:37:28 +0000 (UTC) Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id C95E78088; Tue, 9 Jun 2020 16:38:18 +0000 (UTC) Date: Tue, 9 Jun 2020 09:37:24 -0700 From: Tony Lindgren To: Tomi Valkeinen Subject: Re: [PATCH] drm/omap: force runtime PM suspend on system suspend Message-ID: <20200609163724.GT43721@atomide.com> References: <20200609103220.753969-1-tomi.valkeinen@ti.com> <20200609151232.GR43721@atomide.com> <20200609161044.GS43721@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Wed, 10 Jun 2020 07:35:32 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" * Tomi Valkeinen [200609 16:27]: > On 09/06/2020 19:10, Tony Lindgren wrote: > > Yeah so it seems. Can we just diconnect the display outputs > > in .prepare somewhere? Or is that the wrong place to do it? > > Hmm, yes, perhaps... If omapdrm uses .prepare to disable all the outputs. > Then DSS submodules could use UNIVERSAL_DEV_PM_OPS() and have the same > functions for system and runtime suspend. Yeah that would be nice. And maybe the need for force_suspend also disappears with the ordering issues gone :) > Although that has the problem that if the DSS is already runtime suspended > when system suspend happens, the PM does not wake DSS up, and thus the > suspend callbacks will crash if they access registers. So they need some > extra logic there. > > I'll see tomorrow if I can come up with something like that. OK. This $subject patch works for my test cases for suspend and resume based on a brief test with my fixes branch FYI. Regards, Tony _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel