From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: liambeguin@gmail.com
Cc: a.zummo@towertech.it, linux-rtc@vger.kernel.org
Subject: Re: [PATCH 2/3] rtc: pcf2127: add alarm support
Date: Tue, 9 Jun 2020 23:05:49 +0200 [thread overview]
Message-ID: <20200609210549.GU3720@piout.net> (raw)
In-Reply-To: <20200607170610.24534-3-liambeguin@gmail.com>
On 07/06/2020 13:06:09-0400, liambeguin@gmail.com wrote:
> static int pcf2127_nvmem_read(void *priv, unsigned int offset,
> @@ -434,6 +546,8 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap,
>
> pcf2127->rtc->ops = &pcf2127_rtc_ops;
>
> + device_init_wakeup(dev, true);
> +
This can't be done unconditionally, You need to have been able to
request an interrupt or the wakeup-source property needs to be present.
The interrupt handler is also missing from the patch.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-06-09 21:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 17:06 [PATCH 0/3] rtc: pcf2127: add alarm support liambeguin
2020-06-07 17:06 ` [PATCH 1/3] rtc: pcf2127: add pca2129 device id liambeguin
2020-06-09 20:48 ` Bruno Thomsen
2020-06-07 17:06 ` [PATCH 2/3] rtc: pcf2127: add alarm support liambeguin
2020-06-09 20:42 ` Bruno Thomsen
2020-06-10 15:38 ` Liam Beguin
2020-06-09 21:05 ` Alexandre Belloni [this message]
2020-06-10 15:49 ` Liam Beguin
2020-06-10 16:32 ` Alexandre Belloni
2020-06-07 17:06 ` [PATCH 3/3] rtc: pcf2127: reset alarm interrupt at power on liambeguin
2020-06-09 21:07 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609210549.GU3720@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=liambeguin@gmail.com \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.