From: Rob Herring <robh@kernel.org>
To: "Kevin P. Fleming" <kevin+linux@km6g.us>
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH] rtc: abx80x: Add support for autocalibration filter capacitor
Date: Tue, 9 Jun 2020 16:14:01 -0600 [thread overview]
Message-ID: <20200609221401.GA1492918@bogus> (raw)
In-Reply-To: <20200530123222.361104-1-kevin+linux@km6g.us>
On Sat, May 30, 2020 at 08:32:22AM -0400, Kevin P. Fleming wrote:
> All of the parts supported by this driver can make use of a
> small capacitor to improve the accuracy of the autocalibration
> process for their RC oscillators. If a capacitor is connected,
> a configuration register must be set to enable its use, so a
> new Device Tree property has been added for that purpose.
>
> Signed-off-by: Kevin P. Fleming <kevin+linux@km6g.us>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> To: linux-rtc@vger.kernel.org
> To: devicetree@vger.kernel.org
> ---
> .../bindings/rtc/abracon,abx80x.txt | 6 ++++
> drivers/rtc/rtc-abx80x.c | 34 +++++++++++++++++++
> 2 files changed, 40 insertions(+)
Binding should be a separate patch?
>
> diff --git a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
> index 2405e35a1bc0..ad5d59ed6f24 100644
> --- a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
> +++ b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
> @@ -29,3 +29,9 @@ and valid to enable charging:
> - "abracon,tc-diode": should be "standard" (0.6V) or "schottky" (0.3V)
> - "abracon,tc-resistor": should be <0>, <3>, <6> or <11>. 0 disables the output
> resistor, the other values are in kOhm.
> +
> +All of the devices can have a 47pf capacitor attached to increase the
> +autocalibration accuracy of their RC oscillators. To enable usage of the
> +capacitor the following property has to be defined:
> +
> + - "abracon,autocal-filter"
Can't the standard 'quartz-load-femtofarads' property be used here? You
might not need to know the value, but presence of the property can
enable the feature.
Rob
next prev parent reply other threads:[~2020-06-09 22:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 12:32 [PATCH] rtc: abx80x: Add support for autocalibration filter capacitor Kevin P. Fleming
2020-05-30 12:50 ` Kevin P. Fleming
2020-06-09 22:14 ` Rob Herring [this message]
2020-06-09 22:23 ` Kevin P. Fleming
2020-06-10 15:16 ` Alexandre Belloni
2020-06-12 11:48 ` Kevin P. Fleming
2020-06-12 14:23 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609221401.GA1492918@bogus \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=kevin+linux@km6g.us \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.