From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v2 1/2] iommu/amd: Move AMD IOMMU driver into subdirectory
Date: Wed, 10 Jun 2020 01:52:51 +0800 [thread overview]
Message-ID: <202006100152.sbjK4bCB%lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 5124 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20200609130303.26974-2-joro@8bytes.org>
References: <20200609130303.26974-2-joro@8bytes.org>
TO: Joerg Roedel <joro@8bytes.org>
TO: Joerg Roedel <joro@8bytes.org>
CC: David Woodhouse <dwmw2@infradead.org>
CC: Lu Baolu <baolu.lu@linux.intel.com>
CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
CC: Jerry Snitselaar <jsnitsel@redhat.com>
CC: Qian Cai <cai@lca.pw>
CC: iommu(a)lists.linux-foundation.org
CC: linux-kernel(a)vger.kernel.org
Hi Joerg,
I love your patch! Perhaps something to improve:
[auto build test WARNING on iommu/next]
[also build test WARNING on linus/master next-20200609]
[cannot apply to v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Joerg-Roedel/iommu-Move-Intel-and-AMD-drivers-into-their-own-subdirectory/20200609-210928
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago
config: x86_64-randconfig-m001-20200607 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/iommu/amd/iommu.c:733 amd_iommu_int_thread() warn: this loop depends on readl() succeeding
# https://github.com/0day-ci/linux/commit/99df47ff4503fa8f819966f0d3882d979ad83fab
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 99df47ff4503fa8f819966f0d3882d979ad83fab
vim +733 drivers/iommu/amd/iommu.c
bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 722
bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 723 #define AMD_IOMMU_INT_MASK \
bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 724 (MMIO_STATUS_EVT_INT_MASK | \
bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 725 MMIO_STATUS_PPR_INT_MASK | \
bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 726 MMIO_STATUS_GALOG_INT_MASK)
bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 727
72fe00f01f9a32 arch/x86/kernel/amd_iommu.c Joerg Roedel 2011-05-10 728 irqreturn_t amd_iommu_int_thread(int irq, void *data)
a80dc3e0e0dc83 arch/x86/kernel/amd_iommu.c Joerg Roedel 2008-09-11 729 {
3f398bc7762adc drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2013-04-22 730 struct amd_iommu *iommu = (struct amd_iommu *) data;
3f398bc7762adc drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2013-04-22 731 u32 status = readl(iommu->mmio_base + MMIO_STATUS_OFFSET);
90008ee4b811c9 arch/x86/kernel/amd_iommu.c Joerg Roedel 2008-09-09 732
bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 @733 while (status & AMD_IOMMU_INT_MASK) {
bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 734 /* Enable EVT and PPR and GA interrupts again */
bd6fcefc66f6d0 drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2016-08-23 735 writel(AMD_IOMMU_INT_MASK,
3f398bc7762adc drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2013-04-22 736 iommu->mmio_base + MMIO_STATUS_OFFSET);
90008ee4b811c9 arch/x86/kernel/amd_iommu.c Joerg Roedel 2008-09-09 737
3f398bc7762adc drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2013-04-22 738 if (status & MMIO_STATUS_EVT_INT_MASK) {
101fa0371478aa drivers/iommu/amd_iommu.c Joerg Roedel 2018-11-27 739 pr_devel("Processing IOMMU Event Log\n");
90008ee4b811c9 arch/x86/kernel/amd_iommu.c Joerg Roedel 2008-09-09 740 iommu_poll_events(iommu);
3f398bc7762adc drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2013-04-22 741 }
3f398bc7762adc drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2013-04-22 742
3f398bc7762adc drivers/iommu/amd_iommu.c Suravee Suthikulpanit 2013-04-22 743 if (status & MMIO_STATUS_PPR_INT_MASK) {
101fa0371478aa drivers/iommu/amd_iommu.c Joerg Roedel 2018-11-27 744 pr_devel("Processing IOMMU PPR Log\n");
72e1dcc4192288 drivers/iommu/amd_iommu.c Joerg Roedel 2011-11-10 745 iommu_poll_ppr_log(iommu);
72e1dcc4192288 drivers/iommu/amd_iommu.c Joerg Roedel 2011-11-10 746 }
90008ee4b811c9 arch/x86/kernel/amd_iommu.c Joerg Roedel 2008-09-09 747
:::::: The code at line 733 was first introduced by commit
:::::: bd6fcefc66f6d038406e38edf96a95d9842f819d iommu/amd: Adding GALOG interrupt handler
:::::: TO: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
:::::: CC: Joerg Roedel <jroedel@suse.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36700 bytes --]
next reply other threads:[~2020-06-09 17:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 17:52 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-06-09 13:03 [PATCH v2 0/2] iommu: Move Intel and AMD drivers into their own subdirectory Joerg Roedel
2020-06-09 13:03 ` [PATCH v2 1/2] iommu/amd: Move AMD IOMMU driver into subdirectory Joerg Roedel
2020-06-09 13:03 ` Joerg Roedel
2020-06-10 1:25 ` kernel test robot
2020-06-10 1:25 ` kernel test robot
2020-06-10 1:25 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006100152.sbjK4bCB%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.