From: Borislav Petkov <bp@alien8.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
x86-ml <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] x86/microcode: Do not select FW_LOADER
Date: Wed, 10 Jun 2020 12:48:45 +0200 [thread overview]
Message-ID: <20200610104845.GF14118@zn.tnic> (raw)
In-Reply-To: <20200610104113.GA22678@gondor.apana.org.au>
On Wed, Jun 10, 2020 at 08:41:13PM +1000, Herbert Xu wrote:
> Adding two thousand lines of code to the kernel when you only need
> a few lines is ridiculous. Worse those two thousand lines increase
> the attack surface to the kernel because they're exposed to user-
> space.
Why isn't *this* in your commit message?
> Adding a hidden Kconfig symbol for the sake of reducing the kernel
> attack surface would seem worthwhile.
And that.
> In fact this isn't even an issue right now because you are still using
> the custom function.
Actually, I'd prefer your version which doesn't depend on FW_LOADER at
all for the above reasons.
Please resubmit with amended commit message, adding the justification
for the change.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-06-10 10:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 4:29 [PATCH] x86/microcode: Do not select FW_LOADER Herbert Xu
2020-06-10 8:16 ` Borislav Petkov
2020-06-10 10:28 ` Herbert Xu
2020-06-10 10:34 ` Borislav Petkov
2020-06-10 10:41 ` Herbert Xu
2020-06-10 10:48 ` Borislav Petkov [this message]
2020-06-10 11:05 ` [v2 PATCH] " Herbert Xu
2020-06-10 13:12 ` [PATCH] " Luis Chamberlain
2020-06-10 13:46 ` Borislav Petkov
2020-06-10 14:01 ` Luis Chamberlain
2020-06-15 10:03 ` [tip: x86/microcode] " tip-bot2 for Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610104845.GF14118@zn.tnic \
--to=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.