All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Rosbrook <rosbrookn@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: ian.jackson@citrix.com, wl@xen.org
Subject: Unexpected diff after autogen.sh
Date: Wed, 10 Jun 2020 14:37:54 -0400	[thread overview]
Message-ID: <20200610183754.GA3113@six> (raw)

Hello,

When writing a patch to tools/configure.ac, re-running autogen.sh
resulted in a diff with unexpected changes. Specifically, these additions:

    diff --git a/configure b/configure
    index 8af54e8a5a..9da3970cef 100755
    --- a/configure
    +++ b/configure
    @@ -644,6 +644,7 @@ infodir
     docdir
     oldincludedir
     includedir
    +runstatedir
     localstatedir
     sharedstatedir
     sysconfdir
    @@ -722,6 +723,7 @@ datadir='${datarootdir}'
     sysconfdir='${prefix}/etc'
     sharedstatedir='${prefix}/com'
     localstatedir='${prefix}/var'
    +runstatedir='${localstatedir}/run'
     includedir='${prefix}/include'
     oldincludedir='/usr/include'
     docdir='${datarootdir}/doc/${PACKAGE_TARNAME}'
    @@ -974,6 +976,15 @@ do
       | -silent | --silent | --silen | --sile | --sil)
         silent=yes ;;

    +  -runstatedir | --runstatedir | --runstatedi | --runstated \
    +  | --runstate | --runstat | --runsta | --runst | --runs \
    +  | --run | --ru | --r)
    +    ac_prev=runstatedir ;;
    +  -runstatedir=* | --runstatedir=* | --runstatedi=* | --runstated=* \
    +  | --runstate=* | --runstat=* | --runsta=* | --runst=* | --runs=* \
    +  | --run=* | --ru=* | --r=*)
    +    runstatedir=$ac_optarg ;;
    +
       -sbindir | --sbindir | --sbindi | --sbind | --sbin | --sbi | --sb)
         ac_prev=sbindir ;;
       -sbindir=* | --sbindir=* | --sbindi=* | --sbind=* | --sbin=* \

    [...]

...and similar for {docs,tools,stubdom}/configure. These lines were
originally removed in 83c845033d. It seems that the 'runstatedir'
changes in the configure scripts were unintentional and should be added
back.

Thanks,
-NR


                 reply	other threads:[~2020-06-10 18:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200610183754.GA3113@six \
    --to=rosbrookn@gmail.com \
    --cc=ian.jackson@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.