All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	Michal Kubecek <mkubecek@suse.cz>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: ethtool 5.7: netlink ENOENT error when setting WOL
Date: Wed, 10 Jun 2020 22:05:26 +0200	[thread overview]
Message-ID: <20200610200526.GB19869@lunn.ch> (raw)
In-Reply-To: <0353ce74-ffc6-4d40-bf0f-d2a7ad640b30@gmail.com>

> Not sure it makes sense to build ETHTOOL_NETLINK as a module, but at
> least ensuring that ETHTOOL_NETLINK is built into the kernel if PHYLIB=y
> or PHYLIB=m would make sense, or, better we find a way to decouple the
> two by using function pointers from the phy_driver directly that way
> there is no symbol dependency (but reference counting has to work).

Hi Florian

It is not so easy to make PHYLIB=m work. ethtool netlink needs to call
into the phylib core in order to trigger a cable test, not just PHY
drivers.

Ideas welcome.

      Andrew

  reply	other threads:[~2020-06-10 20:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10  8:26 ethtool 5.7: netlink ENOENT error when setting WOL Heiner Kallweit
2020-06-10  8:52 ` Heiner Kallweit
2020-06-10  9:13   ` Michal Kubecek
2020-06-10 10:50     ` Heiner Kallweit
2020-06-10 11:53       ` Michal Kubecek
2020-06-14 22:35         ` Heiner Kallweit
2020-06-14 23:26           ` Michal Kubecek
2020-06-15  6:20             ` Heiner Kallweit
2020-06-10 15:27       ` Florian Fainelli
2020-06-10 20:05         ` Andrew Lunn [this message]
2020-06-14 16:14           ` Heiner Kallweit
2020-06-14 16:44             ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200610200526.GB19869@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.