From: Mark Brown <broonie@kernel.org>
To: Xu Yilun <yilun.xu@intel.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
trix@redhat.com, hao.wu@intel.com,
matthew.gerlach@linux.intel.com, russell.h.weight@intel.com
Subject: Re: [PATCH 6/6] spi: altera: fix size mismatch on 64 bit processors
Date: Thu, 11 Jun 2020 12:04:08 +0100 [thread overview]
Message-ID: <20200611110407.GE4671@sirena.org.uk> (raw)
In-Reply-To: <1591845911-10197-7-git-send-email-yilun.xu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
On Thu, Jun 11, 2020 at 11:25:11AM +0800, Xu Yilun wrote:
> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>
> The spi-altera driver was originally written with a 32
> bit processor, where sizeof(unsigned long) is 4. On a
> 64 bit processor sizeof(unsigned long) is 8. Change the structure
> member to u32 to match the actual size of the control
> register.
>
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> ---
You've not provided a Signed-off-by for this, I can't do anything with
it. For details on what Signed-off-by means and why it's important
please see Documentation/process/submitting-patches.rst.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-11 11:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 3:25 [PATCH 0/6] Add more configuration and regmap support for spi-altera Xu Yilun
2020-06-11 3:25 ` [PATCH 1/6] spi: altera: add 32bit data width transfer support Xu Yilun
2020-06-11 3:25 ` [PATCH 2/6] spi: altera: add SPI core parameters support via platform data Xu Yilun
2020-06-11 3:25 ` [PATCH 3/6] spi: altera: add platform data for slave information Xu Yilun
2020-06-11 3:25 ` [PATCH 4/6] spi: altera: use regmap instead of direct mmio register access Xu Yilun
2020-06-11 11:02 ` Mark Brown
2020-06-12 4:43 ` Xu Yilun
2020-06-12 11:52 ` Mark Brown
2020-06-12 12:31 ` Xu Yilun
2020-06-11 3:25 ` [PATCH 5/6] spi: altera: move driver name string to header file Xu Yilun
2020-06-11 14:03 ` Mark Brown
2020-06-12 3:14 ` Xu Yilun
2020-06-11 3:25 ` [PATCH 6/6] spi: altera: fix size mismatch on 64 bit processors Xu Yilun
2020-06-11 11:04 ` Mark Brown [this message]
2020-06-12 3:39 ` Xu Yilun
2020-06-11 12:56 ` [PATCH 0/6] Add more configuration and regmap support for spi-altera Tom Rix
2020-06-15 23:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611110407.GE4671@sirena.org.uk \
--to=broonie@kernel.org \
--cc=hao.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=russell.h.weight@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.