From: Stephen Hemminger <stephen@networkplumber.org>
To: Roi Dayan <roid@mellanox.com>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH iproute2] ip address: Fix loop initial declarations are only allowed in C99
Date: Thu, 11 Jun 2020 15:05:28 -0700 [thread overview]
Message-ID: <20200611150528.53a6f14c@hermes.lan> (raw)
In-Reply-To: <20200611173543.42371-1-roid@mellanox.com>
On Thu, 11 Jun 2020 20:35:43 +0300
Roi Dayan <roid@mellanox.com> wrote:
> On some distros, i.e. rhel 7.6, compilation fails with the following:
>
> ipaddress.c: In function ‘lookup_flag_data_by_name’:
> ipaddress.c:1260:2: error: ‘for’ loop initial declarations are only allowed in C99 mode
> for (int i = 0; i < ARRAY_SIZE(ifa_flag_data); ++i) {
> ^
> ipaddress.c:1260:2: note: use option -std=c99 or -std=gnu99 to compile your code
>
> This commit fixes the single place needed for compilation to pass.
>
> Fixes: 9d59c86e575b ("iproute2: ip addr: Organize flag properties structurally")
> Signed-off-by: Roi Dayan <roid@mellanox.com>
Agree.
Applied
prev parent reply other threads:[~2020-06-11 22:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 17:35 [PATCH iproute2] ip address: Fix loop initial declarations are only allowed in C99 Roi Dayan
2020-06-11 22:05 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611150528.53a6f14c@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roid@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.