From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
peter.maydell@linaro.org, mst@redhat.com, armbru@redhat.com,
pbonzini@redhat.com, jean-philippe@linaro.org,
bbhushan2@marvell.com, peterx@redhat.com
Subject: [PATCH v3 3/5] virtio-iommu: Handle reserved regions in the translation process
Date: Thu, 11 Jun 2020 17:12:07 +0200 [thread overview]
Message-ID: <20200611151209.22547-4-eric.auger@redhat.com> (raw)
In-Reply-To: <20200611151209.22547-1-eric.auger@redhat.com>
When translating an address we need to check if it belongs to
a reserved virtual address range. If it does, there are 2 cases:
- it belongs to a RESERVED region: the guest should neither use
this address in a MAP not instruct the end-point to DMA on
them. We report an error
- It belongs to an MSI region: we bypass the translation.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
---
v1 -> v2:
- use addr when testing addr belongs to the reserved region
and use a block local variable
---
hw/virtio/virtio-iommu.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c
index be1527c1d6..03535a6a14 100644
--- a/hw/virtio/virtio-iommu.c
+++ b/hw/virtio/virtio-iommu.c
@@ -604,6 +604,7 @@ static IOMMUTLBEntry virtio_iommu_translate(IOMMUMemoryRegion *mr, hwaddr addr,
uint32_t sid, flags;
bool bypass_allowed;
bool found;
+ int i;
interval.low = addr;
interval.high = addr + 1;
@@ -637,6 +638,25 @@ static IOMMUTLBEntry virtio_iommu_translate(IOMMUMemoryRegion *mr, hwaddr addr,
goto unlock;
}
+ for (i = 0; i < s->nb_reserved_regions; i++) {
+ ReservedRegion *reg = &s->reserved_regions[i];
+
+ if (addr >= reg->low && addr <= reg->high) {
+ switch (reg->type) {
+ case VIRTIO_IOMMU_RESV_MEM_T_MSI:
+ entry.perm = flag;
+ break;
+ case VIRTIO_IOMMU_RESV_MEM_T_RESERVED:
+ default:
+ virtio_iommu_report_fault(s, VIRTIO_IOMMU_FAULT_R_MAPPING,
+ VIRTIO_IOMMU_FAULT_F_ADDRESS,
+ sid, addr);
+ break;
+ }
+ goto unlock;
+ }
+ }
+
if (!ep->domain) {
if (!bypass_allowed) {
error_report_once("%s %02x:%02x.%01x not attached to any domain",
--
2.20.1
next prev parent reply other threads:[~2020-06-11 15:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 15:12 [PATCH v3 0/5] VIRTIO-IOMMU probe request support and MSI bypass on ARM Eric Auger
2020-06-11 15:12 ` [PATCH v3 1/5] qdev: Introduce DEFINE_PROP_RESERVED_REGION Eric Auger
2020-06-22 11:22 ` Markus Armbruster
2020-06-23 8:22 ` Auger Eric
2020-06-23 8:57 ` Markus Armbruster
2020-06-23 15:15 ` Markus Armbruster
2020-06-23 15:22 ` Auger Eric
2020-06-11 15:12 ` [PATCH v3 2/5] virtio-iommu: Implement RESV_MEM probe request Eric Auger
2020-06-17 9:16 ` Jean-Philippe Brucker
2020-06-18 9:04 ` Auger Eric
2020-06-11 15:12 ` Eric Auger [this message]
2020-06-17 9:16 ` [PATCH v3 3/5] virtio-iommu: Handle reserved regions in the translation process Jean-Philippe Brucker
2020-06-11 15:12 ` [PATCH v3 4/5] virtio-iommu-pci: Add array of Interval properties Eric Auger
2020-06-11 15:12 ` [PATCH v3 5/5] hw/arm/virt: Let the virtio-iommu bypass MSIs Eric Auger
2020-06-17 9:18 ` Jean-Philippe Brucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611151209.22547-4-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=armbru@redhat.com \
--cc=bbhushan2@marvell.com \
--cc=eric.auger.pro@gmail.com \
--cc=jean-philippe@linaro.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.