From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Thu, 11 Jun 2020 15:46:15 +0000 Subject: Re: [PATCH 18/21] KVM: arm64: Use common KVM implementation of MMU memory caches Message-Id: <20200611154615.GG29918@linux.intel.com> List-Id: References: <20200605213853.14959-1-sean.j.christopherson@intel.com> <20200605213853.14959-19-sean.j.christopherson@intel.com> <3555daf3b38c890e1e74f05d6f49f9be@kernel.org> In-Reply-To: <3555daf3b38c890e1e74f05d6f49f9be@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Marc Zyngier Cc: Paul Mackerras , Christian Borntraeger , Janosch Frank , Paolo Bonzini , James Morse , Julien Thierry , Suzuki K Poulose , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Feiner , Peter Shier , Junaid Shahid , Ben Gardon , Christoffer Dall On Thu, Jun 11, 2020 at 09:01:44AM +0100, Marc Zyngier wrote: > On 2020-06-05 22:38, Sean Christopherson wrote: ... > >@@ -1024,7 +993,7 @@ static pud_t *stage2_get_pud(struct kvm *kvm, > >struct kvm_mmu_memory_cache *cache > > if (stage2_pgd_none(kvm, *pgd)) { > > if (!cache) > > return NULL; > >- pud = mmu_memory_cache_alloc(cache); > >+ pud = kvm_mmu_memory_cache_alloc(cache); > > stage2_pgd_populate(kvm, pgd, pud); > > get_page(virt_to_page(pgd)); > > } > > Quick note: this patch (as it is) breaks on arm64 due to Mike Rapoport's > P4D rework. I've fixed it locally in order to test the series. Good to know, I'll wait to send v2 until that gets pulled into Paolo's tree. Thanks for the heads up, and especially for testing! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C839FC433DF for ; Thu, 11 Jun 2020 15:46:20 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 589C9206C3 for ; Thu, 11 Jun 2020 15:46:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 589C9206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D73A54B192; Thu, 11 Jun 2020 11:46:19 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A01vnnxOx6Pm; Thu, 11 Jun 2020 11:46:18 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E2D1B4B198; Thu, 11 Jun 2020 11:46:18 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 024084B192 for ; Thu, 11 Jun 2020 11:46:18 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JdhxYHNt0MfF for ; Thu, 11 Jun 2020 11:46:17 -0400 (EDT) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id BFE894B17F for ; Thu, 11 Jun 2020 11:46:16 -0400 (EDT) IronPort-SDR: jZSN9fbOd/1CSNvOkmEhMsJOhhJnYFEaxu97pE0bzwP8iKx0Lchfwqig0rFI22kd+T5RFKwIr0 eTZXJ499Qifw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2020 08:46:16 -0700 IronPort-SDR: 3iKlFSNmGLJIQjG6i4tV9DKlsjIjo/kGZ/UFziPeMJdfG9W3E92AKxhhodHCTS+EuQk+hqoqc0 jidNOjbX/9Jw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,499,1583222400"; d="scan'208";a="419145052" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.152]) by orsmga004.jf.intel.com with ESMTP; 11 Jun 2020 08:46:15 -0700 Date: Thu, 11 Jun 2020 08:46:15 -0700 From: Sean Christopherson To: Marc Zyngier Subject: Re: [PATCH 18/21] KVM: arm64: Use common KVM implementation of MMU memory caches Message-ID: <20200611154615.GG29918@linux.intel.com> References: <20200605213853.14959-1-sean.j.christopherson@intel.com> <20200605213853.14959-19-sean.j.christopherson@intel.com> <3555daf3b38c890e1e74f05d6f49f9be@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3555daf3b38c890e1e74f05d6f49f9be@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Cc: Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , linux-kernel@vger.kernel.org, Paul Mackerras , Ben Gardon , Claudio Imbrenda , kvmarm@lists.cs.columbia.edu, Janosch Frank , Joerg Roedel , Christian Borntraeger , Junaid Shahid , kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jim Mattson , Cornelia Huck , Peter Shier , linux-mips@vger.kernel.org, Paolo Bonzini , Vitaly Kuznetsov , Peter Feiner X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Thu, Jun 11, 2020 at 09:01:44AM +0100, Marc Zyngier wrote: > On 2020-06-05 22:38, Sean Christopherson wrote: ... > >@@ -1024,7 +993,7 @@ static pud_t *stage2_get_pud(struct kvm *kvm, > >struct kvm_mmu_memory_cache *cache > > if (stage2_pgd_none(kvm, *pgd)) { > > if (!cache) > > return NULL; > >- pud = mmu_memory_cache_alloc(cache); > >+ pud = kvm_mmu_memory_cache_alloc(cache); > > stage2_pgd_populate(kvm, pgd, pud); > > get_page(virt_to_page(pgd)); > > } > > Quick note: this patch (as it is) breaks on arm64 due to Mike Rapoport's > P4D rework. I've fixed it locally in order to test the series. Good to know, I'll wait to send v2 until that gets pulled into Paolo's tree. Thanks for the heads up, and especially for testing! _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF7CAC433E2 for ; Thu, 11 Jun 2020 15:46:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D01F206C3 for ; Thu, 11 Jun 2020 15:46:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728735AbgFKPqQ (ORCPT ); Thu, 11 Jun 2020 11:46:16 -0400 Received: from mga06.intel.com ([134.134.136.31]:65327 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728641AbgFKPqP (ORCPT ); Thu, 11 Jun 2020 11:46:15 -0400 IronPort-SDR: BEE35dJE/e7S9qJOUK5gq/Ks5JMWMDxyf90+eru9Cqn07jAhbDg79yv/VqSHhN4yj0OqnVyhxf kQO8kCzTLrcA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2020 08:46:15 -0700 IronPort-SDR: 3iKlFSNmGLJIQjG6i4tV9DKlsjIjo/kGZ/UFziPeMJdfG9W3E92AKxhhodHCTS+EuQk+hqoqc0 jidNOjbX/9Jw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,499,1583222400"; d="scan'208";a="419145052" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.152]) by orsmga004.jf.intel.com with ESMTP; 11 Jun 2020 08:46:15 -0700 Date: Thu, 11 Jun 2020 08:46:15 -0700 From: Sean Christopherson To: Marc Zyngier Cc: Paul Mackerras , Christian Borntraeger , Janosch Frank , Paolo Bonzini , James Morse , Julien Thierry , Suzuki K Poulose , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Feiner , Peter Shier , Junaid Shahid , Ben Gardon , Christoffer Dall Subject: Re: [PATCH 18/21] KVM: arm64: Use common KVM implementation of MMU memory caches Message-ID: <20200611154615.GG29918@linux.intel.com> References: <20200605213853.14959-1-sean.j.christopherson@intel.com> <20200605213853.14959-19-sean.j.christopherson@intel.com> <3555daf3b38c890e1e74f05d6f49f9be@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3555daf3b38c890e1e74f05d6f49f9be@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Thu, Jun 11, 2020 at 09:01:44AM +0100, Marc Zyngier wrote: > On 2020-06-05 22:38, Sean Christopherson wrote: ... > >@@ -1024,7 +993,7 @@ static pud_t *stage2_get_pud(struct kvm *kvm, > >struct kvm_mmu_memory_cache *cache > > if (stage2_pgd_none(kvm, *pgd)) { > > if (!cache) > > return NULL; > >- pud = mmu_memory_cache_alloc(cache); > >+ pud = kvm_mmu_memory_cache_alloc(cache); > > stage2_pgd_populate(kvm, pgd, pud); > > get_page(virt_to_page(pgd)); > > } > > Quick note: this patch (as it is) breaks on arm64 due to Mike Rapoport's > P4D rework. I've fixed it locally in order to test the series. Good to know, I'll wait to send v2 until that gets pulled into Paolo's tree. Thanks for the heads up, and especially for testing! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18D85C433E0 for ; Thu, 11 Jun 2020 15:47:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDC9B206C3 for ; Thu, 11 Jun 2020 15:47:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PJGnxlOj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDC9B206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d5qz0JTTJbMQSivqcR0i60qNcRn6m6gTK+hiaDi1EXo=; b=PJGnxlOj0ty9oe 6nLpP1xzwJcevlZrFdrW8PFYCjrC8HIJYKD6L+9Idyr3orr26QNO9XRliwIjDzePJBMeQ8tYzE0wn bVh2eLkYRO256bVau34iHV7xTCdfTo8/fclBAosEapT+sQe5wuoMg6lw27nBtibWWy+ht0kQRWjLN mMEjpBX+A6q7wWREwYiKYdr9zP10b6lEW/OmcqdX1WbKrtnDflxXb4AHT9dpH9unSn3CtLP0cFrqd z2yncHmxECO0YqiQ2+KwXXca9m0qf5gBKosZAYms3elfJrm/bama2HTRLBpQWrulrwQ/CrYaYPrbQ a71J5E1Zwv9QLID6FEvA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjPQH-0000t0-QW; Thu, 11 Jun 2020 15:47:21 +0000 Received: from mga09.intel.com ([134.134.136.24]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjPPF-0008Mv-Qf for linux-arm-kernel@lists.infradead.org; Thu, 11 Jun 2020 15:46:19 +0000 IronPort-SDR: k87t13apUFuO61yX3IWDe4LU/3eOIKCv0JsXqx7C36hjEWu0lQex5Ggw7WPxZz1mcAVDJJ1YAP alcoy7UNSi2A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2020 08:46:15 -0700 IronPort-SDR: 3iKlFSNmGLJIQjG6i4tV9DKlsjIjo/kGZ/UFziPeMJdfG9W3E92AKxhhodHCTS+EuQk+hqoqc0 jidNOjbX/9Jw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,499,1583222400"; d="scan'208";a="419145052" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.152]) by orsmga004.jf.intel.com with ESMTP; 11 Jun 2020 08:46:15 -0700 Date: Thu, 11 Jun 2020 08:46:15 -0700 From: Sean Christopherson To: Marc Zyngier Subject: Re: [PATCH 18/21] KVM: arm64: Use common KVM implementation of MMU memory caches Message-ID: <20200611154615.GG29918@linux.intel.com> References: <20200605213853.14959-1-sean.j.christopherson@intel.com> <20200605213853.14959-19-sean.j.christopherson@intel.com> <3555daf3b38c890e1e74f05d6f49f9be@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3555daf3b38c890e1e74f05d6f49f9be@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200611_084618_213081_F35D59E3 X-CRM114-Status: GOOD ( 10.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christoffer Dall , Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , linux-kernel@vger.kernel.org, Paul Mackerras , Ben Gardon , Claudio Imbrenda , kvmarm@lists.cs.columbia.edu, Janosch Frank , Joerg Roedel , Christian Borntraeger , Julien Thierry , Junaid Shahid , Suzuki K Poulose , kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jim Mattson , Cornelia Huck , Peter Shier , linux-mips@vger.kernel.org, James Morse , Paolo Bonzini , Vitaly Kuznetsov , Peter Feiner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 11, 2020 at 09:01:44AM +0100, Marc Zyngier wrote: > On 2020-06-05 22:38, Sean Christopherson wrote: ... > >@@ -1024,7 +993,7 @@ static pud_t *stage2_get_pud(struct kvm *kvm, > >struct kvm_mmu_memory_cache *cache > > if (stage2_pgd_none(kvm, *pgd)) { > > if (!cache) > > return NULL; > >- pud = mmu_memory_cache_alloc(cache); > >+ pud = kvm_mmu_memory_cache_alloc(cache); > > stage2_pgd_populate(kvm, pgd, pud); > > get_page(virt_to_page(pgd)); > > } > > Quick note: this patch (as it is) breaks on arm64 due to Mike Rapoport's > P4D rework. I've fixed it locally in order to test the series. Good to know, I'll wait to send v2 until that gets pulled into Paolo's tree. Thanks for the heads up, and especially for testing! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel