From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EF16C433DF for ; Fri, 12 Jun 2020 07:01:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0E4920801 for ; Fri, 12 Jun 2020 07:01:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0E4920801 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 11ED76E2F2; Fri, 12 Jun 2020 07:01:45 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id A8A5E6E2F2 for ; Fri, 12 Jun 2020 07:01:43 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 04E4680587; Fri, 12 Jun 2020 09:01:38 +0200 (CEST) Date: Fri, 12 Jun 2020 09:01:37 +0200 From: Sam Ravnborg To: Thomas Zimmermann Subject: Re: [PATCH 3/3] drm/ast: Use per-device logging macros Message-ID: <20200612070137.GA172811@ravnborg.org> References: <20200611082809.7838-1-tzimmermann@suse.de> <20200611082809.7838-4-tzimmermann@suse.de> <20200611192406.GB160102@ravnborg.org> <59164816-57b4-0279-56e9-a49a333ce839@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <59164816-57b4-0279-56e9-a49a333ce839@suse.de> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=G88y7es5 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=ZWOSB2g9pmbKBe_4jyEA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@redhat.com, chen@aspeedtech.com, kraxel@redhat.com, dri-devel@lists.freedesktop.org, emil.velikov@collabora.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Thomas On Fri, Jun 12, 2020 at 08:28:40AM +0200, Thomas Zimmermann wrote: > Hi Sam > > Am 11.06.20 um 21:24 schrieb Sam Ravnborg: > > Hi Thomas. > > On Thu, Jun 11, 2020 at 10:28:09AM +0200, Thomas Zimmermann wrote: > >> Converts the ast driver to drm_info() and drm_err(). No functional > >> changes are made. > >> > >> Signed-off-by: Thomas Zimmermann > > Acked-by: Sam Ravnborg > > > > I hope you will later follow-up with a patch that introduces drm_WARN_*. > > I only found DRM_INFO and DRM_ERROR calls. Did I miss any other warning > macros? The following: ast_mode.c: if (WARN_ON_ONCE(gpu_addr < 0)) ast_mode.c: if (WARN_ON_ONCE(fb->width > AST_MAX_HWC_WIDTH) || ast_mode.c: WARN_ON_ONCE(fb->height > AST_MAX_HWC_HEIGHT)) ast_mode.c: if (WARN_ON_ONCE(off < 0)) ast_mode.c: if (WARN_ON(!crtc->state)) can benefit from: /* * struct drm_device based WARNs * * drm_WARN*() acts like WARN*(), but with the key difference of * using device specific information so that we know from which device * warning is originating from. * * Prefer drm_device based drm_WARN* over regular WARN* */ ... #define drm_WARN_ON(drm, x) \ drm_WARN((drm), (x), "%s", \ "drm_WARN_ON(" __stringify(x) ")") #define drm_WARN_ON_ONCE(drm, x) \ drm_WARN_ONCE((drm), (x), "%s", \ "drm_WARN_ON_ONCE(" __stringify(x) ")") Also from drm/drm_print.h Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel