From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06760C433E1 for ; Fri, 12 Jun 2020 10:02:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDA4E207D8 for ; Fri, 12 Jun 2020 10:02:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591956137; bh=l002a0NI7RcMCZFY1NEScRszB3jXR41FbOH3xKTIu0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=J2jMbX3NCMPDfHBJULbVmHMWeGQHHhZIp68ec1GnCu1O81BiHEHQ5hD2CYmTQ+/u3 GZG74ScFtpRt5H5sIQTZTn8N2cptbHpDMCFK2uUrVLqp4BxaiIGi3jkyJspvc9JWxt 2nvfluW1gOYrE1VUNKc/WuOlzMgPZi38sNr1/5bc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726259AbgFLKCR (ORCPT ); Fri, 12 Jun 2020 06:02:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:36352 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726255AbgFLKCO (ORCPT ); Fri, 12 Jun 2020 06:02:14 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2E41207D8; Fri, 12 Jun 2020 10:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591956134; bh=l002a0NI7RcMCZFY1NEScRszB3jXR41FbOH3xKTIu0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cGQdHZmQx6Iz8xd3sx/auS+VvqT2rGKjwfQDZ8h/dBY2N2tzM5D3OjiRqCBIJdRNt k3ZsGLsKQ0VDgLNZVywYD8ZTtz+nDSJlguxS1fAIOQyJNqOCsAgLELeYzZMjTiVfh1 0hwtFX08T7047fYPzwaBnokj2V2ZnBXqxMNnMqdI= Date: Fri, 12 Jun 2020 12:02:05 +0200 From: Greg KH To: Markus Elfring Cc: Bernard Zhao , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, opensource.kernel@vivo.com, linux-kernel@vger.kernel.org, Daniel Vetter , David Airlie , Rob Clark , Sean Paul Subject: Re: [PATCH] drm/msm: Fix memory leak in msm_submitqueue_create() Message-ID: <20200612100205.GD3157576@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Jun 12, 2020 at 11:37:33AM +0200, Markus Elfring wrote: > > In fucntin msm_submitqueue_create, the queue is a local > > variable, in return -EINVAL branch, queue didn`t add to ctx`s > > list yet, and also didn`t kfree, this maybe bring in potential > > memleak. > > I suggest to improve also this change description. > How do you think about a wording variant like the following? > > Release the GPU submission queue object after an input parameter validation failed. > > > Would you like to add the tag “Fixes” to the commit message? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=b791d1bdf9212d944d749a5c7ff6febdba241771#n183 > > > How do you think about to reorder any statements for this function implementation? > > Regards, > Markus Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B3B7C433E0 for ; Fri, 12 Jun 2020 10:02:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CA522081A for ; Fri, 12 Jun 2020 10:02:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cGQdHZmQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CA522081A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D1B9F6E90E; Fri, 12 Jun 2020 10:02:15 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7D38B6E90D; Fri, 12 Jun 2020 10:02:14 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2E41207D8; Fri, 12 Jun 2020 10:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591956134; bh=l002a0NI7RcMCZFY1NEScRszB3jXR41FbOH3xKTIu0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cGQdHZmQx6Iz8xd3sx/auS+VvqT2rGKjwfQDZ8h/dBY2N2tzM5D3OjiRqCBIJdRNt k3ZsGLsKQ0VDgLNZVywYD8ZTtz+nDSJlguxS1fAIOQyJNqOCsAgLELeYzZMjTiVfh1 0hwtFX08T7047fYPzwaBnokj2V2ZnBXqxMNnMqdI= Date: Fri, 12 Jun 2020 12:02:05 +0200 From: Greg KH To: Markus Elfring Subject: Re: [PATCH] drm/msm: Fix memory leak in msm_submitqueue_create() Message-ID: <20200612100205.GD3157576@kroah.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul , opensource.kernel@vivo.com, David Airlie , Bernard Zhao , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCBKdW4gMTIsIDIwMjAgYXQgMTE6Mzc6MzNBTSArMDIwMCwgTWFya3VzIEVsZnJpbmcg d3JvdGU6Cj4gPiBJbiBmdWNudGluIG1zbV9zdWJtaXRxdWV1ZV9jcmVhdGUsIHRoZSBxdWV1ZSBp cyBhIGxvY2FsCj4gPiB2YXJpYWJsZSwgaW4gcmV0dXJuIC1FSU5WQUwgYnJhbmNoLCBxdWV1ZSBk aWRuYHQgYWRkIHRvIGN0eGBzCj4gPiBsaXN0IHlldCwgYW5kIGFsc28gZGlkbmB0IGtmcmVlLCB0 aGlzIG1heWJlIGJyaW5nIGluIHBvdGVudGlhbAo+ID4gbWVtbGVhay4KPiAKPiBJIHN1Z2dlc3Qg dG8gaW1wcm92ZSBhbHNvIHRoaXMgY2hhbmdlIGRlc2NyaXB0aW9uLgo+IEhvdyBkbyB5b3UgdGhp bmsgYWJvdXQgYSB3b3JkaW5nIHZhcmlhbnQgbGlrZSB0aGUgZm9sbG93aW5nPwo+IAo+ICAgIFJl bGVhc2UgdGhlIEdQVSBzdWJtaXNzaW9uIHF1ZXVlIG9iamVjdCBhZnRlciBhbiBpbnB1dCBwYXJh bWV0ZXIgdmFsaWRhdGlvbiBmYWlsZWQuCj4gCj4gCj4gV291bGQgeW91IGxpa2UgdG8gYWRkIHRo ZSB0YWcg4oCcRml4ZXPigJ0gdG8gdGhlIGNvbW1pdCBtZXNzYWdlPwo+IGh0dHBzOi8vZ2l0Lmtl cm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdC90cmVl L0RvY3VtZW50YXRpb24vcHJvY2Vzcy9zdWJtaXR0aW5nLXBhdGNoZXMucnN0P2lkPWI3OTFkMWJk ZjkyMTJkOTQ0ZDc0OWE1YzdmZjZmZWJkYmEyNDE3NzEjbjE4Mwo+IAo+IAo+IEhvdyBkbyB5b3Ug dGhpbmsgYWJvdXQgdG8gcmVvcmRlciBhbnkgc3RhdGVtZW50cyBmb3IgdGhpcyBmdW5jdGlvbiBp bXBsZW1lbnRhdGlvbj8KPiAKPiBSZWdhcmRzLAo+IE1hcmt1cwoKSGksCgpUaGlzIGlzIHRoZSBz ZW1pLWZyaWVuZGx5IHBhdGNoLWJvdCBvZiBHcmVnIEtyb2FoLUhhcnRtYW4uCgpNYXJrdXMsIHlv dSBzZWVtIHRvIGhhdmUgc2VudCBhIG5vbnNlbnNpY2FsIG9yIG90aGVyd2lzZSBwb2ludGxlc3MK cmV2aWV3IGNvbW1lbnQgdG8gYSBwYXRjaCBzdWJtaXNzaW9uIG9uIGEgTGludXgga2VybmVsIGRl dmVsb3BlciBtYWlsaW5nCmxpc3QuICBJIHN0cm9uZ2x5IHN1Z2dlc3QgdGhhdCB5b3Ugbm90IGRv IHRoaXMgYW55bW9yZS4gIFBsZWFzZSBkbyBub3QKYm90aGVyIGRldmVsb3BlcnMgd2hvIGFyZSBh Y3RpdmVseSB3b3JraW5nIHRvIHByb2R1Y2UgcGF0Y2hlcyBhbmQKZmVhdHVyZXMgd2l0aCBjb21t ZW50cyB0aGF0LCBpbiB0aGUgZW5kLCBhcmUgYSB3YXN0ZSBvZiB0aW1lLgoKUGF0Y2ggc3VibWl0 dGVyLCBwbGVhc2UgaWdub3JlIE1hcmt1cydzIHN1Z2dlc3Rpb247IHlvdSBkbyBub3QgbmVlZCB0 bwpmb2xsb3cgaXQgYXQgYWxsLiAgVGhlIHBlcnNvbi9ib3QvQUkgdGhhdCBzZW50IGl0IGlzIGJl aW5nIGlnbm9yZWQgYnkKYWxtb3N0IGFsbCBMaW51eCBrZXJuZWwgbWFpbnRhaW5lcnMgZm9yIGhh dmluZyBhIHBlcnNpc3RlbnQgcGF0dGVybiBvZgpiZWhhdmlvciBvZiBwcm9kdWNpbmcgZGlzdHJh Y3RpbmcgYW5kIHBvaW50bGVzcyBjb21tZW50YXJ5LCBhbmQKaW5hYmlsaXR5IHRvIGFkYXB0IHRv IGZlZWRiYWNrLiAgUGxlYXNlIGZlZWwgZnJlZSB0byBhbHNvIGlnbm9yZSBlbWFpbHMKZnJvbSB0 aGVtLgoKdGhhbmtzLAoKZ3JlZyBrLWgncyBwYXRjaCBlbWFpbCBib3QKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==