From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Kevin P. Fleming" <kevin+linux@km6g.us>
Cc: devicetree@vger.kernel.org, linux-rtc@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 2/2] rtc: abx80x: Add support for autocalibration filter capacitor
Date: Fri, 12 Jun 2020 18:31:26 +0200 [thread overview]
Message-ID: <20200612163126.GC4232@piout.net> (raw)
In-Reply-To: <CAE+UdoqR1iPaYxT4aMCNkq0z8duy6abJcuojDz=wKCe7ZMtD5Q@mail.gmail.com>
On 12/06/2020 07:55:53-0400, Kevin P. Fleming wrote:
> On Wed, Jun 10, 2020 at 11:22 AM Alexandre Belloni
> <alexandre.belloni@bootlin.com> wrote:
> > I'd like to avoid having more error messages in the driver (and whole
> > subsystem). Can you move the ABX8XX_REG_CFG_KEY setting earlier in
> > abx80x_probe so you don't have to do it here and avoid duplication the
> > error message?
> >
>
> Based on my reading of the app manual this won't work properly, as
> setting the configuration key only allows writing to one register, and
> then the key is reset. It has to be set to allow enabling the trickle
> charger, and also to allow enabling the autocalibration filter
> capacitor.
>
That is correct and I forgot about that. Can you move just setting the
key to a function as a preliminary patch?
> > The RTC can still work if this fails and the rror is transient, maybe
> > just warn and continue. It will be set on the next probe.
>
> Will fix in the next version of the patch.
>
> Thanks for the review!
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-06-12 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 12:48 [PATCH 1/2] dt-bindings: abx80x: Add autocal-filter property Kevin P. Fleming
2020-05-30 12:49 ` [PATCH 2/2] rtc: abx80x: Add support for autocalibration filter capacitor Kevin P. Fleming
2020-06-10 15:22 ` Alexandre Belloni
2020-06-12 11:55 ` Kevin P. Fleming
2020-06-12 16:31 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612163126.GC4232@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=devicetree@vger.kernel.org \
--cc=kevin+linux@km6g.us \
--cc=linux-rtc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.