diff for duplicates of <20200612173838.GH4282@kadam> diff --git a/a/1.txt b/N1/1.txt index 5965ee3..5d4b1e3 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,12 +4,18 @@ On Fri, Jun 12, 2020 at 02:11:16PM +0000, Walter Harms wrote: > nit picking in cti_pm_release() > > IMHO this should be done in 2 steps: -> if (--nr_cti_cpu = 0) +> if (--nr_cti_cpu == 0) > -> > --nr_cti_cpu ; -> if ( nr_cti_cpu = 0) +> if ( nr_cti_cpu == 0) The first way is sort of the more canonical way to write it... By far. regards, carpenter + + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N1/content_digest index 9fdabe6..6ad1646 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\06c59bdbc15714b089d256ad50aee58cb@bfs.de\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH] coresight: cti: Fix error handling in probe\0" - "Date\0Fri, 12 Jun 2020 17:38:38 +0000\0" + "Date\0Fri, 12 Jun 2020 20:38:38 +0300\0" "To\0Walter Harms <wharms@bfs.de>\0" "Cc\0Mathieu Poirier <mathieu.poirier@linaro.org>" Suzuki K Poulose <suzuki.poulose@arm.com> @@ -21,14 +21,20 @@ "> nit picking in cti_pm_release()\n" "> \n" "> IMHO this should be done in 2 steps:\n" - "> if (--nr_cti_cpu = 0)\n" + "> if (--nr_cti_cpu == 0)\n" "> ->\n" "> --nr_cti_cpu ;\n" - "> if ( nr_cti_cpu = 0)\n" + "> if ( nr_cti_cpu == 0)\n" "\n" "The first way is sort of the more canonical way to write it... By far.\n" "\n" "regards,\n" - carpenter + "carpenter\n" + "\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -5b85415208eb3689bf4205c7fb4677cd49c0c035bed7bc42b6a26da49e7dec05 +c25ec536656f826dfccc50747f5048b61cde09a11faf40def5f068a9023417d4
diff --git a/a/1.txt b/N2/1.txt index 5965ee3..7deeaeb 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -4,10 +4,10 @@ On Fri, Jun 12, 2020 at 02:11:16PM +0000, Walter Harms wrote: > nit picking in cti_pm_release() > > IMHO this should be done in 2 steps: -> if (--nr_cti_cpu = 0) +> if (--nr_cti_cpu == 0) > -> > --nr_cti_cpu ; -> if ( nr_cti_cpu = 0) +> if ( nr_cti_cpu == 0) The first way is sort of the more canonical way to write it... By far. diff --git a/a/content_digest b/N2/content_digest index 9fdabe6..98d4f77 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,16 +3,16 @@ "ref\06c59bdbc15714b089d256ad50aee58cb@bfs.de\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH] coresight: cti: Fix error handling in probe\0" - "Date\0Fri, 12 Jun 2020 17:38:38 +0000\0" + "Date\0Fri, 12 Jun 2020 20:38:38 +0300\0" "To\0Walter Harms <wharms@bfs.de>\0" - "Cc\0Mathieu Poirier <mathieu.poirier@linaro.org>" + "Cc\0Mike Leach <mike.leach@linaro.org>" + Mathieu Poirier <mathieu.poirier@linaro.org> Suzuki K Poulose <suzuki.poulose@arm.com> Alexander Shishkin <alexander.shishkin@linux.intel.com> Greg Kroah-Hartman <gregkh@linuxfoundation.org> - kernel-janitors@vger.kernel.org <kernel-janitors@vger.kernel.org> - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> - " Mike Leach <mike.leach@linaro.org>\0" + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + " kernel-janitors@vger.kernel.org <kernel-janitors@vger.kernel.org>\0" "\00:1\0" "b\0" "On Fri, Jun 12, 2020 at 02:11:16PM +0000, Walter Harms wrote:\n" @@ -21,14 +21,14 @@ "> nit picking in cti_pm_release()\n" "> \n" "> IMHO this should be done in 2 steps:\n" - "> if (--nr_cti_cpu = 0)\n" + "> if (--nr_cti_cpu == 0)\n" "> ->\n" "> --nr_cti_cpu ;\n" - "> if ( nr_cti_cpu = 0)\n" + "> if ( nr_cti_cpu == 0)\n" "\n" "The first way is sort of the more canonical way to write it... By far.\n" "\n" "regards,\n" carpenter -5b85415208eb3689bf4205c7fb4677cd49c0c035bed7bc42b6a26da49e7dec05 +7ffe7cc1fc0d99b86d25530bdca3a08c4cfc1fa560066e7cd3c7c0fbecf0d68c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.