diff for duplicates of <20200612174215.GI4282@kadam> diff --git a/a/1.txt b/N1/1.txt index 6e328bc..61b3bd7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,7 +3,7 @@ On Fri, Jun 12, 2020 at 03:11:33PM +0300, Dan Carpenter wrote: > +{ > + int ret; > + -> + if (drvdata->ctidev.cpu = -1) +> + if (drvdata->ctidev.cpu == -1) > + return 0; > + > + if (nr_cti_cpu) @@ -42,9 +42,9 @@ patch doesn't change anything, but I am curious. > static void cti_pm_release(struct cti_drvdata *drvdata) > { > - if (drvdata->ctidev.cpu >= 0) { -> - if (--nr_cti_cpu = 0) { +> - if (--nr_cti_cpu == 0) { > - cpu_pm_unregister_notifier(&cti_cpu_pm_nb); -> + if (drvdata->ctidev.cpu = -1) +> + if (drvdata->ctidev.cpu == -1) > + return; > > - cpuhp_remove_state_nocalls( @@ -52,7 +52,7 @@ patch doesn't change anything, but I am curious. > - } > - cti_cpu_drvdata[drvdata->ctidev.cpu] = NULL; > + cti_cpu_drvdata[drvdata->ctidev.cpu] = drvdata; -> + if (--nr_cti_cpu = 0) { +> + if (--nr_cti_cpu == 0) { > + cpu_pm_unregister_notifier(&cti_cpu_pm_nb); > + cpuhp_remove_state_nocalls(CPUHP_AP_ARM_CORESIGHT_CTI_STARTING); > } @@ -60,3 +60,9 @@ patch doesn't change anything, but I am curious. regards, dan carpenter + + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N1/content_digest index 1b39fb1..7b15393 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020200612121133.GA1139533@mwanda\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH] coresight: cti: Fix error handling in probe\0" - "Date\0Fri, 12 Jun 2020 17:42:16 +0000\0" + "Date\0Fri, 12 Jun 2020 20:42:16 +0300\0" "To\0Mike Leach <mike.leach@linaro.org>\0" "Cc\0Mathieu Poirier <mathieu.poirier@linaro.org>" Suzuki K Poulose <suzuki.poulose@arm.com> @@ -18,7 +18,7 @@ "> +{\n" "> +\tint ret;\n" "> +\n" - "> +\tif (drvdata->ctidev.cpu = -1)\n" + "> +\tif (drvdata->ctidev.cpu == -1)\n" "> +\t\treturn 0;\n" "> +\n" "> +\tif (nr_cti_cpu)\n" @@ -57,9 +57,9 @@ "> static void cti_pm_release(struct cti_drvdata *drvdata)\n" "> {\n" "> -\tif (drvdata->ctidev.cpu >= 0) {\n" - "> -\t\tif (--nr_cti_cpu = 0) {\n" + "> -\t\tif (--nr_cti_cpu == 0) {\n" "> -\t\t\tcpu_pm_unregister_notifier(&cti_cpu_pm_nb);\n" - "> +\tif (drvdata->ctidev.cpu = -1)\n" + "> +\tif (drvdata->ctidev.cpu == -1)\n" "> +\t\treturn;\n" "> \n" "> -\t\t\tcpuhp_remove_state_nocalls(\n" @@ -67,13 +67,19 @@ "> -\t\t}\n" "> -\t\tcti_cpu_drvdata[drvdata->ctidev.cpu] = NULL;\n" "> +\tcti_cpu_drvdata[drvdata->ctidev.cpu] = drvdata;\n" - "> +\tif (--nr_cti_cpu = 0) {\n" + "> +\tif (--nr_cti_cpu == 0) {\n" "> +\t\tcpu_pm_unregister_notifier(&cti_cpu_pm_nb);\n" "> +\t\tcpuhp_remove_state_nocalls(CPUHP_AP_ARM_CORESIGHT_CTI_STARTING);\n" "> \t}\n" "> }\n" "\n" "regards,\n" - dan carpenter + "dan carpenter\n" + "\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -9ed8a8eaf45644c6904bc2d9a6718bbc4645b4a87e5b1d868ec2adf3c4cf18b1 +9e549ebbd4044a1cd13a941e2d407de7c16031d3b514e7a4a35a558ec9c16751
diff --git a/a/1.txt b/N2/1.txt index 6e328bc..164a1df 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -3,7 +3,7 @@ On Fri, Jun 12, 2020 at 03:11:33PM +0300, Dan Carpenter wrote: > +{ > + int ret; > + -> + if (drvdata->ctidev.cpu = -1) +> + if (drvdata->ctidev.cpu == -1) > + return 0; > + > + if (nr_cti_cpu) @@ -42,9 +42,9 @@ patch doesn't change anything, but I am curious. > static void cti_pm_release(struct cti_drvdata *drvdata) > { > - if (drvdata->ctidev.cpu >= 0) { -> - if (--nr_cti_cpu = 0) { +> - if (--nr_cti_cpu == 0) { > - cpu_pm_unregister_notifier(&cti_cpu_pm_nb); -> + if (drvdata->ctidev.cpu = -1) +> + if (drvdata->ctidev.cpu == -1) > + return; > > - cpuhp_remove_state_nocalls( @@ -52,7 +52,7 @@ patch doesn't change anything, but I am curious. > - } > - cti_cpu_drvdata[drvdata->ctidev.cpu] = NULL; > + cti_cpu_drvdata[drvdata->ctidev.cpu] = drvdata; -> + if (--nr_cti_cpu = 0) { +> + if (--nr_cti_cpu == 0) { > + cpu_pm_unregister_notifier(&cti_cpu_pm_nb); > + cpuhp_remove_state_nocalls(CPUHP_AP_ARM_CORESIGHT_CTI_STARTING); > } diff --git a/a/content_digest b/N2/content_digest index 1b39fb1..c7abed2 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,15 +2,15 @@ "ref\020200612121133.GA1139533@mwanda\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH] coresight: cti: Fix error handling in probe\0" - "Date\0Fri, 12 Jun 2020 17:42:16 +0000\0" + "Date\0Fri, 12 Jun 2020 20:42:16 +0300\0" "To\0Mike Leach <mike.leach@linaro.org>\0" "Cc\0Mathieu Poirier <mathieu.poirier@linaro.org>" Suzuki K Poulose <suzuki.poulose@arm.com> Alexander Shishkin <alexander.shishkin@linux.intel.com> Greg Kroah-Hartman <gregkh@linuxfoundation.org> - kernel-janitors@vger.kernel.org + linux-arm-kernel@lists.infradead.org linux-kernel@vger.kernel.org - " linux-arm-kernel@lists.infradead.org\0" + " kernel-janitors@vger.kernel.org\0" "\00:1\0" "b\0" "On Fri, Jun 12, 2020 at 03:11:33PM +0300, Dan Carpenter wrote:\n" @@ -18,7 +18,7 @@ "> +{\n" "> +\tint ret;\n" "> +\n" - "> +\tif (drvdata->ctidev.cpu = -1)\n" + "> +\tif (drvdata->ctidev.cpu == -1)\n" "> +\t\treturn 0;\n" "> +\n" "> +\tif (nr_cti_cpu)\n" @@ -57,9 +57,9 @@ "> static void cti_pm_release(struct cti_drvdata *drvdata)\n" "> {\n" "> -\tif (drvdata->ctidev.cpu >= 0) {\n" - "> -\t\tif (--nr_cti_cpu = 0) {\n" + "> -\t\tif (--nr_cti_cpu == 0) {\n" "> -\t\t\tcpu_pm_unregister_notifier(&cti_cpu_pm_nb);\n" - "> +\tif (drvdata->ctidev.cpu = -1)\n" + "> +\tif (drvdata->ctidev.cpu == -1)\n" "> +\t\treturn;\n" "> \n" "> -\t\t\tcpuhp_remove_state_nocalls(\n" @@ -67,7 +67,7 @@ "> -\t\t}\n" "> -\t\tcti_cpu_drvdata[drvdata->ctidev.cpu] = NULL;\n" "> +\tcti_cpu_drvdata[drvdata->ctidev.cpu] = drvdata;\n" - "> +\tif (--nr_cti_cpu = 0) {\n" + "> +\tif (--nr_cti_cpu == 0) {\n" "> +\t\tcpu_pm_unregister_notifier(&cti_cpu_pm_nb);\n" "> +\t\tcpuhp_remove_state_nocalls(CPUHP_AP_ARM_CORESIGHT_CTI_STARTING);\n" "> \t}\n" @@ -76,4 +76,4 @@ "regards,\n" dan carpenter -9ed8a8eaf45644c6904bc2d9a6718bbc4645b4a87e5b1d868ec2adf3c4cf18b1 +0719e6a2754032f97e2b5cb8b347bc5d15ef19cae45a2dcd36dfa63224ac603d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.