All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ricardo Ferreira <rikajff@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	devel@driverdev.osuosl.org,
	Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
	linux-kernel@vger.kernel.org,
	Nishka Dasgupta <nishkadg.linux@gmail.com>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] Staging: rtl8712: Addressed checkpatch.pl issues related to macro parameter wrapping in parentheses.
Date: Sun, 14 Jun 2020 16:05:31 +0200	[thread overview]
Message-ID: <20200614140531.GA2661398@kroah.com> (raw)
In-Reply-To: <20200614135125.19502-1-rikajff@gmail.com>

On Sun, Jun 14, 2020 at 02:51:25PM +0100, Ricardo Ferreira wrote:
>  #define init_h2fwcmd_w_parm_no_rsp(pcmd, pparm, code) \
>  do {\
> -	INIT_LIST_HEAD(&pcmd->list);\
> -	pcmd->cmdcode = code;\
> -	pcmd->parmbuf = (u8 *)(pparm);\
> -	pcmd->cmdsz = sizeof(*pparm);\
> -	pcmd->rsp = NULL;\
> -	pcmd->rspsz = 0;\
> +	INIT_LIST_HEAD(&(pcmd)->list);\
> +	(pcmd)->cmdcode = code;\
> +	(pcmd)->parmbuf = (u8 *)((pparm));\
> +	(pcmd)->cmdsz = sizeof(*(pparm));\
> +	(pcmd)->rsp = NULL;\
> +	(pcmd)->rspsz = 0;\
>  } while (0)

Does that change really make any sense?  checkpatch is a nice hint,
sometimes it is not correct...

  reply	other threads:[~2020-06-14 14:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-14 13:51 [PATCH] Staging: rtl8712: Addressed checkpatch.pl issues related to macro parameter wrapping in parentheses Ricardo Ferreira
2020-06-14 14:05 ` Greg Kroah-Hartman [this message]
2020-06-15  9:28   ` Ricardo Ferreira
2020-06-15 12:34     ` Greg Kroah-Hartman
2020-06-14 17:51 ` kernel test robot
2020-06-14 17:51   ` kernel test robot
2020-06-14 18:58 ` kernel test robot
2020-06-14 18:58   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200614140531.GA2661398@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nishkadg.linux@gmail.com \
    --cc=rikajff@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.