From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: Good idea to rename files in include/uapi/ ? Date: Sun, 14 Jun 2020 23:47:15 +0100 Message-ID: <20200614224715.GJ23230@ZenIV.linux.org.uk> References: <9feded75-4b45-2821-287b-af00ec5f910f@al2klimov.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <9feded75-4b45-2821-287b-af00ec5f910f@al2klimov.de> Sender: linux-kernel-owner@vger.kernel.org To: "Alexander A. Klimov" Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , Alan Stern , Andrea Parri , Will Deacon , Peter Zijlstra , Boqun Feng , Nicholas Piggin , David Howells , Jade Alglave , Luc Maranget , "Paul E. McKenney" , Akira Yokosawa , Daniel Lustig , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Sun, Jun 14, 2020 at 09:41:17PM +0200, Alexander A. Klimov wrote: > Hello there! > > At the moment one can't checkout a clean working directory w/o any changed > files on a case-insensitive FS as the following file names have lower-case > duplicates: And if you use a filesystem that is limited to 14 characters in name (or that weird 8 + 3 thing) you'll also have problems. Doctor, it hurts when I do it... > Also even on a case-sensitive one VIm seems to have trouble with editing > both case-insensitively equal files at the same time. So file a bug report against vim. Or use a vi variant without such a problem (FWIW, nvi has nothing of that sort). > I was going to make a patch renaming the respective duplicates, but I'm not > sure: > > *Is it a good idea to rename files in include/uapi/ ?* It is not. Strictly speaking, C99 allows implementation to consider the header names differing only in case as refering to the same file, but then it allows to ignore everything between the 8th character and the first dot in those. Not done on Unices, so #include is not going to pick /usr/include/shite.h If it's used by any userland code, that's it - changing the name (in any fashion) will break that userland code. If it isn't, it shouldn't have been in include/uabi in the first place. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727928AbgFNWrz (ORCPT ); Sun, 14 Jun 2020 18:47:55 -0400 Date: Sun, 14 Jun 2020 23:47:15 +0100 From: Al Viro Subject: Re: Good idea to rename files in include/uapi/ ? Message-ID: <20200614224715.GJ23230@ZenIV.linux.org.uk> References: <9feded75-4b45-2821-287b-af00ec5f910f@al2klimov.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9feded75-4b45-2821-287b-af00ec5f910f@al2klimov.de> Sender: linux-arch-owner@vger.kernel.org List-ID: To: "Alexander A. Klimov" Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , Alan Stern , Andrea Parri , Will Deacon , Peter Zijlstra , Boqun Feng , Nicholas Piggin , David Howells , Jade Alglave , Luc Maranget , "Paul E. McKenney" , Akira Yokosawa , Daniel Lustig , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-arch@vger.kernel.org Message-ID: <20200614224715.CNpTtlz3dcX6eUugpWC9MtlQJrUtRSHY3g2g8CZJPrQ@z> On Sun, Jun 14, 2020 at 09:41:17PM +0200, Alexander A. Klimov wrote: > Hello there! > > At the moment one can't checkout a clean working directory w/o any changed > files on a case-insensitive FS as the following file names have lower-case > duplicates: And if you use a filesystem that is limited to 14 characters in name (or that weird 8 + 3 thing) you'll also have problems. Doctor, it hurts when I do it... > Also even on a case-sensitive one VIm seems to have trouble with editing > both case-insensitively equal files at the same time. So file a bug report against vim. Or use a vi variant without such a problem (FWIW, nvi has nothing of that sort). > I was going to make a patch renaming the respective duplicates, but I'm not > sure: > > *Is it a good idea to rename files in include/uapi/ ?* It is not. Strictly speaking, C99 allows implementation to consider the header names differing only in case as refering to the same file, but then it allows to ignore everything between the 8th character and the first dot in those. Not done on Unices, so #include is not going to pick /usr/include/shite.h If it's used by any userland code, that's it - changing the name (in any fashion) will break that userland code. If it isn't, it shouldn't have been in include/uabi in the first place.