From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B742BC433DF for ; Mon, 15 Jun 2020 06:50:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 865962068E for ; Mon, 15 Jun 2020 06:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592203806; bh=MVFgK3yeWPZ+i6DSCvto+y8Jl33RI6uJ7L+1TA3EfUY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rSrN3z8bBUTs+m8NafrRvWY5mPoAUO59LSv/D9BCjK5Mc60FrcnsW1hXuIFU8nvdj LQVkuzLxEfkn1AjCwqosNwW1N07y/T7uz0MJj3+vezwIxXMyRb0VBg+2Uc62yMRKZS xU0LZYpSUtISlZqoeIqC8Fr3BzmWRTZPrICwproY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728538AbgFOGuG (ORCPT ); Mon, 15 Jun 2020 02:50:06 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:46555 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728486AbgFOGuF (ORCPT ); Mon, 15 Jun 2020 02:50:05 -0400 Received: by mail-ed1-f67.google.com with SMTP id m21so10634074eds.13; Sun, 14 Jun 2020 23:50:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vKJpOmM9DH/2UhmBwmYAEHUF6KlZyjtAnBjFXv+lhg8=; b=dmMil4HxQdMjiwap0oj02lDOttOFmdYfxNdo6qimXZEJey9PaW4lt7dchzUKNZnNm+ z7mwgequY2fF4TjR7H2qFZ9i+DAnwm9ZNf8JsTq0rkLJlx5C9r/F5mHA84fm0K9uvp4Z QR5GzFU7Nw6DL9Y1P/u9oNz4pHRzEnPdICuO+Y2/Zx3LDejSbrmDw6h9IQAeggeSf7Xo mtyu0FSpwJ1C8AIFyFA+mfNkOj4yEZC9DzYvqBF1pfUpEQhjH9aucjbxM/b8W6cZTIU2 dun0FIbro9YNICwlnKzNb6/A7/hkDP+0W3nNVp0HNligaZKrxijhIq/vOavAHlo5DHlb e/1A== X-Gm-Message-State: AOAM531A240ThJkVfk3YXzN+m+IJ6UCL+iSVgoU5Ih1vEWbwVsGYYBjg J26T67fqZ5C536bed+1FEyI= X-Google-Smtp-Source: ABdhPJxD5/50BDSpXBl1ldUdAkvys7Ip8mS9MB2im+cSgFQh8Vj0lNC/SZV7F9XvmjbinVMlk37bfQ== X-Received: by 2002:aa7:d388:: with SMTP id x8mr23084385edq.380.1592203803200; Sun, 14 Jun 2020 23:50:03 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id q14sm7801859edj.47.2020.06.14.23.50.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 14 Jun 2020 23:50:02 -0700 (PDT) Date: Mon, 15 Jun 2020 08:50:00 +0200 From: Krzysztof Kozlowski To: Oleksij Rempel , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Wolfram Sang , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Marc Kleine-Budde , Oleksij Rempel , stable@vger.kernel.org Subject: Re: [PATCH v2 1/2] i2c: imx: Fix PM runtime inbalance in probe error path Message-ID: <20200615065000.GA7728@kozik-lap> References: <1592130544-19759-1-git-send-email-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1592130544-19759-1-git-send-email-krzk@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Sun, Jun 14, 2020 at 12:29:03PM +0200, Krzysztof Kozlowski wrote: > When pm_runtime_get_sync() fails in probe(), the error path should not > call pm_runtime_put_noidle(). This would lead to inbalance in > usage_count. > > Fixes: 588eb93ea49f ("i2c: imx: add runtime pm support to improve the performance") > Cc: > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. New patch This patch is not correct because the runtime usage counter is increased always, also on failures. It can be dropped. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D26C2C433E0 for ; Mon, 15 Jun 2020 06:50:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A46122067B for ; Mon, 15 Jun 2020 06:50:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qTKWzF3j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A46122067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3ga3YYOEYpMK3Q3fqfWNmykSPFDjG2QjLH4KAk0czsw=; b=qTKWzF3j/8YVOt APss3f+NQ2RXU4dnTMWbgwUk9AzCTqLHpQMRi7OCqg5ACJimlKehO1ofJKV9SUCPs68Ujp2wG3oso Dnak1225fRlWrY5h5U8Dx7ifTBvHUvkJkTnrS+UhVWdfFmuUZSKDjUxu+RmMP2oXonwBQ6LY4Pp8Z Wgc4mFaeQ4LcJVKj5rST81W6lP9JHHr2wJFVqWx0AUBB8SsuQwvOo4R6si/NEK2Ih8lPgCWQgZrPf MRSS37pQeQtJkWTrXE0JsSF/2CLox2sIaKIjwKByvW2kZrsZfaGhm7AU/f5JTZSMREX82gZ1vrJJb A7/NHtqL0WaGUdBUEbIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkiwb-0004oN-HB; Mon, 15 Jun 2020 06:50:09 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkiwW-0003yJ-WD for linux-arm-kernel@lists.infradead.org; Mon, 15 Jun 2020 06:50:06 +0000 Received: by mail-ed1-f68.google.com with SMTP id t21so10634358edr.12 for ; Sun, 14 Jun 2020 23:50:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vKJpOmM9DH/2UhmBwmYAEHUF6KlZyjtAnBjFXv+lhg8=; b=J3yTZadSmc7/qiEDHDeQ6cLDJ9P1wIUPLSYX3tsu6+hdQQVymSIhnwl2Zn2Zk6FlL4 MneZmHMbwKQyrTI1bS3hygs8galxGnr3aG3HkXL1xG+mazvLbzofAYr2m6tWjvhYgCdt UeUvoCXB10k5us6Nd4EFYyBgdT/kceXO0Bpr3cpFPd04l0hib6rnHCfBWYtUNKYY0ymS dCs4Pb0X6jSljOZSv/UX9JmRbJoM/GBCA4AGejt6dDE2MzmjvmxufsGT1CpMs0onsTpp /GF6kvTUz+IS2rJZIljtuOlnRzEbNkn84F/yxumlus1dlyOzXXsIG/o47Ub8LdfAV6fI inOg== X-Gm-Message-State: AOAM531KksPKba4d3j6MaFg0beAMt+KK2aAoUnQr68IFpehkmlNQaTcy TDyt+fULqFu+b68ZR1eDknA= X-Google-Smtp-Source: ABdhPJxD5/50BDSpXBl1ldUdAkvys7Ip8mS9MB2im+cSgFQh8Vj0lNC/SZV7F9XvmjbinVMlk37bfQ== X-Received: by 2002:aa7:d388:: with SMTP id x8mr23084385edq.380.1592203803200; Sun, 14 Jun 2020 23:50:03 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id q14sm7801859edj.47.2020.06.14.23.50.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 14 Jun 2020 23:50:02 -0700 (PDT) Date: Mon, 15 Jun 2020 08:50:00 +0200 From: Krzysztof Kozlowski To: Oleksij Rempel , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Wolfram Sang , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] i2c: imx: Fix PM runtime inbalance in probe error path Message-ID: <20200615065000.GA7728@kozik-lap> References: <1592130544-19759-1-git-send-email-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1592130544-19759-1-git-send-email-krzk@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200614_235005_045941_B9C7A1CA X-CRM114-Status: GOOD ( 11.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oleksij Rempel , Marc Kleine-Budde , stable@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jun 14, 2020 at 12:29:03PM +0200, Krzysztof Kozlowski wrote: > When pm_runtime_get_sync() fails in probe(), the error path should not > call pm_runtime_put_noidle(). This would lead to inbalance in > usage_count. > > Fixes: 588eb93ea49f ("i2c: imx: add runtime pm support to improve the performance") > Cc: > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. New patch This patch is not correct because the runtime usage counter is increased always, also on failures. It can be dropped. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel