From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A783C433E0 for ; Mon, 15 Jun 2020 06:58:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BD5B2067B for ; Mon, 15 Jun 2020 06:58:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592204333; bh=P2Ary7w7QLpxLwvvO6zF7cGZEv1dglEer1JOQDUDFW0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=sNF9KlIkbKXqJa+sEllhI1/jTNjqQuSTKpfDGk7Jmwl33NHLSiYaJKO1TpnQxJy6H rt7UHua3YhzCFjfRDLEerqhXGOj1Dz8R7C1cza6MTzb96VQR3bfedRkA1PPHUXiPz4 Uo89ivCOBjVAuB+XPyEwFdQ8U0MEWhrXL66kTsxw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728283AbgFOG6w (ORCPT ); Mon, 15 Jun 2020 02:58:52 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:34371 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728276AbgFOG6v (ORCPT ); Mon, 15 Jun 2020 02:58:51 -0400 Received: by mail-wr1-f67.google.com with SMTP id r7so15863614wro.1; Sun, 14 Jun 2020 23:58:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=15pzvZ3HgzVpOIe1NSunNL4NazqLAoN4J8Q/f2NVLd8=; b=kJO4LvBPRRxzDW+hruK9cyPECKVXeUaSwoFgi+rt2G6j+lvqMywBKgbouLf/Eo2fOy NpyxzN1XfaIgdFRG5jULjxbGPCBbX4HODlf39u3MEvt14GwJ55uKeBypggTnNZ7vBCd0 HGPkDqMSgwZxG/6ZlDE+KOz5E3m957i07jdGGGyKgyjHdNHlsVAvNeqBgFujfsnJJQpb ijW+HdEUM6Ys8hizKHPZhkPKBRO7NI348HpK8s/0W94RxXbmOXuQIP8N7zZI4I5sWSxD xU3jbcyUWF4nBN4mhDKyeLdsSqswK3xq51Y9iPsRHZqTYMcFh0LJxR47A7uDRKdIAOGA gGug== X-Gm-Message-State: AOAM530Ug/mBhDx99ZzCAvVdxySQtHBGrpPVy9akjY7ZLvcOEqATSO1d 3aL/+pj7KFtMQjX3lycC8ig= X-Google-Smtp-Source: ABdhPJxC3uTidSFQuPJd5N+ZIugAF5DjMqJZwBdBMRxo/CsJfJGnW54QJwO/PEzPpqMarcPL1KnxUw== X-Received: by 2002:a5d:5585:: with SMTP id i5mr26775604wrv.112.1592204329345; Sun, 14 Jun 2020 23:58:49 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id d63sm22195666wmc.22.2020.06.14.23.58.47 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 14 Jun 2020 23:58:48 -0700 (PDT) Date: Mon, 15 Jun 2020 08:58:46 +0200 From: Krzysztof Kozlowski To: wu000273@umn.edu Cc: kjlu@umn.edu, =?utf-8?Q?=C5=81ukasz?= Stelmach , Matt Mackall , Herbert Xu , Arnd Bergmann , Greg Kroah-Hartman , Kukjin Kim , Philippe Ombredanne , linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] char: hw_random: Fix a reference count leak. Message-ID: <20200615065846.GA5791@kozik-lap> References: <20200613214128.32665-1-wu000273@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200613214128.32665-1-wu000273@umn.edu> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Jun 13, 2020 at 04:41:28PM -0500, wu000273@umn.edu wrote: > From: Qiushi Wu > > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count if pm_runtime_put_sync is not > called in error handling paths. Thus replace the jump target > "err_pm_get" by "err_clock". > > Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver") > Signed-off-by: Qiushi Wu 1. Cc: 2. Subject prefix: hwrng: exynos - 3. Subject title: Fix PM runtime reference count leak (no need for end stop) With these changes: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6735DC433E1 for ; Mon, 15 Jun 2020 06:58:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AE4D2067B for ; Mon, 15 Jun 2020 06:58:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="domXdZ2E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AE4D2067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WqtZovueF9Isj8tjqhgK7ECmgkXZOQTevMeothMLHM8=; b=domXdZ2EVhJvLq o/KV+iguM/OD6V9GmxQElSSKjSyWLe6MBpJMYcbNZU0l/rZOmbsQs1dHR5k2P76Dkf0+Lqod9gmbe qdrvcD2k1YEXT6RML+CZwXlmUCAAvkykD8HHi0GOytHOfWgyc2LoxbLaRHnqcn3mQpaoMgjJoxXDY mRPlWL6kHxR5kQyS7cJZ/fX6oJmvZ8HOYXu5asjYIYcpoadzMUvW8LRpOSrV6s40ndlarIM9B94Iy LbZq+5BesX1lzIGNRudzhxX19KEsRodqEt5cZrfnxohbuz6MzwfFdtA3ycaDyaWFImbpDn1lvNjqY MhYjCO8tOQ73iTI/aMAw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkj53-0001mA-QI; Mon, 15 Jun 2020 06:58:53 +0000 Received: from mail-wr1-f67.google.com ([209.85.221.67]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkj51-0001la-3O for linux-arm-kernel@lists.infradead.org; Mon, 15 Jun 2020 06:58:52 +0000 Received: by mail-wr1-f67.google.com with SMTP id e1so15863988wrt.5 for ; Sun, 14 Jun 2020 23:58:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=15pzvZ3HgzVpOIe1NSunNL4NazqLAoN4J8Q/f2NVLd8=; b=QozXOaaMSC1bqfUGQwD/5I63mqsEKQ98Y2jkg9jqC9wdbUqXjokcQ3R9V7BgmDT3so KBwHYwHC0el+No1e33IAPR5/yVZ3X6P9nSTzbC03mRgrnhCCE5TGUekxbT+CQs2y/bD3 Ot46NbcVZfPvay/FuTxFIk2DeEv6f1/tgVVNI/G8a3/Sdo+PO2J8nfHmBuhRxfvQu5yO 32D1R8fGfCTYFpyZUZE6tsa+flpbCsFNthHnoqoFPJKrLXVzw4gY3ZIMNBlLgF6QtWKA m1b5y1TxqhSK2rKOaLvXbDdrEvd3fU00gL56JvbT79yxz1yIGORnHgwo7yDBQpkN38bb 9vvQ== X-Gm-Message-State: AOAM5300y1JLRE9KBgxFC4yBNLNnidfS9+bOeKm2vRVuIyUWZnXsBMKW 3PJvHF6a8xJQ8BDEan/ZjW0= X-Google-Smtp-Source: ABdhPJxC3uTidSFQuPJd5N+ZIugAF5DjMqJZwBdBMRxo/CsJfJGnW54QJwO/PEzPpqMarcPL1KnxUw== X-Received: by 2002:a5d:5585:: with SMTP id i5mr26775604wrv.112.1592204329345; Sun, 14 Jun 2020 23:58:49 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id d63sm22195666wmc.22.2020.06.14.23.58.47 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 14 Jun 2020 23:58:48 -0700 (PDT) Date: Mon, 15 Jun 2020 08:58:46 +0200 From: Krzysztof Kozlowski To: wu000273@umn.edu Subject: Re: [PATCH] char: hw_random: Fix a reference count leak. Message-ID: <20200615065846.GA5791@kozik-lap> References: <20200613214128.32665-1-wu000273@umn.edu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200613214128.32665-1-wu000273@umn.edu> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200614_235851_140777_D561E261 X-CRM114-Status: GOOD ( 10.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Herbert Xu , Arnd Bergmann , Greg Kroah-Hartman , Philippe Ombredanne , =?utf-8?Q?=C5=81ukasz?= Stelmach , linux-kernel@vger.kernel.org, Kukjin Kim , linux-crypto@vger.kernel.org, Matt Mackall , kjlu@umn.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jun 13, 2020 at 04:41:28PM -0500, wu000273@umn.edu wrote: > From: Qiushi Wu > > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count if pm_runtime_put_sync is not > called in error handling paths. Thus replace the jump target > "err_pm_get" by "err_clock". > > Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver") > Signed-off-by: Qiushi Wu 1. Cc: 2. Subject prefix: hwrng: exynos - 3. Subject title: Fix PM runtime reference count leak (no need for end stop) With these changes: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel