From: Mark Brown <broonie@kernel.org>
To: Wesley Cheng <wcheng@codeaurora.org>
Cc: robh+dt@kernel.org, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org, mark.rutland@arm.com,
lgirdwood@gmail.com, agross@kernel.org,
bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, lijun.kernel@gmail.com,
rdunlap@infradead.org, jackp@codeaurora.org,
bryan.odonoghue@linaro.org
Subject: Re: [PATCH v2 4/6] regulator: Add support for QCOM PMIC VBUS booster
Date: Mon, 15 Jun 2020 13:00:18 +0100 [thread overview]
Message-ID: <20200615120018.GI4447@sirena.org.uk> (raw)
In-Reply-To: <20200612231918.8001-5-wcheng@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 789 bytes --]
On Fri, Jun 12, 2020 at 04:19:16PM -0700, Wesley Cheng wrote:
> +++ b/drivers/regulator/qcom_usb_vbus-regulator.c
> @@ -0,0 +1,147 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2020, The Linux Foundation. All rights reserved.
> + */
Please make the entire comment a C++ one so things look more
intentional.
> +static int qcom_usb_vbus_enable(struct regulator_dev *rdev)
> +{
> +static int qcom_usb_vbus_disable(struct regulator_dev *rdev)
> +{
> +static int qcom_usb_vbus_is_enabled(struct regulator_dev *rdev)
> +{
These operations can all be replaced by regulator_is_enabled_regmap()
and friends.
> + init_data.constraints.valid_ops_mask |= REGULATOR_CHANGE_STATUS;
No, this is broken - regulators should not override the constraints the
machine sets.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-15 12:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 23:19 [PATCH v2 0/6] Introduce PMIC based USB type C detection Wesley Cheng
2020-06-12 23:19 ` [PATCH v2 1/6] usb: typec: Add QCOM PMIC typec detection driver Wesley Cheng
2020-06-12 23:19 ` [PATCH v2 2/6] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding Wesley Cheng
2020-06-12 23:19 ` [PATCH v2 3/6] arm64: boot: dts: qcom: pm8150b: Add node for USB type C block Wesley Cheng
2020-06-12 23:19 ` [PATCH v2 4/6] regulator: Add support for QCOM PMIC VBUS booster Wesley Cheng
2020-06-13 3:28 ` Randy Dunlap
2020-06-16 4:21 ` Wesley Cheng
2020-06-15 12:00 ` Mark Brown [this message]
2020-06-16 4:27 ` Wesley Cheng
2020-06-12 23:19 ` [PATCH v2 5/6] dt-bindings: regulator: Add dt-binding for QCOM PMIC VBUS output regulator Wesley Cheng
2020-06-12 23:19 ` [PATCH v2 6/6] arm64: boot: dts: qcom: pm8150b: Add DTS node for PMIC VBUS booster Wesley Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615120018.GI4447@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jackp@codeaurora.org \
--cc=lgirdwood@gmail.com \
--cc=lijun.kernel@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.