From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 422B6C433E0 for ; Mon, 15 Jun 2020 12:59:28 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id C28F82076A for ; Mon, 15 Jun 2020 12:59:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C28F82076A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1982D4B09B; Mon, 15 Jun 2020 08:59:27 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eyiExMBx8KrD; Mon, 15 Jun 2020 08:59:26 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0EC164B09F; Mon, 15 Jun 2020 08:59:26 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id AE9674B09B for ; Mon, 15 Jun 2020 08:59:25 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 72BOXXL8CFNy for ; Mon, 15 Jun 2020 08:59:24 -0400 (EDT) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 71D074A4E5 for ; Mon, 15 Jun 2020 08:59:24 -0400 (EDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E334431B; Mon, 15 Jun 2020 05:59:23 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2461D3F6CF; Mon, 15 Jun 2020 05:59:23 -0700 (PDT) Date: Mon, 15 Jun 2020 13:59:21 +0100 From: Dave Martin To: Marc Zyngier Subject: Re: [PATCH 0/4] KVM/arm64: Enable PtrAuth on non-VHE KVM Message-ID: <20200615125920.GJ25945@arm.com> References: <20200615081954.6233-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200615081954.6233-1-maz@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: kernel-team@android.com, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, Jun 15, 2020 at 09:19:50AM +0100, Marc Zyngier wrote: > Not having PtrAuth on non-VHE KVM (for whatever reason VHE is not > enabled on a v8.3 system) has always looked like an oddity. This > trivial series remedies it, and allows a non-VHE KVM to offer PtrAuth > to its guests. How likely do you think it is that people will use such a configuration? The only reason I can see for people to build a kernel with CONFIG_VHE=n is as a workaround for broken hardware, or because the kernel is too old to support VHE (in which case it doesn't understand ptrauth either, so it is irrelevant whether ptrauth depends on VHE). I wonder whether it's therefore better to "encourage" people to turn VHE on by making subsequent features depend on it where appropriate. We do want multiplatform kernels to be configured with CONFIG_VHE=y for example. I ask this, because SVE suffers the same "oddity". If SVE can be enabled for non-VHE kernels straightforwardly then there's no reason not to do so, but I worried in the past that this would duplicate complex code that would never be tested or used. If supporting ptrauth with !VHE is as simple as this series suggests, then it's low-risk. Perhaps SVE isn't much worse. I was chasing nasty bugs around at the time the SVE KVM support was originally written, and didn't want to add more unknowns into the mix... (Note, this is not an offer from me to do the SVE work!) [...] Cheers ---Dave _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C41A4C433E0 for ; Mon, 15 Jun 2020 12:59:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 944C22076A for ; Mon, 15 Jun 2020 12:59:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lwYvs1jc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 944C22076A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4os9wrb4i7lJYxCILFIJgbmZ4eiNifunoQAaXnLsBrE=; b=lwYvs1jcO85TAJ tZVhx9ZQLkXRp0vv5UMPMyG57VyWQHcCLOaKRzXS5pwhRbG4gch9P2XEYp8U95wp1fqnoxM+H/q4E NJGRKJcD6Iu3nrNHzRP89vKOxRxccdxpjPdycz0IkJH5n5etYC2/x+u9x1YCh7Jf1xwjyCrb2aOH1 UsJ+02tIC+PjHQUjwGqGFVTiv60LzA/WJP0IJqKI6FKz3E/0X42qt2jsaQHeQdeDf38j7fTcRYBWD bfotTblXNsoaM5Jhn7Re7xOBA/Ia9NeBJEBVFSxRfemZnYlcvz0N9/wpf59XfVMLh/dHfYuzQfeHn 3bK7WM5gm7NYRsdM1P8g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkohz-0004w5-GF; Mon, 15 Jun 2020 12:59:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkohx-0004uw-1S for linux-arm-kernel@lists.infradead.org; Mon, 15 Jun 2020 12:59:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E334431B; Mon, 15 Jun 2020 05:59:23 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2461D3F6CF; Mon, 15 Jun 2020 05:59:23 -0700 (PDT) Date: Mon, 15 Jun 2020 13:59:21 +0100 From: Dave Martin To: Marc Zyngier Subject: Re: [PATCH 0/4] KVM/arm64: Enable PtrAuth on non-VHE KVM Message-ID: <20200615125920.GJ25945@arm.com> References: <20200615081954.6233-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200615081954.6233-1-maz@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200615_055925_150675_3CC15792 X-CRM114-Status: GOOD ( 14.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 15, 2020 at 09:19:50AM +0100, Marc Zyngier wrote: > Not having PtrAuth on non-VHE KVM (for whatever reason VHE is not > enabled on a v8.3 system) has always looked like an oddity. This > trivial series remedies it, and allows a non-VHE KVM to offer PtrAuth > to its guests. How likely do you think it is that people will use such a configuration? The only reason I can see for people to build a kernel with CONFIG_VHE=n is as a workaround for broken hardware, or because the kernel is too old to support VHE (in which case it doesn't understand ptrauth either, so it is irrelevant whether ptrauth depends on VHE). I wonder whether it's therefore better to "encourage" people to turn VHE on by making subsequent features depend on it where appropriate. We do want multiplatform kernels to be configured with CONFIG_VHE=y for example. I ask this, because SVE suffers the same "oddity". If SVE can be enabled for non-VHE kernels straightforwardly then there's no reason not to do so, but I worried in the past that this would duplicate complex code that would never be tested or used. If supporting ptrauth with !VHE is as simple as this series suggests, then it's low-risk. Perhaps SVE isn't much worse. I was chasing nasty bugs around at the time the SVE KVM support was originally written, and didn't want to add more unknowns into the mix... (Note, this is not an offer from me to do the SVE work!) [...] Cheers ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FE9EC433E0 for ; Mon, 15 Jun 2020 12:59:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FB6B2076A for ; Mon, 15 Jun 2020 12:59:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730097AbgFOM7Z (ORCPT ); Mon, 15 Jun 2020 08:59:25 -0400 Received: from foss.arm.com ([217.140.110.172]:47210 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730070AbgFOM7Y (ORCPT ); Mon, 15 Jun 2020 08:59:24 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E334431B; Mon, 15 Jun 2020 05:59:23 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2461D3F6CF; Mon, 15 Jun 2020 05:59:23 -0700 (PDT) Date: Mon, 15 Jun 2020 13:59:21 +0100 From: Dave Martin To: Marc Zyngier Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kernel-team@android.com Subject: Re: [PATCH 0/4] KVM/arm64: Enable PtrAuth on non-VHE KVM Message-ID: <20200615125920.GJ25945@arm.com> References: <20200615081954.6233-1-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200615081954.6233-1-maz@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Jun 15, 2020 at 09:19:50AM +0100, Marc Zyngier wrote: > Not having PtrAuth on non-VHE KVM (for whatever reason VHE is not > enabled on a v8.3 system) has always looked like an oddity. This > trivial series remedies it, and allows a non-VHE KVM to offer PtrAuth > to its guests. How likely do you think it is that people will use such a configuration? The only reason I can see for people to build a kernel with CONFIG_VHE=n is as a workaround for broken hardware, or because the kernel is too old to support VHE (in which case it doesn't understand ptrauth either, so it is irrelevant whether ptrauth depends on VHE). I wonder whether it's therefore better to "encourage" people to turn VHE on by making subsequent features depend on it where appropriate. We do want multiplatform kernels to be configured with CONFIG_VHE=y for example. I ask this, because SVE suffers the same "oddity". If SVE can be enabled for non-VHE kernels straightforwardly then there's no reason not to do so, but I worried in the past that this would duplicate complex code that would never be tested or used. If supporting ptrauth with !VHE is as simple as this series suggests, then it's low-risk. Perhaps SVE isn't much worse. I was chasing nasty bugs around at the time the SVE KVM support was originally written, and didn't want to add more unknowns into the mix... (Note, this is not an offer from me to do the SVE work!) [...] Cheers ---Dave