From: Mark Brown <broonie@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Krzysztof Kozlowski <krzk@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
linux-spi <linux-spi@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Wolfram Sang <wsa@kernel.org>,
stable@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH v2 1/3] spi: spi-fsl-dspi: Fix external abort on interrupt in exit paths
Date: Mon, 15 Jun 2020 14:24:41 +0100 [thread overview]
Message-ID: <20200615132441.GS4447@sirena.org.uk> (raw)
In-Reply-To: <CA+h21hpusy=zx8AuUqk_4zShtst8QeNJxCPT4dMGh0jhm5uZng@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
On Mon, Jun 15, 2020 at 04:12:28PM +0300, Vladimir Oltean wrote:
> On Mon, 15 Jun 2020 at 16:10, Mark Brown <broonie@kernel.org> wrote:
> > It's a bit unusual to need to actually free the IRQ over suspend -
> > what's driving that requirement here?
> clk_disable_unprepare(dspi->clk); is driving the requirement - same as
> in dspi_remove case, the module will fault when its registers are
> accessed without a clock.
I see - this could be fixed by having the interrupt handler bounce the
clock on, there's a little overhead from that but hopefully not too
much. That should also help with the remove case I guess so long as the
clock is registered before the interrupt is requested?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-15 13:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 8:07 [PATCH v2 1/3] spi: spi-fsl-dspi: Fix external abort on interrupt in exit paths Krzysztof Kozlowski
2020-06-15 8:07 ` [PATCH v2 2/3] spi: spi-fsl-dspi: Initialize completion before possible interrupt Krzysztof Kozlowski
2020-06-15 8:07 ` [PATCH v2 3/3] genirq: Do not test disabled IRQs with DEBUG_SHIRQ Krzysztof Kozlowski
2020-06-15 12:08 ` Mark Brown
2020-06-16 10:11 ` Krzysztof Kozlowski
2020-06-16 10:39 ` Mark Brown
2020-06-17 9:30 ` Thomas Gleixner
2020-06-15 8:17 ` [PATCH v2 1/3] spi: spi-fsl-dspi: Fix external abort on interrupt in exit paths Marc Kleine-Budde
2020-06-15 9:23 ` Vladimir Oltean
2020-06-15 13:08 ` Krzysztof Kozlowski
2020-06-15 12:30 ` Mark Brown
2020-06-15 12:56 ` Vladimir Oltean
2020-06-15 13:10 ` Mark Brown
2020-06-15 13:12 ` Vladimir Oltean
2020-06-15 13:24 ` Mark Brown [this message]
2020-06-15 13:29 ` Vladimir Oltean
2020-06-15 13:36 ` Mark Brown
2020-06-15 13:41 ` Krzysztof Kozlowski
2020-06-15 14:23 ` Vladimir Oltean
2020-06-15 14:57 ` Krzysztof Kozlowski
2020-06-15 14:59 ` Vladimir Oltean
2020-06-15 13:10 ` Krzysztof Kozlowski
2020-06-15 13:14 ` Vladimir Oltean
2020-06-15 13:28 ` Krzysztof Kozlowski
2020-06-15 13:33 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615132441.GS4447@sirena.org.uk \
--to=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vladimir.oltean@nxp.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.