From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6195C433DF for ; Mon, 15 Jun 2020 14:33:16 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3D8A206B7 for ; Mon, 15 Jun 2020 14:33:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QqMwmPns" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3D8A206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jkqAW-00022V-CV; Mon, 15 Jun 2020 14:33:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jkqAV-00022Q-3z for xen-devel@lists.xenproject.org; Mon, 15 Jun 2020 14:32:59 +0000 X-Inumbo-ID: 1bfc8be2-af15-11ea-8496-bc764e2007e4 Received: from mail-qk1-x743.google.com (unknown [2607:f8b0:4864:20::743]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1bfc8be2-af15-11ea-8496-bc764e2007e4; Mon, 15 Jun 2020 14:32:58 +0000 (UTC) Received: by mail-qk1-x743.google.com with SMTP id q8so15841502qkm.12 for ; Mon, 15 Jun 2020 07:32:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xoZYTOrbaJ/qtaL6gpEpGtLcw0cV9fBngumMP/8sReM=; b=QqMwmPns7wD3eXZ6V0fxcUauGKmQdLa0qaGV+ui0UVjeLm3GJOf8PkWn05rZLVZ6cU MNa1fpNum1BkwRikQ/FGMbdafVZwS/DW4pPKA+l2KZj/kagtsti+YhIbeAc50CW8KIP4 IQXfGQm3t3C2zqMW/IvYHKtXWtBV3F3xANmv00MdwJYw9bZNg767PYgzbMQ6XmcyDAFP RULDhhEdblcWtq6b5nfNxZxBvH57qI+MSLsKUuPU4B1KNXGpB3DyY7g8qbYTEmC+sUEf 023/tK/31qHeHLvT/0tXnylBikV/DgGwYRIAV+TGLSPQPx02Xxq+831Bor96wmzoU9ez 7lNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xoZYTOrbaJ/qtaL6gpEpGtLcw0cV9fBngumMP/8sReM=; b=lnThhLiyoH1qhaW+rBzO7A+/d8nbSwGiuY9WZb2HkyHItCxY6sIaxuKNvhkSwjR5Wh IKnWP2Jeozc+sgIBe0bbuQWh0bK4QvDmCJKFW695yO0xQKHDsEQernu9ivQ/dfuZRgxP Q9IYPm2fGIsaPA275alSWTZ/3on0MPvwhNj/hIPE3aTlZkaL/Ys70WBKrovdrNacRUSQ 1OgE8p4bWk7eIImUy0ML6iiCH4UllwM95vDV52XgpsWTICKDeOfeAMoS5aeNbJgeUZGH Y49rnpLYe796lSVayK4LfLYgiD19q1IZ4aedDY0xFCN7Emjkl+UUvxvfTxL6ewyRWfRV sIzQ== X-Gm-Message-State: AOAM532xzTk1d8sYUmf6pQRhuAQOmAYl+4x298E0kKl0brBj4p32hDOy D9QAOjssqBcjqiY9rL+q2+Y= X-Google-Smtp-Source: ABdhPJw/swk4IFbSzol+4IYT/MmFSzV1G1JXY4dekTCGcaYcTfpMcGWLNv9chzO3z40pRE2+DA0+Ew== X-Received: by 2002:a37:f505:: with SMTP id l5mr15143174qkk.118.1592231578399; Mon, 15 Jun 2020 07:32:58 -0700 (PDT) Received: from six (cpe-67-241-56-252.twcny.res.rr.com. [67.241.56.252]) by smtp.gmail.com with ESMTPSA id d14sm10990442qkk.5.2020.06.15.07.32.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Jun 2020 07:32:56 -0700 (PDT) Date: Mon, 15 Jun 2020 10:32:54 -0400 From: Nick Rosbrook To: Ian Jackson Subject: Re: [PATCH for-4.14] tools: check go compiler version if present Message-ID: <20200615143254.GA29455@six> References: <24291.45045.185355.587474@mariner.uk.xensource.com> <20200612215028.GA6286@six> <24295.31778.201405.748753@mariner.uk.xensource.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24295.31778.201405.748753@mariner.uk.xensource.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Nick Rosbrook , "xen-devel@lists.xenproject.org" , George Dunlap , Wei Liu , "paul@xen.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > Ideally at some point maybe we would make this clearer but not now. Okay, sounds good. > Have you tested the situations you describe ? That might be a better > way of checking that it's right than the code inspection which is > obviously failing for me now... Yes, I have tested the following situations: (1) ./configure without go installed => go is not enabled (2) ./configure with go version < 1.11.1 => go is not enabled (3) ./configure with go version > 1.11.1 => go is enabled (4) ./configure --enable-golang without go installed => error (5) ./configure --enable-golang with go < 1.11.1 => error (6) ./configure --disable-golang in any case => go is not enabled > > I definitely think we want to fix this for 4.14. So thanks for your > continued help! You're welcome. Thank you again for the review. -NR