From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8411C433DF for ; Mon, 15 Jun 2020 17:25:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E25D207DD for ; Mon, 15 Jun 2020 17:25:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592241959; bh=WDkf6lzZ6UgWs3EMY6W8Qdhefho3OZTzr9BHJ5YRgCM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=M416XIDEo2GbxEaLy28tuLRAwaUf9tmUnLDPl1l6G74WstS+GFTr450GdThBb3TDo JzwGdZoLtliYz4gwZIkHMw6NM2J6Qpnu1cclMbHkxv0VMKIBOvgaYm2MfUarkCmbj5 fl33TWyAVWu2ZZIBvBigUb/oxK0ESOhnq0vMPH/4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731065AbgFORZ7 (ORCPT ); Mon, 15 Jun 2020 13:25:59 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:42802 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729682AbgFORZ4 (ORCPT ); Mon, 15 Jun 2020 13:25:56 -0400 Received: by mail-io1-f68.google.com with SMTP id x189so9699243iof.9; Mon, 15 Jun 2020 10:25:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dS/bdtyItiFAm48ZgF1YTbFmFfDKJ+FCEj9MlB0IAp4=; b=Mh0Ka0/cKEgpKLlxOSeYVWIMR6LVkaGR3s77d98ifHYMG3k2Eax8NY1OM9nctyhEJw CgSnNMTtUwWe38pErH3E2fvU21HrLYHmPwn8edEJV6En26Ev/txmMvg+NvN3lNiyAyiv DqZprbJCizSTxTJ/B7zMIXgyr3F9TY1BKVeLRpDCkycUbAODGkMURseBQSZO48sPBh5Z ZGcQmzla5KMbNLuwFpZKDIfC/+1XhyaUiRLDZglovWDCRMkRDT4hJ/uvdAf+0eDaZZey M63luWtJq55bdYxTBLfg3T2UhHNNd7s/g5+wco2O7Buy6TOMnDuHUC6MhCc4j4qNc1Xe MrYQ== X-Gm-Message-State: AOAM533Y0eTeIdSCEqOd5Uub/6Oc86tBfF18dJDXqmcJAMrs0h6Kpf5b +bZO5tJ5lkYBtAKyawWsHQ== X-Google-Smtp-Source: ABdhPJypddMh0DtNo4yEvMLEEWMso2FJiLJSg0Shc51QJu95Vb3Bgqf+obC4mOb9N+9IlXsrnh6G0Q== X-Received: by 2002:a02:6c8f:: with SMTP id w137mr23100744jab.38.1592241955783; Mon, 15 Jun 2020 10:25:55 -0700 (PDT) Received: from xps15 ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id 2sm8612606ila.0.2020.06.15.10.25.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 10:25:55 -0700 (PDT) Received: (nullmailer pid 1992268 invoked by uid 1000); Mon, 15 Jun 2020 17:25:52 -0000 Date: Mon, 15 Jun 2020 11:25:52 -0600 From: Rob Herring To: Lukas Wunner Cc: Florian Fainelli , linux-kernel@vger.kernel.org, Mark Brown , Nicolas Saenz Julienne , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , "open list:SPI SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Martin Sperl Subject: Re: [PATCH 3/3] spi: bcm2835: Enable shared interrupt support Message-ID: <20200615172552.GA1978070@bogus> References: <20200604034655.15930-1-f.fainelli@gmail.com> <20200604034655.15930-4-f.fainelli@gmail.com> <20200604041732.7ijkvad2yadtgjid@wunner.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200604041732.7ijkvad2yadtgjid@wunner.de> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Thu, Jun 04, 2020 at 06:17:32AM +0200, Lukas Wunner wrote: > On Wed, Jun 03, 2020 at 08:46:55PM -0700, Florian Fainelli wrote: > > +static const struct of_device_id bcm2835_spi_match[] = { > > + { .compatible = "brcm,bcm2835-spi", .data = &bcm2835_spi_interrupt }, > > + { .compatible = "brcm,bcm2711-spi", .data = &bcm2835_spi_sh_interrupt }, > > + { .compatible = "brcm,bcm7211-spi", .data = &bcm2835_spi_sh_interrupt }, > > + {} > > +}; > > +MODULE_DEVICE_TABLE(of, bcm2835_spi_match); > > Maybe I'm missing something but I think you either have to reverse the > order of the entries in this array or change patch [2/3] to drop > "brcm,bcm2835-spi" from the compatible string: > > __of_match_node() iterates over the entries in the array above and > calls __of_device_is_compatible() for each of them, which returns > success if the entry matches any of the device's compatible string. The order here doesn't matter. I'm pretty sure we fixed this years ago to always match to the most specific compatible. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF15AC433E2 for ; Mon, 15 Jun 2020 17:26:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0ECD207DD for ; Mon, 15 Jun 2020 17:26:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P5o/OVli" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0ECD207DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/djp3PAjv5Rh0NCzCQ/2OT9yHVv1FCPirjikJTM/uQ0=; b=P5o/OVliPGGtR6 wPlJOXzfZvouhir67qTbrCKOxsUuewMzQUjKgM8XgepyLYJXwXFZmw53PAhATd3R36exTtqam+IEU qQMXmsEW/RGruOw6NIBay6J21Eu+eWuE6VSd8o3ah82rh7B8drRQYOxK1dCOhN6GAcaBhr0t8kmL3 RggudZ0WBMFllD+xEvnm7z0xQiXnBmxMawo8G+yJD5ypv7TVJmB0+AyYGAvwSyMYkWlTDJZev8QbV cBrIGYeEImSJQr2F0QEbiDX+8yU6tMvcn9OZC5/2jN72el4+X30kABfWRMabd3vlKYkCGn1ZJSHvl Dmkgn/ZIt5tuH0thHCAQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jksrw-0004kV-Vf; Mon, 15 Jun 2020 17:26:00 +0000 Received: from mail-io1-f66.google.com ([209.85.166.66]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jksrt-0004j6-R7; Mon, 15 Jun 2020 17:25:59 +0000 Received: by mail-io1-f66.google.com with SMTP id r2so285218ioo.4; Mon, 15 Jun 2020 10:25:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dS/bdtyItiFAm48ZgF1YTbFmFfDKJ+FCEj9MlB0IAp4=; b=hWZtrTIviL9HuEh2J9g3xQ4cCd0fHYkoY/P/Ijy8NONUBJGxeahy2z6cMxhEiYBSRB wdv1G6ZtxYSE3aQx3sYAfuDwTpCpi9+2UJjGZteVIrvneTQDUdEVxnOtLyR88lGVRCyw xY53io7ZBmbb4lk83bkVUFaFMSf090mz3T1j4vptg9rC1bwlKfCVGFkFeHmBhU91rBuB bjsIwifCAZRHJjGEWC1iSs/ytuyrkJNGdnTRhgZHwRuVbiutwLpnq1hUMoLJMb1Ralme mD4XHQf03aXSNOsF4mTR8raxNiYQelxf8ZD57YvH3bSuAwb/VSGvpENtAgz1LuyzffuO y4ew== X-Gm-Message-State: AOAM5329i5TyVAcwnydgt7Z2lrV/SuJHa99cW/fJB47Q7XszBSfi/KuV +YY7mI0YMefM16U31DPisw== X-Google-Smtp-Source: ABdhPJypddMh0DtNo4yEvMLEEWMso2FJiLJSg0Shc51QJu95Vb3Bgqf+obC4mOb9N+9IlXsrnh6G0Q== X-Received: by 2002:a02:6c8f:: with SMTP id w137mr23100744jab.38.1592241955783; Mon, 15 Jun 2020 10:25:55 -0700 (PDT) Received: from xps15 ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id 2sm8612606ila.0.2020.06.15.10.25.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 10:25:55 -0700 (PDT) Received: (nullmailer pid 1992268 invoked by uid 1000); Mon, 15 Jun 2020 17:25:52 -0000 Date: Mon, 15 Jun 2020 11:25:52 -0600 From: Rob Herring To: Lukas Wunner Subject: Re: [PATCH 3/3] spi: bcm2835: Enable shared interrupt support Message-ID: <20200615172552.GA1978070@bogus> References: <20200604034655.15930-1-f.fainelli@gmail.com> <20200604034655.15930-4-f.fainelli@gmail.com> <20200604041732.7ijkvad2yadtgjid@wunner.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200604041732.7ijkvad2yadtgjid@wunner.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200615_102557_875167_99810AC6 X-CRM114-Status: GOOD ( 11.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Florian Fainelli , Scott Branden , Ray Jui , linux-kernel@vger.kernel.org, "open list:SPI SUBSYSTEM" , Mark Brown , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Martin Sperl , Nicolas Saenz Julienne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 04, 2020 at 06:17:32AM +0200, Lukas Wunner wrote: > On Wed, Jun 03, 2020 at 08:46:55PM -0700, Florian Fainelli wrote: > > +static const struct of_device_id bcm2835_spi_match[] = { > > + { .compatible = "brcm,bcm2835-spi", .data = &bcm2835_spi_interrupt }, > > + { .compatible = "brcm,bcm2711-spi", .data = &bcm2835_spi_sh_interrupt }, > > + { .compatible = "brcm,bcm7211-spi", .data = &bcm2835_spi_sh_interrupt }, > > + {} > > +}; > > +MODULE_DEVICE_TABLE(of, bcm2835_spi_match); > > Maybe I'm missing something but I think you either have to reverse the > order of the entries in this array or change patch [2/3] to drop > "brcm,bcm2835-spi" from the compatible string: > > __of_match_node() iterates over the entries in the array above and > calls __of_device_is_compatible() for each of them, which returns > success if the entry matches any of the device's compatible string. The order here doesn't matter. I'm pretty sure we fixed this years ago to always match to the most specific compatible. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel