Re: [PATCH v3 for-next 07/16] IB/ipoib: Increase ipoib Datagram mode MTU's upper limit

[Leon Romanovsky <leon@kernel.org>]

On Mon, Jun 15, 2020 at 05:56:50PM -0700, Nathan Chancellor wrote:
> On Mon, Jun 01, 2020 at 10:57:22AM -0300, Jason Gunthorpe wrote:
> > On Mon, Jun 01, 2020 at 09:48:47AM -0400, Dennis Dalessandro wrote:
> >
> > > They should probably all be in "enum ib_mtu". Jason any issues with us donig
> > > that? I can't for certain recall the real reason they were kept separate in
> > > the first place.
> >
> > It is probably OK
> >
> > Jason
>
> I don't mind taking a wack at this if you guys are too busy (I'm rather
> tired of seeing the warning across all of my builds). However, I am
> wondering how far should this be unwound? Should 'enum opa_mtu' be
> collapsed into 'enum ib_mtu' and then all of the opa conversion
> functions be eliminated in favor of the ib ones? It looks like
> OPA_MTU_8192 and OPA_MTU_10240 are used in a few places within
> drivers/infiniband/hw/hfi1, should all of those instances be converted
> over to IB_MTU_* and the defines at the top of
> drivers/infiniband/hw/hfi1/hfi.h be eliminated?

We rather keep separation due to logic separation.

While ib_* defines come from IBTA and interoperable across different
devices and vendors, opa_* definitions are Intel proprietary ones used
for the product that was canceled.

Thanks

>
> Cheers,
> Nathan