From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: axboe@fb.com, linux-nvme@lists.infradead.org, hch@lst.de,
Chris Walker <christopher.walker@gmail.com>,
sagi@grimberg.me
Subject: Re: [PATCH] nvme: Quirk for Samsung PM1733 controllers
Date: Tue, 16 Jun 2020 08:53:12 +0200 [thread overview]
Message-ID: <20200616065312.GA17250@lst.de> (raw)
In-Reply-To: <20200616002306.GB520528@dhcp-10-100-145-180.wdl.wdc.com>
On Mon, Jun 15, 2020 at 05:23:06PM -0700, Keith Busch wrote:
> Okay, so it's one of those types of nvme controllers that report "ready"
> then only return "not ready" error status for an arbitrary amount of
> time. The technical committee is considering how to get rid of this
> arbitrary wait, either with existing mechanisms or something new. We'll
> have to wait to see how they decide.
>
> In the meantime for drives behaving like this, the quirk delay should
> have come *after* nvme_wait_ready() rather than before since namespace
> readiness happens after controller ready. The currently existing quirks
> appear to be wrongly applied to most of the controllers using them.
> AFAIK, only one controller ever existed that actually needs the delay
> before wait_ready().
I think we could increase the number of retries to something larger than
nvme_max_retries for Inquiry in general to handle these controllers.
We'll still need some reasonable upper bound, though.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2020-06-16 6:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 23:12 [PATCH] nvme: Quirk for Samsung PM1733 controllers christopher.walker
2020-06-15 23:19 ` Chaitanya Kulkarni
2020-06-15 23:42 ` Keith Busch
2020-06-16 0:19 ` Chris Walker
[not found] ` <CAFD1iUqfki3O9HibUiy4hiYYwp-MEN+3ZogYfe8MUgdd2YZEqA@mail.gmail.com>
2020-06-16 0:23 ` Keith Busch
2020-06-16 6:53 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616065312.GA17250@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=christopher.walker@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.