From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: s.nawrocki@samsung.com, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH v2 2/4] mfd: arizona: Ensure 32k clock is put on driver unbind and error
Date: Tue, 16 Jun 2020 09:00:56 +0100 [thread overview]
Message-ID: <20200616080056.GG2608702@dell> (raw)
In-Reply-To: <20200615135323.15215-2-ckeepax@opensource.cirrus.com>
On Mon, 15 Jun 2020, Charles Keepax wrote:
> Whilst it doesn't matter if the internal 32k clock register settings
> are cleaned up on exit, as the part will be turned off losing any
> settings, hence the driver hasn't historially bothered. The external
> clock should however be cleaned up, as it could cause clocks to be
> left on, and will at best generate a warning on unbind.
>
> Add clean up on both the probe error path and unbind for the 32k
> clock.
>
> Fixes: cdd8da8cc66b ("mfd: arizona: Add gating of external MCLKn clocks")
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
>
> No changes since v1.
>
> Thanks,
> Charles
>
> drivers/mfd/arizona-core.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-06-16 8:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 13:53 [PATCH v2 1/4] mfd: arizona: Remove BUG_ON usage Charles Keepax
2020-06-15 13:53 ` [PATCH v2 2/4] mfd: arizona: Ensure 32k clock is put on driver unbind and error Charles Keepax
2020-06-16 8:00 ` Lee Jones [this message]
2020-06-15 13:53 ` [PATCH v2 3/4] mfd: madera: Remove unused forward declaration of madera_codec_pdata Charles Keepax
2020-06-16 8:01 ` Lee Jones
2020-06-15 13:53 ` [PATCH v2 4/4] mfd: madera: Fix minor formatting issues Charles Keepax
2020-06-16 8:02 ` Lee Jones
2020-06-16 8:01 ` [PATCH v2 1/4] mfd: arizona: Remove BUG_ON usage Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616080056.GG2608702@dell \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.