From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail27.static.mailgun.info ([104.130.122.27]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jl6lP-0006Iu-OJ for ath10k@lists.infradead.org; Tue, 16 Jun 2020 08:16:13 +0000 MIME-Version: 1.0 Subject: Re: [PATCH v6] ath10k: provide survey info as accumulated data From: Kalle Valo In-Reply-To: <1592232686-28712-1-git-send-email-kvalo@codeaurora.org> References: <1592232686-28712-1-git-send-email-kvalo@codeaurora.org> Message-Id: <20200616081611.32C3CC433CB@smtp.codeaurora.org> Date: Tue, 16 Jun 2020 08:16:11 +0000 (UTC) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: 24601deerej@gmail.com, linux-wireless@vger.kernel.org, sven@narfation.org, ath10k@lists.infradead.org, markus.theil@tu-ilmenau.de Kalle Valo wrote: > It is expected that the returned counters by .get_survey are monotonic > increasing. But the data from ath10k gets reset to zero regularly. Channel > active/busy time are then showing incorrect values (less than previous or > sometimes zero) for the currently active channel during successive survey > dump commands. > > example: > > $ iw dev wlan0 survey dump > Survey data from wlan0 > frequency: 5180 MHz [in use] > channel active time: 54995 ms > channel busy time: 432 ms > channel receive time: 0 ms > channel transmit time: 59 ms > ... > > $ iw dev wlan0 survey dump > Survey data from wlan0 > frequency: 5180 MHz [in use] > channel active time: 32592 ms > channel busy time: 254 ms > channel receive time: 0 ms > channel transmit time: 0 ms > ... > > The correct way to handle this is to use the non-clearing > WMI_BSS_SURVEY_REQ_TYPE_READ wmi_bss_survey_req_type. The firmware will > then accumulate the survey data and handle wrap arounds. > > Tested-on: QCA9984 hw1.0 10.4-3.5.3-00057 > Tested-on: QCA988X hw2.0 10.2.4-1.0-00047 > Tested-on: QCA9888 hw2.0 10.4-3.9.0.2-00024 > Tested-on: QCA4019 hw1.0 10.4-3.6-00140 > > Fixes: fa7937e3d5c2 ("ath10k: update bss channel survey information") > Signed-off-by: Venkateswara Naralasetty > Tested-by: Markus Theil > Tested-by: John Deere <24601deerej@gmail.com> > [sven@narfation.org: adjust commit message] > Signed-off-by: Sven Eckelmann > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 720e5c03e5cb ath10k: provide survey info as accumulated data -- https://patchwork.kernel.org/patch/11605281/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k