From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:5042:0:0:0:0:0 with SMTP id a2csp2474366lfm; Tue, 16 Jun 2020 03:09:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjl0FFd3OvdSL5q0Wm3YRF3nJDKRxUNfSyZd3h2zmJrx2mJGf5xBHpHtiTo7OPOIa4a9To X-Received: by 2002:a25:df83:: with SMTP id w125mr2973149ybg.354.1592302180990; Tue, 16 Jun 2020 03:09:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592302180; cv=none; d=google.com; s=arc-20160816; b=o+o2f3VJQv3v98eAz+1joDxL/LONu3WGFCAlQscZYTYC/M3ZBNj+Cq31jLGI9GZKPD J+4WF4F0zBiwr39WZiVn8Yk6P8hgTGQC+Gf3EDP4qmPVnzk9p6cbRvH7BD4gtv+wtjwb XnbeLEz7kQEfSFHnaoxSclNUKqtAZp+Hgd5SCnRiV790bQ0jxMwbGJJ44U0iATAG/Qxq hES9oOsTS3YlRmz3t6rsWLODHvkugPG17Xe3JPq3TS4OelG2Dib681YHMjhrxgIr5W7P eJV5NfCwGWupZ6+ZlDM5q9p63OKp6GNjQLgRbV+yCEu0toWBc34/mkrCKHjNiV0OJUID COhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-disposition:user-agent :in-reply-to:mime-version:references:message-id:subject:to:from:date :dkim-signature; bh=DZkRS2YKIYjTQ3m1364+zVUZcS7Kch3h1oiLa89smbI=; b=DCaS/dOkk8EJQhQDTeHPO4kg8JyZy3q2dKBd6G/k49Q6UYuRRheVf4NOYYKeEW1591 KJlp8cWsMY/+QvhqFZCoc0OVt2NE95wwuCHVY/AXGWpR4hExESW2/s2b1yAzusKHast7 M5ffJy+Eqow+JXnGnDJhUbHRNgjPXf67H/W1CtZoOuqzyPd51jEozUhG2PcilSYpiVfz jfj7PfiDW2bL/lHInRqKWD/rtHSuV9TnGbIQdMuMbPqP9n7/ny9FRQgzGopvD5vrOXGR UAaIgAE48QQbIPlTtuFQUHTCRQOz6TV4sy37/r2JtauM5xrZR5AROhPJR8d/JTEEdQTF 2ShA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=Gr44rEW3; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d18si15836878ybc.349.2020.06.16.03.09.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Jun 2020 03:09:40 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=Gr44rEW3; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:58246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jl8XE-0001UP-Cp for alex.bennee@linaro.org; Tue, 16 Jun 2020 06:09:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jl8Ms-0002N4-RG for qemu-arm@nongnu.org; Tue, 16 Jun 2020 05:58:58 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:30603 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jl8Mq-0004Pe-BA for qemu-arm@nongnu.org; Tue, 16 Jun 2020 05:58:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592301534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DZkRS2YKIYjTQ3m1364+zVUZcS7Kch3h1oiLa89smbI=; b=Gr44rEW3IwT/Z3XvZU00d6ODcyuGQ8oHa8htAurpPWL8J/6tBb3Ql3BKcnLJDPVv2Tj4Wk n1FHrV6AJAS4e97djCOe34HKjni2YWR5bXeF6FTp7RZj3ukb+xPGQMGi+xSh3TCIuy+zT9 UMlnvveR877t4/Ck+Lhxe8TDfh/KoKo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-PspdvweGNHatQN315_VJ-g-1; Tue, 16 Jun 2020 05:58:53 -0400 X-MC-Unique: PspdvweGNHatQN315_VJ-g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C21C5873426; Tue, 16 Jun 2020 09:58:51 +0000 (UTC) Received: from work-vm (ovpn-112-42.ams2.redhat.com [10.36.112.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AD3087BA14; Tue, 16 Jun 2020 09:58:49 +0000 (UTC) Date: Tue, 16 Jun 2020 10:58:46 +0100 From: "Dr. David Alan Gilbert" To: zhukeqian Subject: Re: [PATCH v2] migration: Count new_dirty instead of real_dirty Message-ID: <20200616095846.GA2788@work-vm> References: <20200616021059.25984-1-zhukeqian1@huawei.com> <20200616093551.GA2790@work-vm> <3a45d5a0-3acf-336d-520f-523bf588b551@huawei.com> MIME-Version: 1.0 In-Reply-To: <3a45d5a0-3acf-336d-520f-523bf588b551@huawei.com> User-Agent: Mutt/1.14.0 (2020-05-02) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.120; envelope-from=dgilbert@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/16 02:45:54 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, Paolo Bonzini , Juan Quintela , Chao Fan , qemu-devel@nongnu.org, qemu-arm@nongnu.org, jianjay.zhou@huawei.com, wanghaibin.wang@huawei.com Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: 0Q5rSA0WukIk * zhukeqian (zhukeqian1@huawei.com) wrote: > Hi Dave, > > On 2020/6/16 17:35, Dr. David Alan Gilbert wrote: > > * Keqian Zhu (zhukeqian1@huawei.com) wrote: > >> real_dirty_pages becomes equal to total ram size after dirty log sync > >> in ram_init_bitmaps, the reason is that the bitmap of ramblock is > >> initialized to be all set, so old path counts them as "real dirty" at > >> beginning. > >> > >> This causes wrong dirty rate and false positive throttling at the end > >> of first ram save iteration. > >> > >> Signed-off-by: Keqian Zhu > > > > Since this function already returns num_dirty, why not just change the > > caller to increment a counter based off the return value? > Yes, that would be better :-) . > > > > > Can you point to the code which is using this value that triggers the > > throttle? > > > In migration_trigger_throttle(), rs->num_dirty_pages_period is used. > And it corresponds to real_dirty_pages here. OK; so is the problem not the same as the check that's in there for blk_mig_bulk_activate - don't we need to do the same trick for ram bulk migration (i.e. the first pass). Dave > Thanks, > Keqian > > > Dave > > > > > [...] > >> > >> > > -- > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > > > > . > > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK