From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: Re: [PATCH][next] staging: rts5208: Use array_size() helper in vmalloc()
Date: Tue, 16 Jun 2020 13:13:12 +0300 [thread overview]
Message-ID: <20200616101312.GM4151@kadam> (raw)
In-Reply-To: <20200615230811.GA18818@embeddedor>
On Mon, Jun 15, 2020 at 06:08:11PM -0500, Gustavo A. R. Silva wrote:
> and memset()
Please don't start the commit message in the middle of a sentence. It's
a completely different thing from the title. When you're reading the
full email then the title is hidden in the headers and the Date: and
Message-ID: field go in between the title and the message body.
https://lore.kernel.org/lkml/20200615230811.GA18818@embeddedor/
I normally read either the title or the body but seldom read both when
I'm reviewing patches.
regards,
dan carpenter
next prev parent reply other threads:[~2020-06-16 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 23:08 [PATCH][next] staging: rts5208: Use array_size() helper in vmalloc() Gustavo A. R. Silva
2020-06-16 10:13 ` Dan Carpenter [this message]
2020-06-16 14:22 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616101312.GM4151@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.