All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Arturo Borrero Gonzalez <arturo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH] xtables-translate: don't fail if help was requested
Date: Tue, 16 Jun 2020 13:05:52 +0200	[thread overview]
Message-ID: <20200616110552.GP23632@orbyte.nwl.cc> (raw)
In-Reply-To: <159230001954.62609.10203108901931558446.stgit@endurance>

Hi Arturo,

On Tue, Jun 16, 2020 at 11:33:39AM +0200, Arturo Borrero Gonzalez wrote:
> If the user called `iptables-translate -h` then we have CMD_NONE and we should gracefully handle
> this case in do_command_xlate().
> 
> Before this patch, you would see:
> 
>  user@debian:~$ sudo iptables-translate -h
>  [..]
>  nft Unsupported command?
>  user@debian:~$ echo $?
>  1
> 
> After this patch:
> 
>  user@debian:~$ sudo iptables-translate -h
>  [..]
>  user@debian:~$ echo $?
>  0

Apparently I forgot to test xtables-restore after changing help
functions, thanks for fixing this up.

> Fixes: d4409d449c10fa ("nft: Don't exit early after printing help texts")
> Signed-off-by: Arturo Borrero Gonzalez <arturo@netfilter.org>

Acked-by: Phil Sutter <phil@nwl.cc>

Thanks, Phil

  reply	other threads:[~2020-06-16 11:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-16  9:33 [iptables PATCH] xtables-translate: don't fail if help was requested Arturo Borrero Gonzalez
2020-06-16 11:05 ` Phil Sutter [this message]
2020-06-16 12:52   ` Arturo Borrero Gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200616110552.GP23632@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=arturo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.